From: Caleb James DeLisle <cjd@cjdns.fr>
To: netdev@vger.kernel.org, ansuelsmth@gmail.com
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, daniel@makrotopia.org, dqfext@gmail.com,
SkyLake.Huang@mediatek.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, cjd@cjdns.fr,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH net-next 2/3] net: phy: mediatek: bug fixes to airoha-ge-soc.c
Date: Tue, 25 Aug 2026 19:34:55 +0000 [thread overview]
Message-ID: <20260825193456.1823985-3-cjd@cjdns.fr> (raw)
In-Reply-To: <20260825193456.1823985-1-cjd@cjdns.fr>
Fix crash bug from unconfigured shared, potential namespace collision
in devm_phy_package_join() and typo in Kconfig.
Signed-off-by: Caleb James DeLisle <cjd@cjdns.fr>
---
drivers/net/phy/mediatek/Kconfig | 2 +-
drivers/net/phy/mediatek/airoha-ge-soc.c | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mediatek/Kconfig b/drivers/net/phy/mediatek/Kconfig
index fe51f4616c54..b8df1a8016c6 100644
--- a/drivers/net/phy/mediatek/Kconfig
+++ b/drivers/net/phy/mediatek/Kconfig
@@ -9,7 +9,7 @@ config AIROHA_GE_SOC_PHY
Supports Airoha SoC built-in Gigabit Ethernet PHYs.
Include support for built-in Ethernet PHYs which are present in
- the AN7581 and AN7583 SoCs. These PHYs d will dynamically
+ the AN7581 and AN7583 SoCs. These PHYs will dynamically
calibrate during startup.
config MEDIATEK_2P5GE_PHY
diff --git a/drivers/net/phy/mediatek/airoha-ge-soc.c b/drivers/net/phy/mediatek/airoha-ge-soc.c
index 601a64d83365..ab183779ee84 100644
--- a/drivers/net/phy/mediatek/airoha-ge-soc.c
+++ b/drivers/net/phy/mediatek/airoha-ge-soc.c
@@ -1596,11 +1596,14 @@ static int an7581_phy_probe(struct phy_device *phydev)
dev_err(&phydev->mdio.bus->dev,
"Failed to setup PHY LED pinctrl\n");
- ret = devm_phy_package_join(&phydev->mdio.dev, phydev, 0,
+ ret = devm_phy_package_join(&phydev->mdio.dev, phydev,
+ AIROHA_DEFAULT_PORT0_ADDR,
sizeof(struct airoha_socphy_shared));
if (ret)
return ret;
+ shared = phy_package_get_priv(phydev);
+
priv = devm_kzalloc(&phydev->mdio.dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
--
2.39.5
next prev parent reply other threads:[~2026-08-25 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 19:34 [PATCH net-next 0/3] net: phy: mediatek: support EcoNet EN751221 gbit SoC PHY Caleb James DeLisle
2026-08-25 19:34 ` [PATCH net-next 1/3] net: phy: mediatek: move mtk_cal_cycle_wait to mtk-phy-lib Caleb James DeLisle
2026-08-25 19:34 ` Caleb James DeLisle [this message]
2026-08-25 19:34 ` [PATCH net-next 3/3] net: phy: mediatek: support EcoNet EN751221 gbit SoC PHY Caleb James DeLisle
2026-08-26 0:00 ` Andrew Lunn
2026-08-26 0:59 ` Caleb James DeLisle
2026-08-26 2:21 ` Andrew Lunn
2026-08-26 16:37 ` Caleb James DeLisle
2026-08-26 16:50 ` Andrew Lunn
2026-08-26 20:27 ` Caleb James DeLisle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825193456.1823985-3-cjd@cjdns.fr \
--to=cjd@cjdns.fr \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox