From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Alice Mikityanska <alice.kernel@fastmail.im>
Cc: David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
netdev@vger.kernel.org, Alice Mikityanska <alice@isovalent.com>
Subject: Re: [PATCH net v4 3/4] selftests: net: Test UDP length overflow with PMTU discover and big MTU
Date: Thu, 27 Aug 2026 12:28:56 -0700 [thread overview]
Message-ID: <20260827122856.4b6eeb96@kernel.org> (raw)
In-Reply-To: <willemdebruijn.kernel.3645a45d69737@gmail.com>
On Wed, 26 Aug 2026 13:18:18 -0400 Willem de Bruijn wrote:
> > +def check_dmesg_clean(func: str) -> bool:
> > + with subprocess.Popen(['dmesg'], stdout=subprocess.PIPE) as dmesg:
> > + res = subprocess.run(['grep', '-q', f'WARNING:.*{func}'], stdin=dmesg.stdout, check=False)
> > + return res.returncode != 0 and dmesg.returncode == 0
> > +
> > +
> > +@contextmanager
>
> Interesting approach. In ksft the built-in defer() mechanism may be
> preferred. Not sure.
+1 small preference towards defer() if Alice is willing.
It's be more idiomatic for our selftests
More importantly ruff check and pylink --disable=R have to be clean
for new tests. The test cases need a docstring explaining what they are
trying to test. The helpers can probably get a _ prefix to mark them
as private and silence the warning.
--
pw-bot: cr
next prev parent reply other threads:[~2026-08-27 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 20:02 [PATCH net v4 0/4] Fix UDP length overflow in edge cases Alice Mikityanska
2026-08-25 20:02 ` [PATCH net v4 1/4] net: ipv4: Fix UDP length overflow with PMTU discover and big MTU Alice Mikityanska
2026-08-25 20:02 ` [PATCH net v4 2/4] net: ipv6: " Alice Mikityanska
2026-08-25 20:02 ` [PATCH net v4 3/4] selftests: net: Test " Alice Mikityanska
2026-08-26 17:18 ` Willem de Bruijn
2026-08-27 19:28 ` Jakub Kicinski [this message]
2026-08-25 20:02 ` [PATCH net v4 4/4] net: ipv6: Clamp to IP6_MAX_MTU in ip6_dst_mtu_maybe_forward Alice Mikityanska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827122856.4b6eeb96@kernel.org \
--to=kuba@kernel.org \
--cc=alice.kernel@fastmail.im \
--cc=alice@isovalent.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox