From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, pabeni@redhat.com, horms@kernel.org,
idosch@nvidia.com, dsahern@kernel.org, netdev@vger.kernel.org,
eric.dumazet@gmail.com
Subject: Re: [PATCH net 3/5] ipv6: mcast: fix delay calculation in igmp6_join_group()
Date: Thu, 27 Aug 2026 13:08:19 -0700 [thread overview]
Message-ID: <20260827130819.293763e1@kernel.org> (raw)
In-Reply-To: <CANn89iJmape+9Nkf=U2vjydp89UPLvoyGh6wPusMFE_yLUoUeg@mail.gmail.com>
On Thu, 27 Aug 2026 22:02:27 +0200 Eric Dumazet wrote:
> > So for case 1, is the actual symptom that the randomized delay is lost and
> > the second unsolicited report goes out on the next tick, right behind the
> > first one, rather than a report deferred for weeks or months? The stated
> > symptom implies dropped membership reports and multicast traffic loss, which
> > reads differently for anyone triaging this for stable.
> >
> > Case 2 (a delay inherited from a query with a large maximum response delay
> > exceeding unsolicited_report_interval()) matches the code, and the clamp
> > added here covers both cases either way. Could the first paragraph be
> > reworded to describe the lost randomization and the reuse of the stale
> > expiry instead?
>
> OK I can rephrase the changelog to:
>
> 1. If the timer has already expired (timer.expires <= jiffies), the
> stale expiry is reused by mod_delayed_work(), causing the second
> unsolicited report to fire on the very next tick without a
> randomized delay.
>
> 2. If the timer was originally armed by a query with a large maximum
> response delay, delay could exceed unsolicited_report_interval(ma->idev).
>
>
> Hopefully, all the AI agents will be happy this time.
Feel free to ignore, I hit send because of the complaint on patch 2.
I may have misunderstood but I read that one as "delete requires
optmem headroom".
next prev parent reply other threads:[~2026-08-27 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 10:37 [PATCH net 0/5] ipv6: mcast: RCU and timer fixes Eric Dumazet
2026-08-26 10:37 ` [PATCH net 1/5] ipv6: mcast: fix RCU list diversion in ip6_mc_del1_src() Eric Dumazet
2026-08-26 10:37 ` [PATCH net 2/5] ipv6: mcast: use copy-on-write RCU updates in ip6_mc_source() Eric Dumazet
2026-08-27 19:42 ` Jakub Kicinski
2026-08-27 20:19 ` Eric Dumazet
2026-08-26 10:37 ` [PATCH net 3/5] ipv6: mcast: fix delay calculation in igmp6_join_group() Eric Dumazet
2026-08-27 19:42 ` Jakub Kicinski
2026-08-27 20:02 ` Eric Dumazet
2026-08-27 20:08 ` Jakub Kicinski [this message]
2026-08-26 10:37 ` [PATCH net 4/5] ipv6: mcast: use rcu_assign_pointer() for __rcu list updates Eric Dumazet
2026-08-26 10:37 ` [PATCH net 5/5] ipv6: mcast: use jiffies_delta_to_clock_t() in igmp6_mc_seq_show() Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827130819.293763e1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox