From: Longjun Tang <lange_tang@163.com>
To: mst@redhat.com, kuba@kernel.org
Cc: jasowangio@gmail.com, xuanzhuo@linux.alibaba.com,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
tanglongjun@kylinos.cn
Subject: [RFC PATCH 1/3] virtio: add virtqueue_get_last_used_idx() helper
Date: Fri, 28 Aug 2026 15:43:24 +0800 [thread overview]
Message-ID: <20260828074326.65594-2-lange_tang@163.com> (raw)
In-Reply-To: <20260828074326.65594-1-lange_tang@163.com>
From: Longjun Tang <tanglongjun@kylinos.cn>
Export a read-only accessor for the last consumed used ring index.
It's useful for drivers that need to detect whether the device has
produced buffers that have not been consumed yet, by passing the
returned value to virtqueue_poll().
The split ring now writes the field with WRITE_ONCE() (the packed
ring already did) to document that the new reader can run concurrently
with the poll path.
Assisted-by: Kilo:deepseek-v4-pro
Signed-off-by: Longjun Tang <tanglongjun@kylinos.cn>
---
drivers/virtio/virtio_ring.c | 23 +++++++++++++++++++++--
include/linux/virtio.h | 2 ++
2 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 5c169fbb418a..7b21fe573cde 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -1001,7 +1001,7 @@ static void *virtqueue_get_buf_ctx_split(struct vring_virtqueue *vq,
/* detach_buf_split clears data, so grab it now. */
ret = vq->split.desc_state[i].data;
detach_buf_split(vq, i, ctx);
- vq->last_used_idx++;
+ WRITE_ONCE(vq->last_used_idx, vq->last_used_idx + 1);
/* If we expect an interrupt for the next entry, tell host
* by writing event index and flush out the write before
* the read in the next get_buf call. */
@@ -1068,7 +1068,7 @@ static void *virtqueue_get_buf_ctx_split_in_order(struct vring_virtqueue *vq,
ret = vq->split.desc_state[last_used].data;
detach_buf_split_in_order(vq, last_used, ctx);
- vq->last_used_idx++;
+ WRITE_ONCE(vq->last_used_idx, vq->last_used_idx + 1);
vq->last_used += (vq->vq.num_free - num_free);
/* If we expect an interrupt for the next entry, tell host
* by writing event index and flush out the write before
@@ -3197,6 +3197,25 @@ bool virtqueue_poll(struct virtqueue *_vq, unsigned int last_used_idx)
}
EXPORT_SYMBOL_GPL(virtqueue_poll);
+/**
+ * virtqueue_get_last_used_idx - get the last consumed used ring index
+ * @_vq: the struct virtqueue we're talking about.
+ *
+ * Returns the index of the most recently consumed used buffer. It is
+ * mainly useful to detect whether the device has produced buffers that
+ * have not been consumed yet, by passing the returned value to
+ * virtqueue_poll().
+ *
+ * This does not need to be serialized.
+ */
+unsigned int virtqueue_get_last_used_idx(const struct virtqueue *_vq)
+{
+ const struct vring_virtqueue *vq = to_vvq(_vq);
+
+ return READ_ONCE(vq->last_used_idx);
+}
+EXPORT_SYMBOL_GPL(virtqueue_get_last_used_idx);
+
/**
* virtqueue_enable_cb - restart callbacks after disable_cb.
* @_vq: the struct virtqueue we're talking about.
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index f923e42cfd01..1aed4d9235c8 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -112,6 +112,8 @@ unsigned virtqueue_enable_cb_prepare(struct virtqueue *vq);
bool virtqueue_poll(struct virtqueue *vq, unsigned);
+unsigned int virtqueue_get_last_used_idx(const struct virtqueue *vq);
+
bool virtqueue_enable_cb_delayed(struct virtqueue *vq);
void *virtqueue_detach_unused_buf(struct virtqueue *vq);
--
2.43.0
next prev parent reply other threads:[~2026-08-28 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 7:43 [RFC PATCH 0/3] virtio_net: introduce an RX queue watchdog for stuck detection Longjun Tang
2026-08-28 7:43 ` Longjun Tang [this message]
2026-08-28 7:43 ` [RFC PATCH 2/3] " Longjun Tang
2026-08-28 7:43 ` [RFC PATCH 3/3] virtio_net: add rx_timeouts per-queue statistic Longjun Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828074326.65594-2-lange_tang@163.com \
--to=lange_tang@163.com \
--cc=jasowangio@gmail.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tanglongjun@kylinos.cn \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox