From: Birger Koblitz <mail@birger-koblitz.de>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Birger Koblitz <mail@birger-koblitz.de>,
Jianhui Xu <neuromoments@gmail.com>
Subject: [PATCH net-next v8 03/15] ax88179_178a: Fix endianness of pause watermark register
Date: Mon, 31 Aug 2026 11:58:52 +0200 [thread overview]
Message-ID: <20260831-ax88179a-v8-3-de905f2ee426@birger-koblitz.de> (raw)
In-Reply-To: <20260831-ax88179a-v8-0-de905f2ee426@birger-koblitz.de>
The 16-bit pause watermark register is little endian as
described in the ASIX 4.1.0 out-of-tree driver. Correct the
register byte sequence but also swap the configuration values
used in the code in order to keep the current behaviour.
The endianness is relevant for 16-bit writes to the register.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/usb/ax88179_178a.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 98f899ea2e9462f1ba99281a875385241745458b..945c071dfd1d2f0816c779e1a401ac158adc8d99 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -32,8 +32,8 @@
#define AX_ACCESS_EEPROM 0x04
#define AX_ACCESS_EFUS 0x05
#define AX_RELOAD_EEPROM_EFUSE 0x06
-#define AX_PAUSE_WATERLVL_HIGH 0x54
-#define AX_PAUSE_WATERLVL_LOW 0x55
+#define AX_PAUSE_WATERLVL_LOW 0x54
+#define AX_PAUSE_WATERLVL_HIGH 0x55
#define PHYSICAL_LINK_STATUS 0x02
#define AX_USB_SS 0x04
@@ -1617,11 +1617,10 @@ static int ax88179_reset(struct usbnet *dev)
dev->rx_urb_size = 1024 * 20;
*tmp = 0x34;
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp);
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, 1, 1, tmp);
*tmp = 0x52;
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH,
- 1, 1, tmp);
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp);
/* Enable checksum offload */
*tmp = AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
--
2.47.3
next prev parent reply other threads:[~2026-08-31 10:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 9:58 [PATCH net-next v8 00/15] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 01/15] phylink: Add phylink_mac_interrupt Birger Koblitz
2026-08-31 14:15 ` Andrew Lunn
2026-08-31 9:58 ` [PATCH net-next v8 02/15] phylib: Add support for PHYs with broken forced mode Birger Koblitz
2026-08-31 14:21 ` Andrew Lunn
2026-08-31 9:58 ` Birger Koblitz [this message]
2026-08-31 9:58 ` [PATCH net-next v8 04/15] ax88179_178a: Split driver into library and device specific code Birger Koblitz
2026-08-31 14:22 ` Andrew Lunn
2026-08-31 9:58 ` [PATCH net-next v8 05/15] ax88179_178a: Add netdev2data() convenience function Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 06/15] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-08-31 14:30 ` Andrew Lunn
2026-08-31 16:03 ` Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 07/15] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 08/15] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 09/15] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 10/15] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 11/15] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
2026-08-31 14:32 ` Andrew Lunn
2026-08-31 9:59 ` [PATCH net-next v8 12/15] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 13/15] ax88179_178a: Update driver name and information Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 14/15] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 15/15] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
2026-08-31 14:38 ` Andrew Lunn
2026-08-31 17:28 ` Birger Koblitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831-ax88179a-v8-3-de905f2ee426@birger-koblitz.de \
--to=mail@birger-koblitz.de \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=neuromoments@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox