From: Juuso Rinta <juuso.rinta@nokia.com>
To: Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Juuso Rinta <juuso.rinta@nokia.com>
Subject: [PATCH net-next] octeontx2: use dev_err_probe() for deferred probe
Date: Tue, 01 Sep 2026 08:17:36 +0300 [thread overview]
Message-ID: <20260901-octeontx2-dev-err-probe-v1-1-1b5e1affb994@nokia.com> (raw)
The PF and VF drivers warn and return -EPROBE_DEFER when the AF has
not programmed the RVUM revision or does not answer the mailbox READY
message. That is expected until rvu_af has finished initializing, so
the warning is repeated on every deferred retry.
Use dev_err_probe() instead of dev_warn() so the expected deferral is
not printed at warning level. -EPROBE_DEFER is logged at debug level
and the reason is recorded in devices_deferred.
Signed-off-by: Juuso Rinta <juuso.rinta@nokia.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 11 ++++-------
drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 5 ++---
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
index c995f2900..529040f3e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
@@ -1167,10 +1167,9 @@ int otx2_register_mbox_intr(struct otx2_nic *pf, bool probe_af)
}
err = otx2_sync_mbox_msg(&pf->mbox);
if (err) {
- dev_warn(pf->dev,
- "AF not responding to mailbox, deferring probe\n");
otx2_disable_mbox_intr(pf);
- return -EPROBE_DEFER;
+ return dev_err_probe(pf->dev, -EPROBE_DEFER,
+ "AF not responding to mailbox, deferring probe\n");
}
return 0;
@@ -2993,11 +2992,9 @@ int otx2_check_pf_usable(struct otx2_nic *nic)
* otherwise this driver probe should be deferred
* until AF driver comes up.
*/
- if (!rev) {
- dev_warn(nic->dev,
+ if (!rev)
+ return dev_err_probe(nic->dev, -EPROBE_DEFER,
"AF is not initialized, deferring probe\n");
- return -EPROBE_DEFER;
- }
return 0;
}
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
index fcdf891f9..a02267978 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
@@ -297,10 +297,9 @@ static int otx2vf_register_mbox_intr(struct otx2_nic *vf, bool probe_pf)
err = otx2_sync_mbox_msg(&vf->mbox);
if (err) {
- dev_warn(vf->dev,
- "AF not responding to mailbox, deferring probe\n");
otx2vf_disable_mbox_intr(vf);
- return -EPROBE_DEFER;
+ return dev_err_probe(vf->dev, -EPROBE_DEFER,
+ "AF not responding to mailbox, deferring probe\n");
}
return 0;
}
---
base-commit: 25c1f6111034aef7fc06cfbdcf1e4f0d6e5ee74b
change-id: 20260831-octeontx2-dev-err-probe-9ff7be8b5e6c
Best regards,
--
Juuso Rinta <juuso.rinta@nokia.com>
next reply other threads:[~2026-09-01 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 5:17 Juuso Rinta [this message]
2026-09-01 5:25 ` [PATCH net-next] octeontx2: use dev_err_probe() for deferred probe Ratheesh Kannoth
2026-09-03 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901-octeontx2-dev-err-probe-v1-1-1b5e1affb994@nokia.com \
--to=juuso.rinta@nokia.com \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox