From: Stephen Hemminger <stephen@networkplumber.org>
To: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] u32: fix IPv6 port match pretty printing
Date: Tue, 1 Sep 2026 08:58:01 -0700 [thread overview]
Message-ID: <20260901085801.61250518@phoenix.local> (raw)
In-Reply-To: <20260831104057.2176-1-prabhakar.pujeri@dell.com>
On Mon, 31 Aug 2026 10:40:57 +0000
Prabhakar Pujeri <prabhakar.pujeri@dell.com> wrote:
> parse_ip6() stores source and destination ports in the 32-bit key at
> offset 40. print_ipv6() checks offset 20 instead, so it does not print
> the decoded port fields. The source and destination labels in that case
> are also reversed relative to the layout produced by pack_key16().
>
> Handle offset 40 and use the source label for the high half and the
> destination label for the low half. This matches the parser and the
> equivalent IPv4 printer in both text and JSON output.
>
> Fixes: d13cee6d598d ("Add IPV6 match pretty print")
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
> tc/f_u32.c | 10 +++++-----
Used the new review-prompts for iproute and it saw incorrect placement
of print_nl() so I fixed that during merge
prev parent reply other threads:[~2026-09-01 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 10:40 [PATCH iproute2] u32: fix IPv6 port match pretty printing Prabhakar Pujeri
2026-09-01 15:58 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901085801.61250518@phoenix.local \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.pujeri@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox