From: Kalpan Jani <kalpan.jani@mpiricsoftware.com>
To: idosch@nvidia.com
Cc: AutonomousCodeSecurity@microsoft.com, davem@davemloft.net,
dsahern@kernel.org, edumazet@google.com, horms@kernel.org,
kuba@kernel.org, kys@microsoft.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, petrm@nvidia.com,
tgopinath@linux.microsoft.com, xmei5@asu.edu, janak@mpiric.us,
shardul.b@mpiricsoftware.com, kalpanjani009@gmail.com
Subject: Re: [PATCH net] nexthop: initialize extack in nh_res_bucket_migrate()
Date: Tue, 1 Sep 2026 15:18:27 +0530 [thread overview]
Message-ID: <20260901094827.1236039-1-kalpan.jani@mpiricsoftware.com> (raw)
In-Reply-To: <20260714104428.GA838500@shredder>
On Tue, Jul 14, 2026 at 01:44:28PM +0300, Ido Schimmel wrote:
> remove_nh_grp_entry() also doesn't initialize extack, but
> call_nexthop_notifiers() is using NL_SET_ERR_MSG(). Still, the same
> problem can happen if a listener is returning an error without setting
> extack. Please send a separate patch (targeted at net-next, no Fixes
> tag) to make remove_nh_grp_entry() consistent with
> nh_res_bucket_migrate().
Hi Ido,
Noticed this hasn't been picked up yet - happy to send that patch if
nobody else is already on it. Will target net-next, no Fixes tag, and
keep it consistent with your fix above.
Thanks,
Kalpan Jani
next prev parent reply other threads:[~2026-09-01 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 22:15 [PATCH net] nexthop: initialize extack in nh_res_bucket_migrate() Xiang Mei (Microsoft)
2026-07-14 10:44 ` Ido Schimmel
2026-09-01 9:48 ` Kalpan Jani [this message]
2026-09-03 7:40 ` Ido Schimmel
2026-07-21 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901094827.1236039-1-kalpan.jani@mpiricsoftware.com \
--to=kalpan.jani@mpiricsoftware.com \
--cc=AutonomousCodeSecurity@microsoft.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=janak@mpiric.us \
--cc=kalpanjani009@gmail.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shardul.b@mpiricsoftware.com \
--cc=tgopinath@linux.microsoft.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox