From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <joe@dama.to>
Cc: netdev@vger.kernel.org, Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
horms@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net] bnxt_en: Prevent queue stop with deferred completions
Date: Tue, 1 Sep 2026 16:48:14 -0700 [thread overview]
Message-ID: <20260901164814.00f446f1@kernel.org> (raw)
In-Reply-To: <20260827230233.94878-1-joe@dama.to>
On Thu, 27 Aug 2026 16:02:32 -0700 Joe Damato wrote:
> When the driver receives a burst of packets, it can mark a BD with the
> NO_CMPL bit to defer completions. The expectation is that the last
> packet in the ring will have this bit unset and the completion generated
> by that packet will cleanup that packet and the ones preceding it. This
> helps to reduce the number of completions fired.
AI points out that the DMA map etc. path does not obey the new
kick_prod that you're adding. TBH the checks you're adding look
quite messy. You should try to fix this by centralizing the kick /
flush logic at the end of bnxt_start_xmit() ?
Maybe bnxt_sw_udp_gso_xmit() should be returning int 1/0/-1 that
you can then interpret in the caller instead or some such.
--
pw-bot: cr
prev parent reply other threads:[~2026-09-01 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 23:02 [PATCH net] bnxt_en: Prevent queue stop with deferred completions Joe Damato
2026-08-28 3:21 ` Xuanqiang Luo
2026-08-28 14:57 ` Eric Dumazet
2026-08-29 9:27 ` Pavan Chebbi
2026-08-29 15:15 ` Joe Damato
2026-09-01 23:48 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901164814.00f446f1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox