From: Aleksei Sviridkin <f@lex.la>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "Chester A . Unal" <chester.a.unal@arinc9.com>,
Daniel Golle <daniel@makrotopia.org>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net v3 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support
Date: Tue, 1 Sep 2026 19:51:18 +0000 [thread overview]
Message-ID: <20260901195118.37238-1-f@lex.la> (raw)
In-Reply-To: <d0e8bd80-1798-4840-b388-05206bb72fc6@redhat.com>
> Clashiko complains about the above:
>
> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260827211652.63504-1-f%40lex.la
>
> @Andrew: WDYT?
The raw LPI_THRESH plumbing predates the phylink conversion: before
9cf21773f535, mt753x_set_mac_eee() wrote tx_lpi_timer straight into the
field with the same 0xFFF bound, so what ethtool showed and set on these
ports was always the register unit. This patch brings that path back and
does not change the unit. Settling it needs the MT7531 manual, and the
EINVAL-vs-clamp mismatch came with the conversion too. Both look like a
follow-up once someone can confirm the unit.
next prev parent reply other threads:[~2026-09-01 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 21:16 [PATCH net v3 0/2] net: restore EEE on MediaTek switches and SoC MACs Aleksei Sviridkin
2026-08-27 21:16 ` [PATCH net v3 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support Aleksei Sviridkin
2026-09-01 8:40 ` Paolo Abeni
2026-09-01 19:51 ` Aleksei Sviridkin [this message]
2026-08-27 21:16 ` [PATCH net v3 2/2] net: ethernet: mtk_eth_soc: " Aleksei Sviridkin
2026-09-01 8:32 ` Paolo Abeni
2026-09-01 19:51 ` Aleksei Sviridkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901195118.37238-1-f@lex.la \
--to=f@lex.la \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chester.a.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox