From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 411B040926C for ; Wed, 2 Sep 2026 09:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788339843; cv=none; b=ls8hYSk8durcmEPf+FK2+ZQkWiW2r0WxnN6do9XdfSdAv83NJrbMlpGApMwNbiqqVbsRLB8cIHV6eshziQe63FHHmtTJfEP3SNWzW87DnazPKV569+k7uyy1ZUv4BOKhg4jVlu+52ri8JRpQ8TAPCAOKlbD1VdZrbnhO/kwQJqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788339843; c=relaxed/simple; bh=nKIWorpbzaf5SIcpy9hDDeWjpM23McIxp03rHgi94W0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bXpSrykulxZUDzRQGmdYdFmy5kwQMwxP8PQiL1ZL3tepvJDtug57nLMotVUNJsl50/cr/n9ZymjEv8m5TVDx8tdoBNG46OKHOBXq6OxdkZrpIDKDskon5e2znKNVZsc7bIw1D6KTYUgQmLQPeaJqy98HY/vZTHK4cE8bdEO+F14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CBqIWlVU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CBqIWlVU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788339841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0eT/W/+oeHRW7p1OCHLSK34HdANZwDkci4//NsCv6s=; b=CBqIWlVUWKnwASp+fHBHumDI7wNGpZiAu5/HzKLaKXyQZz/A5kbjHj00XMcLUhCXu/lbVF FVhD8eCrZCGMdQfDZxkFH0wvJtkYf9qe7MSPc3TVuiEfmPWAYexyblQ4Wal07cyzJbgfmW 35jdVexlOjgtwS4vmf5wK+g++qcsAbQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-8WX91g-7MwCQqqgIQotzJQ-1; Wed, 02 Sept 2026 05:03:57 -0400 X-MC-Unique: 8WX91g-7MwCQqqgIQotzJQ-1 X-Mimecast-MFC-AGG-ID: 8WX91g-7MwCQqqgIQotzJQ_1788339836 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A659C1830197; Wed, 2 Sep 2026 09:03:55 +0000 (UTC) Received: from griffin (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 883361956044; Wed, 2 Sep 2026 09:03:51 +0000 (UTC) Date: Wed, 2 Sep 2026 11:03:47 +0200 From: Jiri Benc To: Fourie Zhang Cc: netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Simon Horman , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Aaron Conole , Ilya Maximets , dev@openvswitch.org, stable@vger.kernel.org, Fourie Zhang Subject: Re: [PATCH net] net: mpls: clear inner_protocol when the last label is popped Message-ID: <20260902110319.279de291@griffin> In-Reply-To: <20260902082924.2812968-1-fouriezhang@tencent.com> References: <20260902082924.2812968-1-fouriezhang@tencent.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Wed, 2 Sep 2026 16:28:08 +0800, Fourie Zhang wrote: > Fixes: c66549ffd666 ("openvswitch: correctly fragment packet with mpls headers") The problem was actually introduced by 48d2ab609b6bb ("net: mpls: Fixups for GSO"), which introduced the skb_set_inner_network_header and skb_set_inner_protocol in push_mpls but forgot to reset them in pop_mpls. Apart of that, the fix looks reasonable to me. This is fortunately a rather niche bug in practice (and to trigger intentionally, it requires CAP_NET_ADMIN). Please resend with the correct Fixes header. Thanks! Jiri