From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB5BA348C6E for ; Thu, 3 Sep 2026 16:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788452797; cv=none; b=RSPYj0EqA5Om/BUAYEJ3/RsLavXQ8FNO/wankhmv4wv1rQwpRUbUs4ORWzBsHx3b5rUUA5hs020NpNG4bQuX0Ot2XI0wN2gBhcYayUI7ZpkR2N2dSdNgiG37YLn8PJF1QNJ39nyxfMBsA1RmVP2vfLAjMb6vu1EPktcKnE708LA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788452797; c=relaxed/simple; bh=hg1/sQWRNTRJvXeK4q+etAM+USnHnJ7uuI3nEx7M6Uk=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=U3syiFLwsrIZTU4MdCn9bsxVgP+0f8pfd9GZ4JP9BPdepeZuoxeMyyryjz6PeMXJlzGzJpokmPtbM/NYK6qiZYyMWuJQPlzL1Hi/hen4pObNuOw1v8tG/0NsCT3qGL7s7KvD4Q64sIUW+N7NjrN+zMl4/xTbATeTXgypDuI33hk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r+LUSiJ/; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r+LUSiJ/" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-482e6163a9dso6988f8f.1 for ; Thu, 03 Sep 2026 09:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788452794; x=1789057594; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=qd5up/noPQGnqsemncaHSEHS7t/sLmdH6IitgfrFpdA=; b=r+LUSiJ/w3lIy7jHhH/lr7Cn1cGtEvjmAV5dp6+lm7z3GlMNa10/LcZXMgB6MmFBUJ Tntlg1D0DxNnETWnlPzLdnK+GJycGUK/vEQR3w3LwwHNUTCRPMJh1cBt+nx/004VDzJM Tary9HGStvUmcxmcMgCxd1K3K6RA/Z9JUH0fE6Jkle6+o/RqkjDi6Uth4cI/FXK3jbPk DLLVwoQNAdyN9NNvSSKzleI28Qe83PEtKTLQ+A+MZh7/UOFLZJWo6Kpe4QSaneWWPVqy kgGnaGGlzeemtKfEY1vtkTgMSHxaRNzcfza14mDSXCI+LM348psTMKy8Hdi4FLaeLJLJ gPRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788452794; x=1789057594; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=qd5up/noPQGnqsemncaHSEHS7t/sLmdH6IitgfrFpdA=; b=p7gLWJLBbnCyIKUZavIR0/vWnJVZstfntFie0O2PJNuXsBJYvamsMIVJFFWxZ3g5Kk Ka1QqCr8eAggixdXW6NAFceEjk0cK0f14IUE6kEkgnnA6Tr0yOBfkxNB3fnRZseF+v3U /DbEg2ZpJmWmQVir+TRbxroEs6xbwoK2lB85Yw1yYqXeLt0xnMMGSUIA1l3LHXHEJTcz 7HDCuCLOyzE1f5AA/XJWsG462W/X1X77Eh6rV40plMlO90ko7gNkLR2ZShAmPbp+w1/H ZVnCWHPFeLy5h2V+97flsjPukiDxoUgON+HYhS2DcoBBGnn70VKEzkz+6PVl0xqe3ZQQ zZsg== X-Forwarded-Encrypted: i=1; AKwUvBwI7O9PYrhNwxoc2U7wlsCRAPT/kgAu7AUG3aLe9AKoP9Y3LEQvWDv3XmKjnhcIiWHqxYKndVA=@vger.kernel.org X-Gm-Message-State: AFuF++mryeOY5H2+7dEiKL0wk2lxYY4Mp+O9ZCpzlkAFz3GS6rXQaMTK Cj2GuttL7Fjg6Zr3ovviiWa1QQijG+k80HvJ7y80ooL6AiXKS1IgbXQpixnA/TPi3GaMFQ== X-Gm-Gg: AYBFou2mlt3igftksdIs5h3zUPQ/6+pivcokiiDEaFqCxjidhSfJ20lPV6ogZhUAxc7 h/GhJClr8Kmryut4De+vN8kZpwKa0w0+2YoynDuuC7TZn+xYzyJQjPL1DJ3a+1l176ie3jdG9ao HCkHJAr5GUeQ+1UoktduudKO16Yo8E2jWhpb3DArG5MOgp7V8TSmTLNQJS7jcj/AI0O3/CikxYC XCJuA0p6K6CWdy1i3yCxOU7VhcOacq1fB0RamTiQ1+GPomcoggncaG0dsHryVFX0AjbYX9NOm6z Q5qmJdutFmYOen1klYrPkzkuNO0jSGRZ3lUcCtZxOyKlEw34V617rxkk6S64nrzilNHSlOLljHy qwN3NgJbKl5AIZayZNd8aDtziKL7sQdqxTkLVw/1ZDX3qp3BiWhQyrDICFMFQ8kKtdVR3ZbpZ1M hISy+BzjwCbCBydCEDRy71toIZlXWl1V2y9SQuK9nvKy+HTOpdAEg+5v25 X-Received: by 2002:a05:600c:530c:b0:499:cef6:104c with SMTP id 5b1f17b1804b1-49ce58369f4mr112994515e9.1.1788452793719; Thu, 03 Sep 2026 09:26:33 -0700 (PDT) Received: from localhost ([2620:10d:c092:500::6:124b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce592b019sm5052925e9.2.2026.09.03.09.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 09:26:32 -0700 (PDT) From: Gustavo Luiz Duarte Subject: [PATCH net-next v4 0/7] netconsole: validate a target's IP address configuration Date: Thu, 03 Sep 2026 17:25:59 +0100 Message-Id: <20260903-netcons_ipv6-v4-0-bdd183c844d3@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/13OSw6DIBQF0K00jEvDxyfSUffRNA0iKk39RCyxM e69SCfq8IV77mVGzgzWOHQ9zWgw3jrbteFIzieka9VWBtsi3IgRlhLBCW7NqLvWPW3vUwwpFAA lgGASBdIPprRTrLujkAzpaUSP/4v75C+jx7VtzdbWjd3wjcueRhFHMgL7EU8xwVQQxSGXrFD0V jXKvi+6a2K1ZxtMDz/0LGBeJKWWmVCSlEfMtzg5YB5wromkYDItYIeXZfkB/VdEez4BAAA= X-Change-ID: 20260730-netcons_ipv6-565d55f55729 To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan Cc: Gustavo Luiz Duarte , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org X-Mailer: b4 0.15.2 This series adds two validations to the target configuration when the user tries to enable it: first whether remote_ip was set, and second whether local_ip and remote_ip address families match. Refuse to enable the target if any of those validations fail. These validations are already done for the target passed on the command-line, so this aligns dynamic targets with the command-line behavior. The first two patches replace the per-target 'ipv6' flag with a per-address 'family' field, which makes it easier to detect these error conditions. Patches 3 and 4 implement the actual validations. Patches 5-7 are follow-ups from previous reviews: move inet_addr from netpoll.h into netconsole.c, show an unset address as an empty string rather than "0.0.0.0", document local_ip auto-selection. Signed-off-by: Gustavo Luiz Duarte --- Changes in v4: - No changes, just reposting post merge window close. - Link to v3: https://patch.msgid.link/20260814-netcons_ipv6-v3-0-bc0915e8c75f@gmail.com Changes in v3: - Document local_ip auto-selection - Link to v2: https://patch.msgid.link/20260810-netcons_ipv6-v2-0-3d4fc987a90f@gmail.com Changes in v2: - Show empty string in configfs for an unset IP address - Moved inet_addr definition from netpoll.h to netconsole.c - Moved address checks out of rtnl_lock() - Link to v1: https://patch.msgid.link/20260805-netcons_ipv6-v1-0-170a35b92da1@gmail.com To: Breno Leitao To: Andrew Lunn To: "David S. Miller" To: Eric Dumazet To: Jakub Kicinski To: Paolo Abeni To: Simon Horman To: Jonathan Corbet To: Shuah Khan Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org --- Gustavo Luiz Duarte (7): netconsole: add an address family to struct inet_addr netconsole: use the address family instead of the ipv6 flag netconsole: reject enabling a target with no remote IP address netconsole: reject a target mixing IPv4 and IPv6 addresses netconsole: show empty string for an unset IP address netconsole: move struct inet_addr into netconsole.c docs: netconsole: document local_ip auto-selection Documentation/networking/netconsole.rst | 5 ++ drivers/net/netconsole.c | 132 ++++++++++++++++---------------- include/linux/netpoll.h | 5 -- 3 files changed, 70 insertions(+), 72 deletions(-) --- base-commit: 7042c8c193e5d634198b7c766bb3a01c8e3ee0e2 change-id: 20260730-netcons_ipv6-565d55f55729 Best regards, -- Gustavo Luiz Duarte