From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93BA042EEC9 for ; Thu, 3 Sep 2026 07:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788420811; cv=none; b=a8ozvXap2O0gYL+YQLk+hegSSx26L8r1ujgZSn0HjMsqWKSKVBZi4dGnZ2yt1EPHHn14wiz91jAR/QuepXUgQ6lV/sZIv+/Z3stG4vT8AfUDhdycLrwCnVNxgZ8XyiMBX77YMMPr699QDnMc+8vrEJlHsusAPRvab7Rq8fm9cQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788420811; c=relaxed/simple; bh=SxCqMQ1VszqUJeekaQolW6aWNJXO7nxoW20LyVldySE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BCG+n20Mv1L4Cv8K39/qfDj1VJF3Zt2abBe/29YxhnHrnEfs2VsfN0gz5M5cwbCuZWkZzV2jRAe2QxBBn7hgw3XqC2pbnY6DIeYDadyYK61L2n/Dl5cjxpeEbcqaB/yrlIyExtPwjeBCkJJW2IGAUjNC63AVRYzReF8aNrxu3ck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gPHVM6eb; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gPHVM6eb" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so1796884a91.0 for ; Thu, 03 Sep 2026 00:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788420810; x=1789025610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vKLZ7u7XD6WW9l0yLksAVTtKwOMeF0VaxB2QRfd1xRs=; b=gPHVM6ebL2+6FZR/y16bLYbUirCgKk/Tb4VAJPZE8E+n7Pmg/KNS/Opn5P30k/nNDs vzNtdFmv/NVC2Ny2/uW/xXJq/U01KRWDt6/ZFu6ZoClR7hnkqnj5YHyjjCqu1DcFAH15 slr5z0pQLgbimmp8MZ7Dugu07+HiPftmU2N7zW3vGi3Hr20pa9h0OXIhbkXhmYeNAJmw oTBng2vTTTr49GTsaSnr1j1TLVG9LUSpVes62ufLBs00Jg4B4pIdHHm2pEuu83BgRH9j +uXexShkIaHgacu9Rcwc6fWB9OGBJ8OV/hAo3EM8dDeJpWMWHkLb5ROii5lW6yGfM9pV Qpsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788420810; x=1789025610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vKLZ7u7XD6WW9l0yLksAVTtKwOMeF0VaxB2QRfd1xRs=; b=C4DbazaiEs4sO7ZWzIinj4NQ6T04wpo9VErd+M7YHWL7SS9BpYen8adicjvJw0JcSa kl3qMOieWpv7YDpAOq+ZrFPylUqlhcA49N9EZ+pj9TKD8480D7s3PzjjZz0g2VH82/3z QbTRNA/crlocYCLPjZ7oBAnmfdgoiflWbyraHR5TqtyUP6ehGuNVIw3xM0Fttkn1JJZE TFyRtr1UoNHCk/+KW/QsjNnQ0rx3apKF/57fdaObFDUtnQ7v6uyToXJ9A833E4JeXdEv zuKeyo0FVrPImBd99giiGgT0LQKAP18qP01xUwf1eSUjaAqONi4/Xw+3aOtZqpObiTtl jO6Q== X-Forwarded-Encrypted: i=1; AKwUvByqHu/ERIC3wZid8sPE+4ekd/qdh2VnKQVYqFDDN5rH2fX70uN5tlMVWjybj8Bn/qyNwotejWg=@vger.kernel.org X-Gm-Message-State: AFuF++nr4oAGCKrITqFuse5p6XdZzmbF5dCswbu5rvFP3/tsirJBSL8d 0x3B4dhK5GldiFtj0wPZBmzBM0zZkyQJwF4fvB6BGnibwA3AkxGfzdjn X-Gm-Gg: AYBFou3n8951YkmUKHc/MPT5q2SYJ3HwVC9M0OGqsTRLoIHvnbXnqhQFXSnpGSuHJ41 Gsv4wOKJO3TIT+GS9RKBXzaM+wPFxeM7KS2MUm6zowKS/CfMTcvLRsrdtyNqdl7VQ8gd8TP8mE9 D+C+J9yJ+iF07Ym5Xj3yySXrqlAE64EmMieaL0Acyp338EOMq8YziAv2fLqcUHzHeuV3NGHwF9S tzOWq3VKvmPsyxL1dV8VOfnrIZDE2GbSGxk9+GEesfcC6a1dm/EY9AcRvQdDPBQHgZXRBxdcAU0 iVrIgVQEAVV6uOarR+hOvQli4+u/Ta5sO12NC9xBvtCW8SBJoG+H5Uw3FOYgP784mGsw0hPM5w3 whAXUdGjA9Qdwykry2khtkqwSBpR8oQ/rPW0RvzXo72gXdnxWQmgLytdcnwvuSv/zK11BOQA7m1 o8AujpAIBOSHkOKQsNhKTm91/JUEcynUpIFCC8ImqLz9oK5B4YYhiMVQrX6H6zXbaph+i1wEECZ oUvcTiBhnNw9IGkINISODrAPPlLeaGrDVJ8EBF6bgCKV9xaU8QednI6C2kf2eAKp8/RfcQDCWT5 EfQeEAruenEpeZpjBRFp4Uvl+xQ= X-Received: by 2002:a17:90b:5828:b0:38e:2e86:ed02 with SMTP id 98e67ed59e1d1-39aee0850bcmr16177711a91.14.1788420809671; Thu, 03 Sep 2026 00:33:29 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08624f11sm3606813a91.11.2026.09.03.00.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 00:33:29 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: Andre Przywara , Robert Hancock , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net-next v5 3/3] net: xilinx: axienet: Fix IRQ error handling Date: Thu, 3 Sep 2026 14:32:52 +0700 Message-ID: <20260903073252.339250-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903073252.339250-1-phucduc.bui@gmail.com> References: <20260903073252.339250-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails, while platform_get_irq() returns a negative error code on failure. Handle both failure cases appropriately: return -EINVAL when irq_of_parse_and_map() fails, and propagate the original error code returned by platform_get_irq() instead of returning -ENOMEM. Fixes: 28ef9ebdb64c ("net: axienet: make use of axistream-connected attribute optional") Signed-off-by: bui duc phuc --- Changes in v4 : - Add error handling for irq_of_parse_and_map() Changes in v5 : - Change the error code returned when irq_of_parse_and_map() fails from -ENOMEM to -EINVAL. drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 3927ababf833..782f903d318f 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2971,10 +2971,14 @@ static int axienet_probe(struct platform_device *pdev) dev_err(&pdev->dev, "could not map DMA regs\n"); return PTR_ERR(lp->dma_regs); } - if (lp->rx_irq <= 0 || lp->tx_irq <= 0) { + if (!lp->rx_irq || !lp->tx_irq) { dev_err(&pdev->dev, "could not determine irqs\n"); - return -ENOMEM; + return -EINVAL; } + if (lp->rx_irq < 0) + return lp->rx_irq; + if (lp->tx_irq < 0) + return lp->tx_irq; if (lp->eth_irq < 0 && lp->eth_irq != -ENXIO) return lp->eth_irq; -- 2.43.0