From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
Madhur Agrawal <madhur.agrawal@airoha.com>
Subject: Re: [PATCH net-next v5] net: airoha: add HW GRO offload support
Date: Thu, 3 Sep 2026 16:25:58 -0700 [thread overview]
Message-ID: <20260903162558.2679c1d1@kernel.org> (raw)
In-Reply-To: <apmWLtgcUXRrOTFj@lore-desk>
On Thu, 3 Sep 2026 17:45:50 +0200 Lorenzo Bianconi wrote:
> > Lacking more details from the vendor, I think you need to use a
> > pktdrill-like sender, explicitly sets the segment lengths to some not
> > mergeable (like, i.e. 200-300-400) but otherwise fitting a GRO packet
> > (i.e. same hdr except for the sequence number and push flag allowed only
> > in the last packet), ensure that the aggregation timeout lasts long
> > enough to receive all of them, and check if the engine really aggregates
> > them or not.
>
> I think in the example you pointed out (length 200,300,400) the hw engine will
> create a single TCP packet composed by 3 segments (with gso_size = 300) while
> sw GRO will just push sigle skbs. I agree this is just a GRO approximation.
> If it is not enough I am fine to switch back to LRO implementation.
FWIW the gro.py test covers that and many more cases..
prev parent reply other threads:[~2026-09-03 23:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 6:34 [PATCH net-next v5] net: airoha: add HW GRO offload support Lorenzo Bianconi
2026-09-03 0:36 ` [net-next,v5] " netdev-bot+sashiko
2026-09-03 6:13 ` Lorenzo Bianconi
2026-09-03 10:56 ` Simon Horman
2026-09-03 11:42 ` [PATCH net-next v5] " Paolo Abeni
2026-09-03 12:35 ` Lorenzo Bianconi
2026-09-03 13:46 ` Paolo Abeni
2026-09-03 15:45 ` Lorenzo Bianconi
2026-09-03 15:56 ` Paolo Abeni
2026-09-03 23:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903162558.2679c1d1@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=madhur.agrawal@airoha.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox