From: Petko Manolov <petkan@nucleusys.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Oliver Neukum <oneukum@suse.com>,
Marco Crivellari <marco.crivellari@suse.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 net-next 5/6] net: usb: pegasus: Move long delayed work on system_dfl_long_wq
Date: Fri, 4 Sep 2026 18:01:49 +0300 [thread overview]
Message-ID: <20260904150149.GA21082@carbon.k.g> (raw)
In-Reply-To: <b6cf44a1-d2b1-443d-8efe-c596ef89cc2a@rowland.harvard.edu>
On 26-08-28 10:10:01, Alan Stern wrote:
> On Fri, Aug 28, 2026 at 11:43:18AM +0200, Sebastian Andrzej Siewior wrote:
>
> > Therefore the suggested change system_long_wq -> system_dfl_long_wq should
> > not make a difference here: it is a different workqueue and it is unbound
> > (instead of per-CPU) but given the usage it is unchanged but more obvious.
> > Also its usage recommendations (use this for long running items) is the
> > same.
> >
> > The plan is remove system_long_wq from the tree.
>
> The point Oliver was making is that the driver shouldn't be using a
> general-purpose workqueue at all. Switching from one general-purpose
> workqueue to another ignores this point; it's not the right thing to do.
I read this as "this driver should switch to its own work queue", correct?
Petko
next prev parent reply other threads:[~2026-09-04 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 10:08 [PATCH v3 net-next 0/6] net: Move system_long_wq to system_dfl_long_wq Marco Crivellari
2026-07-20 10:08 ` [PATCH v3 net-next 1/6] ibmvnic: Move long delayed work on system_dfl_long_wq Marco Crivellari
2026-07-20 10:08 ` [PATCH v3 net-next 2/6] net: ti: icssg-stats: " Marco Crivellari
2026-07-20 10:08 ` [PATCH v3 net-next 3/6] net: ti: icssg-prueth: " Marco Crivellari
2026-07-20 10:08 ` [PATCH v3 net-next 4/6] net: thunderbolt: " Marco Crivellari
2026-07-20 10:08 ` [PATCH v3 net-next 5/6] net: usb: pegasus: " Marco Crivellari
2026-07-22 8:29 ` Oliver Neukum
2026-08-25 15:18 ` Sebastian Andrzej Siewior
2026-08-27 16:01 ` Alan Stern
2026-08-28 9:43 ` Sebastian Andrzej Siewior
2026-08-28 14:10 ` Alan Stern
2026-09-04 15:01 ` Petko Manolov [this message]
2026-07-20 10:08 ` [PATCH v3 net-next 6/6] net: usb: r8152: " Marco Crivellari
2026-07-20 22:35 ` [PATCH v3 net-next 0/6] net: Move system_long_wq to system_dfl_long_wq Jacob Keller
2026-07-21 8:20 ` Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904150149.GA21082@carbon.k.g \
--to=petkan@nucleusys.com \
--cc=andrew+netdev@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox