From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
vadim.fedorenko@linux.dev, arkadiusz.kubalewski@intel.com,
ivecera@redhat.com, jiri@resnulli.us, donald.hunter@gmail.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 1/4] netlink: specs: dpll: add clock-quality-level to the device-get reply
Date: Fri, 4 Sep 2026 12:10:20 -0700 [thread overview]
Message-ID: <20260904191023.3869690-2-kuba@kernel.org> (raw)
In-Reply-To: <20260904191023.3869690-1-kuba@kernel.org>
dpll_device_get_one() calls dpll_msg_add_clock_quality_level(), which
puts DPLL_A_CLOCK_QUALITY_LEVEL into every device-get reply, dump entry
and device-*-ntf of a device whose driver implements
clock_quality_level_get() - mlx5 does. The &dev-attrs anchor lists 12
attributes and not this one, so struct dpll_device_get_rsp has no field
for it, dpll_device_get_rsp_parse() drops it and dpll.rst does not
document it.
The attribute itself is correctly declared in the dpll attribute set,
only the reply list was missing an entry. Missing since commit
a1afb959add1 ("dpll: add clock quality level attribute and op").
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Documentation/netlink/specs/dpll.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
index cdc8c7b456df..64a45088c027 100644
--- a/Documentation/netlink/specs/dpll.yaml
+++ b/Documentation/netlink/specs/dpll.yaml
@@ -632,6 +632,7 @@ doc: DPLL subsystem.
- mode-supported
- lock-status
- lock-status-error
+ - clock-quality-level
- temp
- clock-id
- type
--
2.55.0
next prev parent reply other threads:[~2026-09-04 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 19:10 [PATCH net-next 0/4] dpll: fix lies in the Netlink spec Jakub Kicinski
2026-09-04 19:10 ` Jakub Kicinski [this message]
2026-09-05 11:19 ` [PATCH net-next 1/4] netlink: specs: dpll: add clock-quality-level to the device-get reply Vadim Fedorenko
2026-09-04 19:10 ` [PATCH net-next 2/4] netlink: specs: dpll: drop the pin-set attributes nothing implements Jakub Kicinski
2026-09-04 19:10 ` [PATCH net-next 3/4] netlink: specs: dpll: pin-get has no dump filter Jakub Kicinski
2026-09-04 19:10 ` [PATCH net-next 4/4] MAINTAINERS: dpll: add the netlink spec Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904191023.3869690-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox