From: Simon Horman <horms@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: Kees Cook <kees@kernel.org>,
linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-serial@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH] ecard: use module_driver() to avoid repeated boilerplate code
Date: Sun, 6 Sep 2026 11:16:19 +0100 [thread overview]
Message-ID: <20260906101619.GG40544@horms.kernel.org> (raw)
In-Reply-To: <20260906040153.105692-1-enelsonmoore@gmail.com>
On Sat, Sep 05, 2026 at 09:01:46PM -0700, Ethan Nelson-Moore wrote:
> Many Acorn expansion card drivers have module_init and module_exit
> functions that only call ecard_register_driver() and
> ecard_remove_driver(). The module_driver() macro automatically
> generates these functions given the register and unregister functions.
> Switch to it to simplify the code.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/ata/pata_icside.c | 13 +------------
> drivers/net/ethernet/i825xx/ether1.c | 13 +------------
> drivers/net/ethernet/seeq/ether3.c | 13 +------------
> drivers/scsi/arm/acornscsi.c | 13 +------------
> drivers/scsi/arm/arxescsi.c | 14 +-------------
> drivers/scsi/arm/cumana_1.c | 13 +------------
> drivers/scsi/arm/cumana_2.c | 13 +------------
> drivers/scsi/arm/eesox.c | 13 +------------
> drivers/scsi/arm/oak.c | 14 +-------------
> drivers/scsi/arm/powertec.c | 13 +------------
> drivers/tty/serial/8250/8250_acorn.c | 13 +------------
I think it would be best to split this patch up on a per-subsystem
of per driver basis. And send patches to appropriate subsystems.
In particular, please break out the net/ changes into a patchset
with one or two patches for net-next.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2026-09-06 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 4:01 [PATCH] ecard: use module_driver() to avoid repeated boilerplate code Ethan Nelson-Moore
2026-09-06 10:16 ` Simon Horman [this message]
2026-09-07 2:12 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906101619.GG40544@horms.kernel.org \
--to=horms@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andrew+netdev@lunn.ch \
--cc=cassel@kernel.org \
--cc=davem@davemloft.net \
--cc=dlemoal@kernel.org \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mkp@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox