From: Ido Schimmel <idosch@nvidia.com>
To: Ali Firas <alishmery18@gmail.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,
davem@davemloft.net, edumazet@google.com, andrew+netdev@lunn.ch
Subject: Re: [PATCH net v2] vxlan: vnifilter: validate the VNI range in vni_filter_entry_policy
Date: Mon, 7 Sep 2026 17:10:01 +0300 [thread overview]
Message-ID: <20260907141001.GA708129@shredder> (raw)
In-Reply-To: <20260907105223.3960496-1-alishmery18@gmail.com>
On Mon, Sep 07, 2026 at 01:52:23PM +0300, Ali Firas wrote:
> So I have the accounting patch ready, but I would rather not send it as
> if it closed the problem when it closes half of it. Would you prefer the
> accounting patch on its own with the rtnl stall described as a known
> remaining issue, or is the stall something you would want addressed
> first, in which case I would need guidance on whether a cap is
> acceptable at all?
Limiting the VNI range to 4k at a time is unlikely to break anyone given
that "vnifilter" is mainly used on bridged VXLAN devices where the VNI
is derived from the VLAN (max 4094).
There are no selftests for the range functionality, so as part of this
work please add some in test_vxlan_vnifiltering.sh. At the very least we
should make sure that the max range is accepted and 'max + 1' is
rejected (for both add and delete).
next prev parent reply other threads:[~2026-09-07 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 15:46 [PATCH net v2] vxlan: vnifilter: validate the VNI range in vni_filter_entry_policy Ali Firas
2026-09-05 19:36 ` netdev-bot+sashiko
2026-09-05 19:39 ` Jakub Kicinski
2026-09-06 23:16 ` Ali Firas
2026-09-07 10:52 ` Ali Firas
2026-09-07 14:10 ` Ido Schimmel [this message]
2026-09-09 9:26 ` [PATCH net 0/3] vxlan: vnifilter: bound the VNI range per request Ali Firas
2026-09-09 9:26 ` [PATCH net 1/3] vxlan: vnifilter: limit the VNI range of a single request Ali Firas
2026-09-10 9:38 ` netdev-bot+sashiko
2026-09-09 9:26 ` [PATCH net 2/3] vxlan: vnifilter: account VNI node and per-CPU stats to memcg Ali Firas
2026-09-10 9:38 ` netdev-bot+sashiko
2026-09-09 9:26 ` [PATCH net 3/3] selftests: net: test the vxlan vnifilter VNI range limit Ali Firas
2026-09-10 9:39 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907141001.GA708129@shredder \
--to=idosch@nvidia.com \
--cc=alishmery18@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox