From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30EFD548545 for ; Tue, 8 Sep 2026 14:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788879490; cv=none; b=AWEewRiqUXVa+8YTBkG9fhCjE3hW822oiO+QIUrSfoppWlqx611iQ/4G9c8266Ojop7m48oKlA6DOAoBT2Op9Z0HtBnLI2HIoto7Jh1YYmLzebUurZ6vfOOM+ckRrh2Ibu3k9m+OGAvxSgF0w+tA5K6G32o48wWtFkuLuzUu4Wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788879490; c=relaxed/simple; bh=jjMtp5SqAas4zIIzp6l5IEc/YbwGv5zChtMnC787rmU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cdpStZQPGX8Czs5zxJ/fY+6Fy2cF1pvVtu3YzgVFkB5H6JfdzQST2VBlv5XoIS5avIPAYF5xYHZwT9zmi0JHe/4f9Adx73zv40AQYvKLE6EIWqBp6lDX+qK/ceNCYFG41ECtKeEje183yNCFUbCirW9Q0291on8KyCsGQIgF6NE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kTCIk8j3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YP4Sb+Ld; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kTCIk8j3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YP4Sb+Ld" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688EjGT23627422 for ; Tue, 8 Sep 2026 14:57:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=kTCIk8j3aHSmnyqY 9b9gAQZQARWVR3bSRn/kfttx9qeVk826CqCyiJd6aRp1CZxK//jlGlUhPXPPIy2A aaiiqRq/66s/ABM+d/LJjRY5eyqbmvwns0JFx6u0RUhMxE45AFN06bhLhWzxo22M mVLWczys72gHIPS793OZ+o4ATDbtATe+mSW1aB5GcgP5QZ/QGXumCoLMAKcFau2F 2kf/ks5UlsmIbBiISLBy33wz8b80JHwLe9FtVYGxTshU9RX2DuSqaapuTmFcn2hf PYKZLnfB54w6+Z3ljGEg+wx0pThcjPftNaGb7B+emkgfjsIl3ToB5sYGMZowR8BU oL66XA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjcv7j7qp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 14:57:59 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93903622880so923538285a.0 for ; Tue, 08 Sep 2026 07:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788879479; x=1789484279; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=YP4Sb+LdFUXo6gzKB1Wg+l6/u13ncd0fSaakuFS/uM1DMDnpRpGaw/lU5zzrIJ5RlZ S46dePPNJCxgDDC7BIWCCN9M/gCbtD7P5tcgCw5XVGEXdMFyzR23JUiA3FaFG4ctUJ0w LBaFbogFfa+8gAheXCkLmnczs6M2A28ir/VlQ2gLpa3EeGteS2kM31YQGYQSRTQ4ofcc oEKLtLIClYCNHQM7okhZ2mOTczuWhY/SsxjQAmd3wk31NfIZSV/KZjAAg8wgXh8Ujgv1 q18EZa9Z3RhLpzO7DMLTzzijY0HX4Lmp7G+Cx5XDh+h0F62ssus3RT39Pgve3aRJ12Bs enlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788879479; x=1789484279; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=sZi29hnBb6Dq6+H8l2zNePpwbUeFU9rdXiUHtwwzLeT/Ea4686K8sNlwHPFfonP+dx xgFf1gbCzk2Spg7MYlz2+bAVO9Ax/MyiTPJqvQLtUC+/qRU1mIjFp59+6Y9TKQI4ZU93 E9V+Jvi9B6OFvS6QMAMgNGCrAidLVB+ASORR1yFCtjBWAnfYtCfyZdNv9USwOlMEA6OD SYYE0a/4XgXXhYozGBZdiFSIkPPBIZKJCQrkrWA//NB/ReM8bw98Oj/hni2lVhNwh4sx vVHMLgieKlvM3nt0DHDQ5bN1PmGJDLLhHvYbzUlYMN3xXbmoxf82/63RgXop9rHMOFeR 29CA== X-Forwarded-Encrypted: i=1; AKwUvBxqkvQrxsvIvyHT4dVIXbO5ozsWevDo6MprRGkPG5MCHovuk6zlPSHKNFJcGkjHy8vDCpZV220=@vger.kernel.org X-Gm-Message-State: AFuF++k+JCtMhrf6ONtEDc+8jRx51332lSdUx7x0Oszji5xs/nAVRROK hBoMRQv+UYcpQznE4FWHIE4p+Sc4dFEFqGcNvC7AMPPIm/XIdGVgOI/1PgzkZW/kodggAuziKCn QPGlEhno6lBzW8anRwgU0I37rhjq7NRCJo86oDrFVsz78i63hKceOchBMWnM= X-Gm-Gg: AYBFou0U3w8bcglwbxNG7ODux40MiBBDWKk6zS4cW90V4UZVlq8klLBAVQJCASPy9te 8JFAGC8w1R9nkWWeFFr1tjBWKoQVQtJzvJhM0ZnV8dawFrW2U6J2z0Y3eNGF6gHw4ODG6MR18Q0 EJqLTPoGBO/c4iVHhncBhDykOvfj6PcQ5McH6eSlwrXMDy7l48B3onx/eo5jrEvPJlTD0iFDWOO MxJB4htw7GDaKVbBMLzVzzQcdkCfhyZ1NpPxAKDVwN6mBcG4PSKlbaxBtDtn/rEwnskFF/xq8/F SlJTaO8u5ndPWYaakpUTCnyX1m3A1/hHwJnSLAeHaymWfBxVfYt31W8rf3YUy9eQk7FPPIhPG+q SFmmduaqkUPmQRpc6tFa9mM2p+Ucj X-Received: by 2002:a05:620a:1a20:b0:939:72cb:baee with SMTP id af79cd13be357-93972cbbc65mr2826567185a.37.1788879478663; Tue, 08 Sep 2026 07:57:58 -0700 (PDT) X-Received: by 2002:a05:620a:1a20:b0:939:72cb:baee with SMTP id af79cd13be357-93972cbbc65mr2826558885a.37.1788879478118; Tue, 08 Sep 2026 07:57:58 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:79a2:f118:df09:fe51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485958f1493sm25191276f8f.37.2026.09.08.07.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 07:57:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Sep 2026 16:57:20 +0200 Subject: [PATCH net-next v14 01/10] net: phy: aquantia: fix system interface type not updated in forced mode Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260908-qcom-sa8255p-emac-v14-1-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> In-Reply-To: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1751; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=jjMtp5SqAas4zIIzp6l5IEc/YbwGv5zChtMnC787rmU=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqoCJmPqi3DXcwZqfQ9RcuBKffaeQOMu23z59wG LbX6KLmIzSJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaqAiZgAKCRAFnS7L/zaE w1eOD/920zuLA7hi4Qy2IBRHuh66/6fGvU4CJZXZ8ZD4vI93p4NDs9EDRQ2eK5JZND/M39YL/eh 52J1KMNflNj2rwdO9wtNiwHM8YO6NzJZZlpUa7Ak0jx20M07KgXAKYNawKRHhswKAmt3gb8Sv0U 7R2lyCi5bWTavJEKJLgNvmjrfEnQWTW86v2Qe12MS6XLkR0c7km8NpFwNMTRxMnxHTDgYNFwP2/ lznNBSoSePeij/ML6f9oklu10rRg9FOzx+41xkEE2odLqbSjDCVGlgIOBX0oJQo+RXjakYifphY sGn+nbC+Y0cJXEFw+YPWaN4TO8N7EZjKgatj0E/AX5y5S0CGtri1J31C8NxIAlYMjV1buvk+m49 qfUC1djmfabNtSorBXWHn6eIotETAu7110pwW1SXS8sJEZqYSaM+UHB6N+CEshJFHnSrEVXaT/2 x3/y1w97VKXb0+Uev2Wg+1Y7ZmG8lYpdBpbSo4D/ZwbxN92vpw2leV1EfoEopMdH5pVNVUEWzby 50E9cOb6Xut9TWCp47vnDqWbHrGxpYV+SIhgiE8LQjji3khnrOkZ8Ew8fUysP7pgCSfo9+8xS5d APT5j7JXhq/tpsKe9Ow2mrNTveRI7gaS19Aug2BWjajK9kK4xY3fNdUsZfMg4w1pP1+U86iGb2u Hwcchsr19M05kMA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=CMEamxrD c=1 sm=1 tr=0 ts=6aa02277 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mooR1oPkU_hlknJbmfEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2MCBTYWx0ZWRfX70n5VFb2HADt KFmMnue/jndCvkWCJulKDsKD5mtN1boHOyJ+dSSUqc4GJEPloxlh13EUUPnI4F8QzZEGnUm4DWp //KmSDwDG6RL0r8+69UlPuITfMqIXbI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2MCBTYWx0ZWRfX/QBcNOoegAjZ Kbp1M2bNrqxjplxwmJphk/1VjHb3+BoNymxx2NCtXxeK5b63sNX8COwJIR/j06nItiBjeYfslo7 6sZwVER4VnxVWykIa/Sj/zAtRHtyDDU6VgYrbOISl8ylLlLVQQqH+fraxULM3aTlmUMaTytiojz hhn/pqOumbSa9o06E6KyGKutAu4rsJyOliV/+3nI+RcwRewnBAjwrWfluX5yFIn8CRDdZuTu/GJ QYtn9Mnef6UTosP1PSm0rskrsfD8MqL3p0EtNjLV4LEhTpPZwjpmuifowwgSY2ysdz3DE163omS t14CUOev1pw95bUSoxWSlMinAxNiAIbcu8Rhywh83ubLE4Z+tNNm4hmY2IVUujgNx7DIjm3wvW0 RbHpps7i6TB+/+bJDkYBzdVSPmX0wLUOA+Th4oyhsPEDQwFC3FofyTTkKrab8/5S0ctSmvUTCSu 58gVc8UcEOaupF15E5g== X-Proofpoint-ORIG-GUID: fzgLFVFnFI5v7e1o3AD8HD7E0Wdbq9Hp X-Proofpoint-GUID: fzgLFVFnFI5v7e1o3AD8HD7E0Wdbq9Hp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080160 aqr_gen1_read_status() decodes the MDIO_PHYXS_VEND_IF_STATUS register to determine which SerDes interface the PHY is currently using on its system side and stores the result in phydev->interface. phylink relies on this value to configure the MAC. The autoneg == AUTONEG_DISABLE check is not correct: MDIO_PHYXS_VEND_IF_STATUS is set by the PHY firmware based on the negotiated link speed, not based on whether autoneg was used to reach it. When the link comes up at 1G in forced mode, the register correctly reads SGMII, but the early return prevents phydev->interface from being updated. It stays at whatever value it held before (typically 2500BASE-X from the initial autoneg run), so phylink configures the MAC for the wrong interface and the link cannot come up. Remove the autoneg guard so that the system interface type is always decoded when the link is up. Cc: stable@vger.kernel.org Fixes: 110a2432c520 ("net: phy: aquantia: add downshift support") Signed-off-by: Bartosz Golaszewski --- drivers/net/phy/aquantia/aquantia_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index e95d391a6dc233879ae1fb2a97758b3df9600ce5..b720e4e9028cc20823297e8bbd239121aeafa09f 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -544,7 +544,7 @@ static int aqr_gen1_read_status(struct phy_device *phydev) if (ret) return ret; - if (!phydev->link || phydev->autoneg == AUTONEG_DISABLE) + if (!phydev->link) return 0; /* The status register is not immediately correct on line side link up. -- 2.47.3