From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D023B34389C for ; Wed, 9 Sep 2026 04:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929725; cv=none; b=Rs3Miu7FGbCvfHAdsR3LedOphM7WszWLYbs5+b/UMvwrkmfzobv3yuZtJaI3dnR6D13Jz4sHjHDQy+APlOO8bJJ8HSsu7VmLSEvgpEWf0hGzVcKaGnxvprrAa6Ufz78kROwI3z/fbkD7y6FZVpw9uhYQJCv8JivptVv2j8yr+ls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929725; c=relaxed/simple; bh=UFYz45aWYI+X83+iIz+CMEsv5bGyQep6UXbWxkDJvj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N5zENXJWwFPNRYloVjuR6NBYP7TtoaskEcUkqIx+iaTnln6ESCxlNCP/v5Z9eduzNJ0t6byaOJ2OAwd0g2FFJNUvks9OC8rgw2ghP+MuLPVlplWNpJFoOQY8Lgo9g5XW4J3e90NOto8S5Bo1a/vvV8MoFw3QgtDMW9A441FhmNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SsA0cbvm; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SsA0cbvm" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747f066d8so5893135ad.1 for ; Tue, 08 Sep 2026 21:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788929723; x=1789534523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A5IgLCU04RRBc+Gwx3mrSW66CKoAgwZR7YrSzPsHUdM=; b=SsA0cbvmcOWwQwxUs4Tenu1awhlG/r64x2O6BaCP5YFwQEkrlszmqlz+4vnIFG5SAj NLX+yTstl5JYmsifB0fSB4DbHdp+vaM788GgdJHQ5+QGZfIgFxlhFWTdNyXpvHF2kkJ1 PWYNGsbsmW8AtMe+jBd7LRyblovaofRvYT8iO5DnJCix8wP5uHnjlSFxYMzX+oLbcamm xHBJAgGXLRqQXxuzDkxBa4h5XR2PFy96pzbz04U15u7/3QjvrI2nQCNsX2oEEmdbd2/i XBZbM9MCUwMxRhbRdKzDXJdsZfplQ+FBXHldEqNKBYh2SnZxCd7EVuPedUOKcCQvFCfx Dzxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788929723; x=1789534523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=A5IgLCU04RRBc+Gwx3mrSW66CKoAgwZR7YrSzPsHUdM=; b=Yp+os66f+N4Os8oQlLLVv53iPCvdVcoDi/4JEyeE+O+fe5Ns0Tgt/KjO91ei9GrYme /vbusqKIIoqsnW14H4fjSefqYQFSSgyDCQBA9hsGr8t3w4SFS9QpGaDFlTe5dfttBvO9 bpDcHSnoKuD4iI5BP5D1qGHsufljhWS1M+r1jbhbE/kAw5KEUDAx0AyvdmDB/Q3aGHxM TMoIEtLLfk8uZ64WgxwR6uKT9VuxM3szH7ZT8mZPCPe431Sv5aUEaPmjdf0VhN5+U81E PzEVdEGEr05+lCDVsFxlpeMkDJ9qizak+OV+9R2UVk0HuoNcEXAsLOL3HHf2sdyK6OPV 9YOQ== X-Gm-Message-State: AFuF++kTKjqLorCLHlDEgqF/ogtunlMrvkfYuAzgTkMuURLoepkUrtJM CkM09h2QjO90idaF2hraw+BVHf2RuOqHbIXkkISeIOLD1tfsoBMp2k5R X-Gm-Gg: AYBFou0ySTmEkXbclH1w8Ct5HrYSsjNkBACqQqM03sIB32idFXCRjCaYPUWGRtYrUSE kpHetStqrFkPOlu+HhdaWzo7+P6K3jT9j3sEcbCQiiPfRYVdVcvikNos215+30z8KfGLMcJbgY9 8Kx/b9rOygtF9PwYK5ge5a2qJETU0oGp94grYvvZ5j49oerQfaylLGiEyzycpCVT/Mz7T6VuQDe 6LGGRhJRPkfpu0ky/L3Rrt1BIeW8LMA9Tsi9jBL9Prt9wFzB9xdTmJPLdGKlUISHySPDgd6yrJo RiRUS2X0j0ok0uUmnU7drsHYLJHGfahTqUJczLFm9x7oQD+EjwIUhpmcvcRzjmk1F7ndxCy/diZ DD0iEsl5T5U2ItZpa/tamBWk/6pn1kN5/MXBhyEMgVM1zGRjILaI/tjSnxQoJmNYKXSODmjjc4/ CRmT6Rc2udGve2WHPmML5VZfoYNbZFId4LOmohnCDkd36cjfG11+JFXaGxdYdm/DTLrpAZ+r+Hi nPRn284c+f/hoLIvNccofwZpEpLarNFj88cfcSz2CD0QWsks0xhrNrnQ1aRJcHCZzBcrLqsJl55 H6/sS947b0PZYe6wFaAyVxQo5g== X-Received: by 2002:a17:903:40d1:b0:2ca:12aa:a390 with SMTP id d9443c01a7336-2db6f91506dmr96058075ad.0.1788929723024; Tue, 08 Sep 2026 21:55:23 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2db1499e876sm66688505ad.56.2026.09.08.21.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 21:55:22 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net-next v6 3/3] net: xilinx: axienet: Fix IRQ error handling Date: Wed, 9 Sep 2026 11:54:50 +0700 Message-ID: <20260909045450.16176-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909045450.16176-1-phucduc.bui@gmail.com> References: <20260909045450.16176-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails, while platform_get_irq() returns a negative error code on failure. Handle both failure cases appropriately: return -EINVAL when irq_of_parse_and_map() fails, and propagate the original error code returned by platform_get_irq() instead of returning -ENOMEM. Reviewed-by: Simon Horman Signed-off-by: bui duc phuc --- Changes in v4 : - Add error handling for irq_of_parse_and_map() Changes in v5 : - Change the error code returned when irq_of_parse_and_map() fails from -ENOMEM to -EINVAL. Changes in v6 : - Add Simon's Reviewed-by: tag. - Drop the Fixes: tag as this patch is intended for net-next. drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 3927ababf833..782f903d318f 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2971,10 +2971,14 @@ static int axienet_probe(struct platform_device *pdev) dev_err(&pdev->dev, "could not map DMA regs\n"); return PTR_ERR(lp->dma_regs); } - if (lp->rx_irq <= 0 || lp->tx_irq <= 0) { + if (!lp->rx_irq || !lp->tx_irq) { dev_err(&pdev->dev, "could not determine irqs\n"); - return -ENOMEM; + return -EINVAL; } + if (lp->rx_irq < 0) + return lp->rx_irq; + if (lp->tx_irq < 0) + return lp->tx_irq; if (lp->eth_irq < 0 && lp->eth_irq != -ENXIO) return lp->eth_irq; -- 2.43.0