Netdev List
 help / color / mirror / Atom feed
From: Aleksei Sviridkin <f@lex.la>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Aleksei Sviridkin <f@lex.la>,
	andrew+netdev@lunn.ch, hkallweit1@gmail.com,
	linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	ericwouds@gmail.com, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next v2 0/7] net: mdio: an MDIO device driver for the Airoha EN8811H
Date: Thu, 10 Sep 2026 15:38:00 +0000	[thread overview]
Message-ID: <20260910153800.777902-1-f@lex.la> (raw)
In-Reply-To: <44f163ed-8362-4aad-99c9-f8709dfbed76@lunn.ch>

On Wed, Sep 09, 2026 at 09:01:14PM +0200, Andrew Lunn wrote:
> I think because you are sending this as RFC, the AI bots are ignoring
> it. I also think it is not getting build testing etc.

Next round goes without the tag. One bot did answer 7/7, but by private
mail only, so that side is not consistent either. The build testing is
what I want back.

> One way to argue it is that the MDIO bus it connected to the MCU. The
> MCU, once booted, forwards the MDIO bus through to the PHY part of the
> package.

That is the argument the binding was missing. It will say that, instead
of describing a driver model choice.

> Consider a normal setup, what happens when you remove the MDIO
> controller when the PHY is directly connected?  And look at what MDIO
> mux drivers do, which is not so different a use case.

It faults. On this board a bus going away under an attached PHY ends in
a NULL phydev->drv out of phy_stop(), directly connected or not.
mdio_mux_uninit_children() unregisters each child bus and frees it,
which is what this driver does. So nothing new to invent here; the hole
is in phylib.

> It is fine. I would also add a select or depends on the PHY driver
> Kconfig stanza to link it to the MDIO_AIROHA_EN8811H driver.

Will do.

> Prose is enough. And C code to catch DT authors who get it wrong. But
> you also need to be careful to not break backwards compatibility when
> the PHY driver is used alone.

The child bus will refuse an address that is not the parent's and name
the node that got it wrong. Boards that describe the chip as a plain PHY
keep working through the PHY driver as before.

> The location is fine. MAINTAINERS need to list it. What you might want
> to do is list it twice, once in the PHY driver MAINTAINERS record, and
> again in the MDIO driver section.

Both records then.

  reply	other threads:[~2026-09-10 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 15:57 [RFC PATCH net-next v2 0/7] net: mdio: an MDIO device driver for the Airoha EN8811H Aleksei Sviridkin
2026-09-08 15:57 ` [RFC PATCH net-next v2 1/7] dt-bindings: net: add Airoha EN8811H PHY MCU Aleksei Sviridkin
2026-09-08 15:57 ` [RFC PATCH net-next v2 2/7] net: phy: add mdiodev_lock(), mdiodev_lock_nested() and mdiodev_unlock() Aleksei Sviridkin
2026-09-08 15:57 ` [RFC PATCH net-next v2 3/7] net: phy: air: type the buckpbus core on the mdio device Aleksei Sviridkin
2026-09-08 15:57 ` [RFC PATCH net-next v2 4/7] net: phy: air: move the EN8811H firmware download into the library Aleksei Sviridkin
2026-09-08 15:57 ` [RFC PATCH net-next v2 5/7] net: phy: air: skip the download when the MD32 is already running Aleksei Sviridkin
2026-09-08 15:57 ` [RFC PATCH net-next v2 6/7] net: mdio: add Airoha EN8811H MDIO device driver Aleksei Sviridkin
2026-09-08 15:57 ` [RFC PATCH net-next v2 7/7] net: mdio: en8811h: add the nested bus Aleksei Sviridkin
2026-09-09 19:01 ` [RFC PATCH net-next v2 0/7] net: mdio: an MDIO device driver for the Airoha EN8811H Andrew Lunn
2026-09-10 15:38   ` Aleksei Sviridkin [this message]
2026-09-10 20:49   ` Aleksei Sviridkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910153800.777902-1-f@lex.la \
    --to=f@lex.la \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=ericwouds@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox