From: Jakub Kicinski <kuba@kernel.org>
To: Gabriel Windlin <gawindlin@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
nic_swsd@realtek.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: use str_enabled_disabled() helper
Date: Thu, 10 Sep 2026 18:44:43 -0700 [thread overview]
Message-ID: <20260910184443.08547606@kernel.org> (raw)
In-Reply-To: <20260908200309.533537-1-gawindlin@gmail.com>
On Tue, 8 Sep 2026 22:03:08 +0200 Gabriel Windlin wrote:
> Replace the open-coded ternary condition (? "enabled" : "disabled")
> with the str_enabled_disabled() helper from <linux/string_choices.h>
> to improve code readability and maintain uniform string representation.
It does not improve readability. Please don't send these sort of
patches to networking.
prev parent reply other threads:[~2026-09-11 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 20:03 [PATCH net-next] r8169: use str_enabled_disabled() helper Gabriel Windlin
2026-09-11 1:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910184443.08547606@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gawindlin@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox