Netdev List
 help / color / mirror / Atom feed
From: "Yilin Zhang" <yilinzhang@moonshot.ai>
To: "Jiayuan Chen" <jiayuan.chen@linux.dev>,
	 "Paolo Abeni" <pabeni@redhat.com>,
	 "Matthieu Baerts" <matttbe@kernel.org>
Cc: "Yilin Zhang" <yilinzhang@moonshot.ai>,
	 "Mat Martineau" <martineau@kernel.org>, <netdev@vger.kernel.org>,
	 <mptcp@lists.linux.dev>,
	"Kimi Security Team" <bug-report@moonshot.ai>
Subject: Re: [PATCH v2] tcp: fastopen: check rsk_drop_req() in tcp_fastopen_create_child()
Date: Fri, 11 Sep 2026 14:42:01 +0800	[thread overview]
Message-ID: <20260911064201.46922-1-yilinzhang@moonshot.ai> (raw)
In-Reply-To: <845b1b97-706f-42f8-b08c-90e863edef0a@linux.dev>

Hi Jiayuan, Paolo, Matt,

On 11/09/2026, Jiayuan Chen wrote:
> Should we accept this subflow ?
>
> It's just a SYN with MPJ + valid fastopen cookie, replying SYNACK
> and fallback to 3-way handshake may be easier.
> (I'm not sure whether RFC define it or not.)

This looks good to me. Falling back like this is also standard TFO
behavior (RFC 7413, sec. 4.2.2), so IIUC the RFCs don't object.

On 10/09/2026, Paolo Abeni wrote:
> If so mptcp should reject entirely MPJ + fastopen and no addtional
> code required on the TCP side.

With Jiayuan's SYN-flag check in subflow_syn_recv_sock(), we can do
exactly that: return NULL there, and tcp_conn_request() falls back to
the regular MP_JOIN handshake. No TCP-side changes needed.

> A minor process note: the changelog should come after the tag area
> and a '---' separator.

Noted, thanks for the reminder. I'll draft a v3 shortly along these
lines.

Thanks,
Yilin

  reply	other threads:[~2026-09-11  6:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  9:40 [PATCH v2] tcp: fastopen: check rsk_drop_req() in tcp_fastopen_create_child() Yilin Zhang
2026-09-10  8:12 ` Paolo Abeni
2026-09-10 10:13   ` Matthieu Baerts
2026-09-10 12:15     ` Jiayuan Chen
2026-09-10 16:12       ` Matthieu Baerts
2026-09-11  2:25         ` Jiayuan Chen
2026-09-11  6:42           ` Yilin Zhang [this message]
2026-09-11  9:33           ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911064201.46922-1-yilinzhang@moonshot.ai \
    --to=yilinzhang@moonshot.ai \
    --cc=bug-report@moonshot.ai \
    --cc=jiayuan.chen@linux.dev \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox