From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5A5D35F18B for ; Sat, 12 Sep 2026 05:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789192418; cv=none; b=nulhOxHD+VkhHzaF+Rx6snIaqzlEWHy5SKnO5bJu2QS+/k6nm6S/JjXvzBqSZXLs4h4aWQuyozRTQ8b/Hmeaa265axH3pO2G+8m8nYE1SZsE40H9OIkPKzYKh0GFdxBteF7RB5drZkW3qkYwqGtJvAmSJiB+wulzdImj5DkWXi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789192418; c=relaxed/simple; bh=ZA/mEuTnWP9Yf1QTb9eIl87hn0fA7R1TmKvlmFCboOM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o7QsIUHKuM0SekL6CRVzmXrVasP1f0bO/mw+fIQsSysgM9T8SFYyQ9I8ioMC9dqqpUYkhfe0pEQaiPQhXF+ei8sQkHlzU3K1LZggpqKSDXhrUC5ParFSDwJ5Iz++iz0b/zCke1nRxJ5WdKWFA8kZvdS+DmKeOBHAj4X33udjkhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R4V9UvQ2; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R4V9UvQ2" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747ed9865so5233505ad.1 for ; Fri, 11 Sep 2026 22:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789192416; x=1789797216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=iKMf2bIuJqFJMvFCCQVxdoeJj4bhaPI/BZkTzVZCVyg=; b=R4V9UvQ21y6VvdTW2hXR3k1sykbXxOnOb5/SOtyjsxFazeX9y+iqDuNDdzgtUrEdTi +dzLa92wsSUckXOxHcsR4OIqDjpCMQqmibvWGOrScYHzfG0hYYOFrl8gVqd50Gqj6y/e Uh+kWao057NhF/MgRftpVjBVUvbVMAAVDyw0EqVlh/0OVcurtjwJnwdXgG9FSFp1dFKb K871aiQKP2jyJI7MjA7vB55veFyXklaM9PxB0PgogNN+aywTtuNRLHVQAYVV4+Ko0vzr 7ph4WlP09zlG0qtu6qV5y3r7diTh7CC3njPD/GMPC81Vsqjl5qf2qrhZt8Lx1atsy5M9 R39w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789192416; x=1789797216; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iKMf2bIuJqFJMvFCCQVxdoeJj4bhaPI/BZkTzVZCVyg=; b=Xzz7lUoMFYJA5P4Su+3YVbzu/yeEa5xx+N29RR4uGQN0Ambvy8To3peVrZ/EWwyjx6 KzWMNBITPOf4PVeovRbMAyqhWfPR25cQYkDHo4VNPvTHtgmccamsY4pGmJDBlNOANbN2 u8DOwe/Ma+p3Hmi1Auy+oLLc+eWDAPF/0rLk+cDi8WK/mR9461fBLJBwVwmJrWHXrv9W XQlTgABJU3TEXwpSzdm4q9fhdusyxHRYJMXfyNrP4kB2VwgBrajZDQs5gch0ARhVEr1u h7UbMnV4cxGbzgjHkdaQEsBqeTAQejl/c4P3hbW7sCIz4+YObRqv0Ak6JQ5KTNi5IaQe a4eA== X-Forwarded-Encrypted: i=1; AKwUvBzLneG8l7vbLDuT/a4AY4J89CsSTbl4wJ7j6a/G9xWly4MpyvCqIgv7hIcrAOftN4CmXfhTKa0=@vger.kernel.org X-Gm-Message-State: AFuF++k9SQIff1cnzCvcZtJDDj/WbA6EqlFHGiMDDnuGTaa7C5DcYtiJ BrDZSame9IySbtx8GlJobelEI3syvRRRN2GyRTvPOwFMSI31hbtUvJ5h X-Gm-Gg: AYBFou13C5YZL0TuhlxtyIPUux9hVbS7a4vknzt/8kXXSz6R4DamFvXFo3sl800utoW GoDtY1dnr2GYU5Njh9ion4gn6tVZtiip0vk0d9ezrGJ+/sdDxJAN0T9chP33QkurApx1XAIYJ/X 8sO213lsCAR9oXSTIjybCOKyWq5e5jaV8csYrgCJ3obzY82FfoPj9syt1HrWM468Qj0I8FEM607 WO1KqmfbrhU7E5EQm5hdP6jvVnJXIR779/9d2bZdda9x85JkNzOv9BRIMA/2b168ezLOi2GmsXa 1CYUBZ1W9LEqZZ9lTBXDZClXXSaQTtq4IhtorZ9xNmmCvqLMXuTMxB3s/d9KEyinvM+1oBvRf3q t2gFGgF4UqJ8zckN4HgTLjCKzUVWFWKaFYxCmvCbOVWrVYpQQTZ6/kunccipgumcEcFCoBb1qRO 1Xes+CaqodYc7D1rX3KnsgW9OXaXVQr2DxlejQq8tvJTOlp4xdoPXCCLD3+bJK08NXUGX/hnA1x WsC347c1iwsFU9v1pNv6OOz+16pNl6wK37ztA== X-Received: by 2002:a17:903:1a88:b0:2d9:4358:73ab with SMTP id d9443c01a7336-2dd2a4580d0mr132179525ad.19.1789192416183; Fri, 11 Sep 2026 22:53:36 -0700 (PDT) Received: from Gris-Laptop (gia.grisge.info. [67.230.185.89]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4f55735sm11779694eec.24.2026.09.11.22.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 22:53:35 -0700 (PDT) From: Gris Ge To: David Ahern , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Cosmin Ratiu , Gal Pressman , Kees Cook , Tariq Toukan , netdev@vger.kernel.org (open list:NETWORKING [IPv4/IPv6]), linux-kernel@vger.kernel.org (open list) Cc: Gris Ge , stable@vger.kernel.org Subject: [PATCH] net: ip_tunnel: initialize `options_len` before referencing options Date: Sat, 12 Sep 2026 13:53:03 +0800 Message-ID: <20260912055304.1415016-1-cnfourt@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following command triggers a kernel panic: ip link add d0 type dummy; ip link set d0 up ip route add 10.30.0.0/16 \ encap ip id 300 geneve_opts 4660:66:11223344 dev d0 memcpy: detected buffer overflow: 4 byte write of buffer size 0 kernel BUG at lib/string_helpers.c:1044! ... ip_tun_parse_opts.part.0.cold+0x10/0x10 ip_tun_build_state+0x116/0x2a0 On kernels built with GCC 15+ and `CONFIG_FORTIFY_SOURCE`, the fortified `memcpy()` got 0 sized destination with request of 4 bytes length: static int ip_tun_parse_opts_geneve(...) { ... attr = tb[LWTUNNEL_IP_OPT_GENEVE_DATA]; data_len = nla_len(attr); /* == 4 */ struct geneve_opt *opt = ip_tunnel_info_opts(info) + opts_len; memcpy(opt->opt_data, nla_data(attr), data_len); /* ^^^^^^^^^^^^^ 0 since options_len is assigned afterwards */ Fixed by initializing the counter before the options are referenced matching what `ip_tunnel_info_opts_set()` already does Fixes: bb5e62f2d547 ("net: Add options as a flexible array to struct ip_tunnel_info") Cc: stable@vger.kernel.org Signed-off-by: Gris Ge --- net/ipv4/ip_tunnel_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index 5168d546ea2f..8fb4742aca92 100644 --- a/net/ipv4/ip_tunnel_core.c +++ b/net/ipv4/ip_tunnel_core.c @@ -711,6 +711,7 @@ static int ip_tun_build_state(struct net *net, struct nlattr *attr, new_state->type = LWTUNNEL_ENCAP_IP; tun_info = lwt_tun_info(new_state); + tun_info->options_len = opt_len; err = ip_tun_set_opts(tb[LWTUNNEL_IP_OPTS], tun_info, extack); if (err < 0) { @@ -753,7 +754,6 @@ static int ip_tun_build_state(struct net *net, struct nlattr *attr, } tun_info->mode = IP_TUNNEL_INFO_TX; - tun_info->options_len = opt_len; *ts = new_state; @@ -1005,6 +1005,7 @@ static int ip6_tun_build_state(struct net *net, struct nlattr *attr, new_state->type = LWTUNNEL_ENCAP_IP6; tun_info = lwt_tun_info(new_state); + tun_info->options_len = opt_len; err = ip_tun_set_opts(tb[LWTUNNEL_IP6_OPTS], tun_info, extack); if (err < 0) { @@ -1040,7 +1041,6 @@ static int ip6_tun_build_state(struct net *net, struct nlattr *attr, } tun_info->mode = IP_TUNNEL_INFO_TX | IP_TUNNEL_INFO_IPV6; - tun_info->options_len = opt_len; *ts = new_state; -- 2.55.0