From: Simon Horman <horms@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev-bot+sashiko@kernel.org, netdev@vger.kernel.org,
jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, vtlam@google.com,
stable@vger.kernel.org, victor@mojatatu.com, hybris@mojatatu.ai,
sashiko-bot@kernel.org
Subject: Re: [PATCH net 1/2] net/sched: hhf: cap hh_flows_limit at change time
Date: Mon, 14 Sep 2026 10:14:35 +0100 [thread overview]
Message-ID: <20260914091435.GN48209@horms.kernel.org> (raw)
In-Reply-To: <CAM0EoMkMCM92WBrt7v+2Ov2xSGGAqen-YTZj4irJzNcArrQjDA@mail.gmail.com>
On Sun, Sep 13, 2026 at 06:34:15AM -0400, Jamal Hadi Salim wrote:
> On Sat, Sep 12, 2026 at 4:36 PM <netdev-bot+sashiko@kernel.org> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue(s) to consider:
> >
> > Critical: 0 · High: 0 · Medium: 1 · Low: 0
> >
> > - [Medium] net/sched/sch_hhf.c: the new `[TCA_HHF_HH_FLOWS_LIMIT] =
> > NLA_POLICY_MAX(NLA_U32, 2 * HH_FLOWS_CNT)` policy entry (line 530) is…
> >
>
> These findings by sashiko-nipa are accurate but as in the previous
> codel thread they concern changelog and selftest-robustness nits.
> IOW, there is _no code defect_. The -ERANGE behavior change on add
> path and the changelog overstatement are worth a one-line fix if/when
> the thread is re-rev'd, but IMO are not a revision blocker
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-09-14 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 18:09 [PATCH net 1/2] net/sched: hhf: cap hh_flows_limit at change time Jamal Hadi Salim
2026-09-12 18:09 ` [PATCH net 2/2] selftests/tc-testing: add hhf hh_limit cap tests Jamal Hadi Salim
2026-09-12 20:36 ` netdev-bot+sashiko
2026-09-14 9:14 ` Simon Horman
2026-09-12 20:36 ` [PATCH net 1/2] net/sched: hhf: cap hh_flows_limit at change time netdev-bot+sashiko
2026-09-13 10:34 ` Jamal Hadi Salim
2026-09-14 9:14 ` Simon Horman [this message]
2026-09-15 13:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914091435.GN48209@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hybris@mojatatu.ai \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
--cc=victor@mojatatu.com \
--cc=vtlam@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox