From: Jakub Kicinski <kuba@kernel.org>
To: Quentin Armitage <quentin@armitage.org.uk>
Cc: David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org
Subject: Re: net: parsing IFLA_INET_CONF broken since 7.1 if NLA_F_NESTED not set
Date: Mon, 14 Sep 2026 10:21:08 -0700 [thread overview]
Message-ID: <20260914102108.788e700f@kernel.org> (raw)
In-Reply-To: <49f5ad9f2a4c1f2178f64383b4f05c21106fce7b.camel@armitage.org.uk>
On Mon, 14 Sep 2026 15:21:59 +0100 Quentin Armitage wrote:
> Commit fa8fca88714c - "ipv4: validate IPV4_DEVCONF attributes properly" changed
> inet_validate_link_af() to call nla_parse_nested() rather than
> nla_for_each_nested() for IFLA_INET_CONF. A side effect of this change is that
> the code now checks that NLA_F_NESTED is set for IFLA_INET_CONF, and rejects the
> message if it is not, whereas previously there was no check for NLA_F_NESTED
> being set.
>
> The consequence of this is that code which worked prior to Linux 7.1, albeit
> erroneously not setting NLA_F_NESTED now fails.
>
> In order to maintain backward compatibility, rather than calling
> nla_parse_nested(), nla_parse_nested_deprecated() should be called, as it is
> earlier in the function.
Please explain how you discovered the problem.
Is there some open source or closed source SW you're aware of which
breaks?
next prev parent reply other threads:[~2026-09-14 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 14:21 net: parsing IFLA_INET_CONF broken since 7.1 if NLA_F_NESTED not set Quentin Armitage
2026-09-14 15:27 ` Ido Schimmel
2026-09-14 15:42 ` Ido Schimmel
2026-09-14 17:21 ` Jakub Kicinski [this message]
2026-09-14 17:43 ` Ido Schimmel
2026-09-14 17:51 ` Jakub Kicinski
2026-09-14 17:52 ` Quentin Armitage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914102108.788e700f@kernel.org \
--to=kuba@kernel.org \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@armitage.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox