From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, jiri@resnulli.us,
tariqt@nvidia.com, moshe@nvidia.com, donald.hunter@gmail.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 6/9] netlink: specs: devlink: populate multi-attr attrs for region read and line card
Date: Tue, 15 Sep 2026 09:13:38 -0700 [thread overview]
Message-ID: <20260915161341.1053476-7-kuba@kernel.org> (raw)
In-Reply-To: <20260915161341.1053476-1-kuba@kernel.org>
Three attributes are emitted repeatedly inside their nest:
- devlink_nl_region_read_fill() calls
devlink_nl_cmd_region_read_chunk_fill() once per 256 byte unit
- devlink_nl_region_snapshots_id_put() emits one
DEVLINK_ATTR_REGION_SNAPSHOT sub-nest per entry on the region's
snapshot list
- devlink_nl_linecard_fill() emits one DEVLINK_ATTR_LINECARD_TYPE per
linecard->types_count entry
In all three cases we're missing the multi-attr properties, and the
attributes themselves are missing from the attr list used by C code gen.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v2: also update the attr list in the spec for region get
---
Documentation/netlink/specs/devlink.yaml | 28 ++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
index f23466fb27f9..5c9c672497d4 100644
--- a/Documentation/netlink/specs/devlink.yaml
+++ b/Documentation/netlink/specs/devlink.yaml
@@ -1264,6 +1264,7 @@ doc: Partial family for Devlink.
attributes:
-
name: region-snapshot
+ multi-attr: true
-
name: dl-region-snapshot
@@ -1278,6 +1279,7 @@ doc: Partial family for Devlink.
attributes:
-
name: region-chunk
+ multi-attr: true
-
name: dl-region-chunk
@@ -1360,6 +1362,7 @@ doc: Partial family for Devlink.
attributes:
-
name: linecard-type
+ multi-attr: true
-
name: dl-selftest-id
@@ -1971,7 +1974,7 @@ doc: Partial family for Devlink.
post: devlink-nl-post-doit
request:
value: 42
- attributes: ®ion-id-attrs
+ attributes:
- bus-name
- dev-name
- index
@@ -1979,7 +1982,15 @@ doc: Partial family for Devlink.
- region-name
reply: ®ion-get-reply
value: 42
- attributes: *region-id-attrs
+ attributes:
+ - bus-name
+ - dev-name
+ - index
+ - port-index
+ - region-name
+ - region-size
+ - region-max-snapshots
+ - region-snapshots
dump:
request:
attributes: *dev-id-attrs
@@ -2045,6 +2056,7 @@ doc: Partial family for Devlink.
- index
- port-index
- region-name
+ - region-chunks
-
name: port-param-get
@@ -2444,14 +2456,22 @@ doc: Partial family for Devlink.
post: devlink-nl-post-doit
request:
value: 78
- attributes: &linecard-id-attrs
+ attributes:
- bus-name
- dev-name
- index
- linecard-index
reply: &linecard-get-reply
value: 80
- attributes: *linecard-id-attrs
+ attributes:
+ - bus-name
+ - dev-name
+ - index
+ - linecard-index
+ - linecard-state
+ - linecard-type
+ - linecard-supported-types
+ - nested-devlink
dump:
request:
attributes: *dev-id-attrs
--
2.55.0
next prev parent reply other threads:[~2026-09-15 16:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 16:13 [PATCH net-next v2 0/9] devlink: netlink spec fixes Jakub Kicinski
2026-09-15 16:13 ` [PATCH net-next v2 1/9] devlink: fix the enum behind DEVLINK_ATTR_RELOAD_LIMITS Jakub Kicinski
2026-09-16 19:15 ` netdev-bot+sashiko
2026-09-18 1:19 ` Jakub Kicinski
2026-09-15 16:13 ` [PATCH net-next v2 2/9] netlink: specs: devlink: drop the stale port dump reply value Jakub Kicinski
2026-09-15 16:13 ` [PATCH net-next v2 3/9] netlink: specs: devlink: describe DEVLINK_ATTR_NESTED_DEVLINK Jakub Kicinski
2026-09-16 19:15 ` netdev-bot+sashiko
2026-09-18 1:21 ` Jakub Kicinski
2026-09-15 16:13 ` [PATCH net-next v2 4/9] netlink: specs: devlink: complete the port function nest Jakub Kicinski
2026-09-16 19:15 ` netdev-bot+sashiko
2026-09-15 16:13 ` [PATCH net-next v2 5/9] devlink: generate the port function policy from the spec Jakub Kicinski
2026-09-15 16:13 ` Jakub Kicinski [this message]
2026-09-16 19:15 ` [PATCH net-next v2 6/9] netlink: specs: devlink: populate multi-attr attrs for region read and line card netdev-bot+sashiko
2026-09-15 16:13 ` [PATCH net-next v2 7/9] netlink: specs: devlink: describe the netns id in the parent-dev nest Jakub Kicinski
2026-09-16 19:15 ` netdev-bot+sashiko
2026-09-18 1:23 ` Jakub Kicinski
2026-09-15 16:13 ` [PATCH net-next v2 8/9] netlink: specs: devlink: add pad to the subsets carrying padded u64s Jakub Kicinski
2026-09-16 19:15 ` netdev-bot+sashiko
2026-09-15 16:13 ` [PATCH net-next v2 9/9] devlink: validate the port index in the rate set request Jakub Kicinski
2026-09-16 19:15 ` netdev-bot+sashiko
2026-09-18 1:40 ` [PATCH net-next v2 0/9] devlink: netlink spec fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915161341.1053476-7-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox