From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f43.google.com (mail-pz2-f43.google.com [74.125.228.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6FDF270552 for ; Wed, 16 Sep 2026 02:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789524248; cv=none; b=EXGXleddH7FzA1HB8/wosTimJIjqAN0il9ZtGeBWR4pyV+oRSn/Uwyl8jIXJddm3zAkxzWqUtUzTCZW+cUcV2I4dIRGVFJYb6BqobsisJbjHofWWf4N4rSaErk87SBgcrp0nrf+OVyChdo3GM2JjPQEmyTq8pz1sBLQhp76GJAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789524248; c=relaxed/simple; bh=VYcIVUSYQLV4sjwuoeaRc5KM8Pt0LayXAdVTM+vIopM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PVrnXvVs//2dY90A1ADZf1Nw6xlLmFDhU3ZcSzovRS84CahXo0vXWN8nxfX+2WSJIqn5ITzSJOFta+2+o4aOg8f6tv/nDNn7jg3SWQlpvFVS0cSFSzelRbthZcqj8Yh3fFyelBkAKq7eD9Eft/6xah3RrH3tgqvvrut8Pb30UQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dju/W7Mf; arc=none smtp.client-ip=74.125.228.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dju/W7Mf" Received: by mail-pz2-f43.google.com with SMTP id d2e1a72fcca58-85a4329731cso262934b3a.3 for ; Tue, 15 Sep 2026 19:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789524237; x=1790129037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GY32qtKDHLqp705JJ4dXs20ZzYr5H1bBKfaTF23PTKo=; b=Dju/W7Mf62vk/L0wvQpBefMZzv8TJPaWkwY41Y0SYjiTKxxy6Yapehzh8+/y8sqWG8 OA8CgXwV1AyPokG+fr3xKR5UwjDGbpBQiHs/6EflRLtqGwZfZC3XOaX9DzDg7bx2ttjk h55wAjKixZn4si8w/AiRtV+gQjNjYI5ZUds0WszsFz5ZHmwlta2yuNpbt9Y88yGpfprv Ybq/qCUucgt9HnYo4I2ENvhNVN5QQClwGpHIm0mRgJLAQOB9VRgAsyR7DstHQ5hLcuRV XcbmLBQpkfPQ+Je6C7fYAzwma8oOumjjTq02EqvdZokI6UffpXmlke1ibT+C8QrnrPjb 1rMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789524237; x=1790129037; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GY32qtKDHLqp705JJ4dXs20ZzYr5H1bBKfaTF23PTKo=; b=KX60U+1CHO2qtg6V5mdTgkEXLij7GigDTLl2rrJ2P/vutenda2uvoq6xuYmxgJy2Z1 B1PJmqmu9IrNnh1SG16dOg2NbMZZVf4ba+7m5FPD/1oewCXBIciCyO/h9edFLEadcOZ7 ovyYtsiL4hJgP+jBkRnICY0DchZMmqR+ZB6OEWEJU+iMMWQ1gvZD090dVwpSJhJRPdsr HTQslp5BvUzeeTWWc5kGnXdDvTakk1eL7dzoGfl1fOnP0ZwMeJBhVkebj8csi3Crdtt0 gVAYOfs1Xvnht3s6Z5ntfllldPjqdcZiXxSei1c2s27wRAxpVY0FC2OWEKD6SjD0ckL2 LFjQ== X-Forwarded-Encrypted: i=1; AKwUvBy3Ayr+t5KxouvzxLf8LdlFBGKbtnOQqzOakPuAKlnI9soZHtez17fSMTvT17DZkMDCkNEA2W4=@vger.kernel.org X-Gm-Message-State: AFuF++mXrA2ICpMfNGQdhve1VkM43OfoptqZSaTeYeaUGoM6Y34o6fM+ 72p1tOpY6NPUoouERVGhXloiCFuKkXBOhWTGznBwyEqtvc+dxsr776kD X-Gm-Gg: AYBFou0PvfUki8acHkmFjCbEVc1zBe6JLbsElfvKC1POvGy1mfjmNOyRVuGOFlZaEQv RgYXGQ57JgZQICXa5J+6YufT1dr5ai7f07sYi69NX4v96Dal+hOQUpbRdk6gcz+xvmIxTnDeD9M QDHm90r4VPgefVeYpqS86JTZso1kyrH0jHvR+shxdlr0Trutlbrh3vyTZXgHdL30PLXWr7A1+KM BqcNmd/7j0PF8+ktbSsFjUIo+Rm7wB71KEaIQMQmeLa0EelaSDGGBZAzy9Jn0Y95rJSFJl2+4y/ 7/u2STMhvCX5rv5/Wdg7MK34CqCxYcs2asMDhHNWw7uADqwkvg5vTv+brhZ5rlQEzIDWmm1+VTH iKLq+Fx+wYvuxVIkE+mRKEw3bRi/1pK3uWgvaG3fqG7iZwwerNWE5aVepMaOuI+Lc2+rHQpaFQQ lkOOxw9fGncbIGoDbSQzqC27Ll1hX11qkV7A3OZFyRGbHch8fX2F94xg== X-Received: by 2002:a05:6a00:1a8c:b0:857:7317:cff5 with SMTP id d2e1a72fcca58-8723a4942bemr1132881b3a.22.1789524236922; Tue, 15 Sep 2026 19:03:56 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-872024e4369sm385031b3a.58.2026.09.15.19.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 19:03:56 -0700 (PDT) From: Guangshuo Li To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] net: dsa: mv88e6xxx: fix netdev reference leak on remove Date: Wed, 16 Sep 2026 10:03:40 +0800 Message-ID: <20260916020340.2580417-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mv88e6xxx_probe() uses the referenced network device provided through platform data, but the remove path does not drop the corresponding reference. The probe failure path correctly calls dev_put() for pdata->netdev. However, after a successful probe, mv88e6xxx_remove() tears down the switch resources without releasing this reference, leaving the network device reference count unbalanced after driver removal. Call dev_put() in mv88e6xxx_remove() after the switch resources have been torn down. This issue was found by manual code inspection. Fixes: 877b7cb0b6f2 ("net: dsa: mv88e6xxx: Add minimal platform_data support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 80b877c74513..e4394af2a3a2 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -7464,6 +7464,7 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev) static void mv88e6xxx_remove(struct mdio_device *mdiodev) { + struct dsa_mv88e6xxx_pdata *pdata = mdiodev->dev.platform_data; struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev); struct mv88e6xxx_chip *chip; @@ -7486,6 +7487,9 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev) mv88e6xxx_irq_poll_free(chip); mv88e6xxx_phy_destroy(chip); + + if (pdata) + dev_put(pdata->netdev); } static void mv88e6xxx_shutdown(struct mdio_device *mdiodev) -- 2.43.0