From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: [PATCH net-next 0/2] vlan: lockless vlan_fill_info()
Date: Wed, 16 Sep 2026 13:25:30 +0000 [thread overview]
Message-ID: <20260916132532.1785657-1-edumazet@google.com> (raw)
vlan_fill_info() currently relies on RTNL being held, because it
uses rcu_dereference_rtnl() to walk vlan->egress_priority_map[].
While auditing the fields exposed there, it appears that
vlan->flags, vlan->ingress_priority_map[] and vlan->nr_*_mappings
are written under RTNL but already read from lockless contexts
(RX, TX, /proc/net/vlan/<dev> and vlan_get_size()).
- Patch 1 adds the missing READ_ONCE()/WRITE_ONCE() annotations.
- Patch 2 converts vlan_fill_info() to RCU.
vlan->egress_priority_map[] needed no work: it is already updated
with rcu_assign_pointer() and freed with kfree_rcu().
This is part of a larger effort to remove the RTNL dependency from
rtnl_link_ops->fill_info().
Eric Dumazet (2):
vlan: annotate data-races in vlan_dev_priv fields
vlan: no longer rely on RTNL in vlan_fill_info()
net/8021q/vlan.h | 2 +-
net/8021q/vlan_core.c | 2 +-
net/8021q/vlan_dev.c | 37 ++++++++++++++++------------
net/8021q/vlan_netlink.c | 52 ++++++++++++++++++++++++----------------
net/8021q/vlanproc.c | 18 +++++++-------
5 files changed, 65 insertions(+), 46 deletions(-)
--
2.55.0.1032.g73a4cd73de-goog
next reply other threads:[~2026-09-16 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 13:25 Eric Dumazet [this message]
2026-09-16 13:25 ` [PATCH net-next 1/2] vlan: annotate data-races in vlan_dev_priv fields Eric Dumazet
2026-09-16 13:25 ` [PATCH net-next 2/2] vlan: no longer rely on RTNL in vlan_fill_info() Eric Dumazet
2026-09-19 0:10 ` [PATCH net-next 0/2] vlan: lockless vlan_fill_info() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916132532.1785657-1-edumazet@google.com \
--to=edumazet@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox