From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arthur Crepin Leblond <arthur@marmottus.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v8 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt
Date: Thu, 17 Sep 2026 12:04:12 +0200 [thread overview]
Message-ID: <20260917-sexy-quixotic-ermine-138eab@quoll> (raw)
In-Reply-To: <20260915-wiznet-link-gpio-v8-2-d173622474cc@marmottus.net>
On Tue, Sep 15, 2026 at 10:06:03AM +0200, Arthur Crepin Leblond wrote:
> Add an optional link status interrupt which can be connected to the
> LINKLED pin on the device to detect link status changes. This second
> interrupt is only supported on wiznet,w5500.
>
> Signed-off-by: Arthur Crepin Leblond <arthur@marmottus.net>
> ---
> v8:
> - Remove Krzysztof Kozlowski reviewed-by tag after Sashiko review
> changes
> - Make the interrupts property conditional
>
> v7:
> - No changes
>
> v6:
> - Fix DT error: use minItems
> - Remove conditional properties
>
> v5:
> - Make the DT interrupts property dynamic from the compatible one
> - Fix DT bindings errors
>
> v4:
> - Update interrupts in DT bindings
>
> v3:
> - Fix DT binding errors
>
> v2:
> - Convert device tree binding to YAML
> ---
> .../devicetree/bindings/net/wiznet,w5100.yaml | 38 ++++++++++++++++++----
> 1 file changed, 31 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> index 25098308eb6e..da03f4e07f29 100644
> --- a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> @@ -12,10 +12,6 @@ maintainers:
> description: |
> This is a standalone 10/100 MBit Ethernet controller with SPI interface.
>
> -allOf:
> - - $ref: /schemas/net/ethernet-controller.yaml#
> - - $ref: /schemas/spi/spi-peripheral-props.yaml#
> -
> properties:
> compatible:
> enum:
> @@ -24,8 +20,11 @@ properties:
> - wiznet,w5500
>
> interrupts:
> - maxItems: 1
Broadest constraints always stay here.
I already asked for proper syntax here:
https://lore.kernel.org/all/688f57cd-a098-4904-b8cd-965470a89386@kernel.org/
https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L127
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-17 10:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 8:06 [PATCH net-next v8 0/3] w5100: restore GPIO-based link detection Arthur Crepin Leblond
2026-09-15 8:06 ` [PATCH net-next v8 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema Arthur Crepin Leblond
2026-09-17 20:08 ` netdev-bot+sashiko
2026-09-18 7:03 ` Arthur Crepin Leblond
2026-09-15 8:06 ` [PATCH net-next v8 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt Arthur Crepin Leblond
2026-09-17 10:04 ` Krzysztof Kozlowski [this message]
2026-09-17 12:02 ` Arthur Crepin Leblond
2026-09-17 20:08 ` netdev-bot+sashiko
2026-09-18 7:17 ` Arthur Crepin Leblond
2026-09-15 8:06 ` [PATCH net-next v8 3/3] w5100: detect carrier state using link status bit and optional interrupt Arthur Crepin Leblond
2026-09-17 20:08 ` netdev-bot+sashiko
2026-09-18 12:18 ` Arthur Crepin Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917-sexy-quixotic-ermine-138eab@quoll \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arthur@marmottus.net \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox