From: Wentao Liang <vulab@iscas.ac.cn>
To: andrew+netdev@lunn.ch
Cc: davem@davemloft.net, edumazet@google.com, enachman@marvell.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
maksym.glubokiy@plvision.eu, netdev@vger.kernel.org,
pabeni@redhat.com, Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] net: prestera: flower: fix ruleset leak in prestera_flower_prio_get()
Date: Thu, 17 Sep 2026 11:16:03 +0000 [thread overview]
Message-ID: <20260917111603.2148710-1-vulab@iscas.ac.cn> (raw)
prestera_acl_ruleset_lookup() returns the ruleset with its reference
count incremented, and the caller is expected to release it with
prestera_acl_ruleset_put(). prestera_flower_prio_get() only reads the
priority range and returns without dropping the reference, so the
ruleset is never destroyed.
Release the reference after the priorities have been read.
Fixes: 44af95718fed5 ("net: prestera: manage matchall and flower priorities")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/net/ethernet/marvell/prestera/prestera_flower.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_flower.c b/drivers/net/ethernet/marvell/prestera/prestera_flower.c
index 58b116cabd48..10d7e149822b 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_flower.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_flower.c
@@ -411,6 +411,8 @@ int prestera_flower_prio_get(struct prestera_flow_block *block, u32 chain_index,
return PTR_ERR(ruleset);
prestera_acl_ruleset_prio_get(ruleset, prio_min, prio_max);
+ prestera_acl_ruleset_put(ruleset);
+
return 0;
}
--
2.34.1
next reply other threads:[~2026-09-17 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 11:16 Wentao Liang [this message]
2026-09-17 12:18 ` [EXTERNAL] [PATCH] net: prestera: flower: fix ruleset leak in prestera_flower_prio_get() Elad Nachman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917111603.2148710-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enachman@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maksym.glubokiy@plvision.eu \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox