From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f43.google.com (mail-pz2-f43.google.com [74.125.228.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF8104E2F19 for ; Thu, 17 Sep 2026 14:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789656254; cv=none; b=Mp6MmKuaWp04GhsvYXSPMQL6x9Bz8Zqe8ZyjWYA8m6xBC2OuClyiRSF1CJpR5QFNSC/KDtg7+VfDX1Ior3GUOfSplzPHjPIgKJnRikgDNGtY4jNZ7aovI1fwKXH/6p1E33xC/cz4rmWRenz3IbO0x4qH8oTIfs82EIJTwz63FaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789656254; c=relaxed/simple; bh=i5l/MrnI1ypNlMLTJuU1qsyK6FRr4dvCYiWju6B2/aE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AeBtcDdTsdyWrV9LRx5OV3PXMpDFGSuptAmjdCPe9TNIm6EE5U295M+FiH5cW14dCAbXo5lhbt0Xa3sbZNLrCYgX9kQdxgJ3PqKgUHaU2giZBGQjp7cNg3rMPY+WQkQQtn5OPepRTIYtzFWYYb9SWv5OPbe04mFmqIxiCI39wcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jWOAwDv/; arc=none smtp.client-ip=74.125.228.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jWOAwDv/" Received: by mail-pz2-f43.google.com with SMTP id d2e1a72fcca58-85469d249c5so789679b3a.3 for ; Thu, 17 Sep 2026 07:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789656244; x=1790261044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HrDk21UY7OLFOZBR0vjrLvOMR24vY5+kMD8RCheOxbI=; b=jWOAwDv/Hjr6X5bZ7RbUqeKZEFRO+ZX+YD1qSlBXwdlAsJR1EChB0ukhhyFl2xnJwn tgbbLivGIbRtdgyMNW9AIqxumYNr6JggYkqdsRjg6RajW+yNpoVIS3yPke7dGAOBlw2w lmre0gBXcbyueZHte1ZFyjYFJVg7/rJQXL/dN0qErZuhYQoUXCCsltEQktiC4wO+ZtTO ZPsoxzZ1SYeM1XjyaTM29Rd7MixQSHEZzsdx2F7u0HIYTGl0i4/b1wFTmmWZJCvt9+h3 nW6tA4fz7q/6WGUvr6wQ5qzvbtQnX9FWwqhDgjA+hg1f3h+x2vGzjYXRADgyFJwhfcrj 8gBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789656244; x=1790261044; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HrDk21UY7OLFOZBR0vjrLvOMR24vY5+kMD8RCheOxbI=; b=HC3gzAQzPF+e2ls8VmqD+fjnOo6kDF5rDFqd7WvsWnb7IshCZxViLdP5fTYZhwuozf +sulGT6Dvoc1CcxdjeOoJId99ZyVau+bi9q2xQAs+DTDo2QHk/HXBO3TElVmhBVnQ3Rm wNJte4oQPZiBG+bCE0BesnkrPQCIhsT2/oSkCvV+CPFtP1ckS5wk8K1wkYLcgsUKdBcg PMfF3yOMHvth8zyBFqC1uVemcD4nZpaDn+3CO5ZOctEqam84lp81mcN07kj8xqykEIOo UTEkFrQLS8faPYrudRcQ6pM2+C3E3WYVIMopnNJXke/4AP1SXvost2mu2Z5AKGYHpMHf Vpcg== X-Forwarded-Encrypted: i=1; AKwUvByefpLaf7K8SMV45F6QoXdiB5mm2IZQLNoIFH5IYYZRjcFamNrrtCOgSUyFQoJ6/6aae95ZjqA=@vger.kernel.org X-Gm-Message-State: AFuF++kqXNGxAJT25d0ufay9fjePWs4hPsPZksmMCzPhBgnowkdV1aoP D3Sk7fpizfic05mDqxNF1SxE/rJW7neRWRxIQCq+aMlbUK3J660wlNC6 X-Gm-Gg: AYBFou24Eowrd5zgfR/QjK+nxA4kq8hyUesaASlxygW7YaPRGWhxyo6cJButgQbmEjm JrQ7GA/QlzaitU4ROZ1Y8FNhuFKsbH9yzJjNxfbUdw9afOanDIVAYdl+ib4ZA8XIyl+wrK0Q4Bm b/R56dUNbnMxx41qTP1K8hxolUN90D2d1/XgNSL9EtenDl6HxSFdlXPMeoRmFbxvIIuaGVdd2+/ TyCyQb17igl8aaUKJFhik97O0+UGNCmZoAXCWvewAmca5coIb7wfaGGZibhj60v3fDvThApyyr+ HcoJoCPMSisTqPihXpo9Xt5KufGImvacU3l2StkMUzhWNOv9ADX5X/bNEqacWz0okSLBK8XXy49 rUAD+zpXa4kbGcsTrJ0QioUhO6qbx25GzGGatFiP6/HPsk/OlcuzrJDodjDonXUEU6h+TD1tA90 ffNUgUCX2rbg7jNsLPeM+tWpBnnVa2rMy6sPjWExI0le98ozCL4n+Lv9HlrTFOE7wEuhUHnspVJ RV2LQ1K6+Mh0CEBYCsS0oSoy1M/CAYwQCd5M1XMJg== X-Received: by 2002:a05:6a00:1887:b0:85f:1492:61a8 with SMTP id d2e1a72fcca58-87236fd6341mr14621831b3a.7.1789656243473; Thu, 17 Sep 2026 07:44:03 -0700 (PDT) Received: from localhost.localdomain (59-127-145-64.hinet-ip.hinet.net. [59.127.145.64]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-87201d1b275sm2962034b3a.51.2026.09.17.07.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 07:44:03 -0700 (PDT) From: Zhi-Jun You To: Felix Fietkau , Lorenzo Bianconi Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sujuan Chen , Rex.Lu@mediatek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Zhi-Jun You Subject: [PATCH net v4 1/3] net: ethernet: mtk_wed: skip ring reset in wdma_tx_ring_setup for WED v3 Date: Thu, 17 Sep 2026 22:43:33 +0800 Message-ID: <20260917144335.19466-1-hujy652@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently WED v3 tx wdma ring, ring reset happens in a separate code block unconditionally. Moreover, v3 has double the size of wdma_desc and has different init values. mtk_wed_ring_reset doens't deal with that and would corrupt the wdma_desc. Fix this by skipping mtk_wed_ring_reset in mtk_wdma_tx_ring_setup for WED v3. Fixes: e2f64db13aa1 ("net: ethernet: mtk_wed: introduce WED support for MT7988") Signed-off-by: Zhi-Jun You --- Changes in v4: - no change - Link to v3: https://lore.kernel.org/all/20260724172040.1653-1-hujy652@gmail.com/ Changes in v3: - new patch addressing WED v3 ring reset issue raised by Sashiko - Link to the review: https://lore.kernel.org/netdev/20260630144831.1109-1-hujy652@gmail.com/ --- drivers/net/ethernet/mediatek/mtk_wed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c index 53d3b7e00e1c..d55042ccaff1 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -1938,7 +1938,7 @@ mtk_wed_wdma_tx_ring_setup(struct mtk_wed_device *dev, int idx, int size, wdma_w32(dev, MTK_WDMA_RING_TX(idx) + MTK_WED_RING_OFS_CPU_IDX, 0); wdma_w32(dev, MTK_WDMA_RING_TX(idx) + MTK_WED_RING_OFS_DMA_IDX, 0); - if (reset) + if (!mtk_wed_is_v3_or_greater(dev->hw) && reset) mtk_wed_ring_reset(wdma, MTK_WED_WDMA_RING_SIZE, true); if (!idx) { -- 2.47.3