From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Victor Nogueira <victor@mojatatu.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
jiri@resnulli.us, horms@kernel.org, vega@nebusec.ai,
netdev@vger.kernel.org, Yuan Tan <yuantan098@gmail.com>
Subject: Re: [PATCH net] net/sched: Avoid quadratic handle scan in qdisc_alloc_handle
Date: Thu, 17 Sep 2026 17:46:31 -0700 [thread overview]
Message-ID: <20260917174631.66cee526@kernel.org> (raw)
In-Reply-To: <CAM0EoMn1SkkC0goKD3-OreQtEwYbfr3zYJdmfrDf8HTdHWrNjg@mail.gmail.com>
On Thu, 17 Sep 2026 07:24:05 -0400 Jamal Hadi Salim wrote:
> On Wed, Sep 16, 2026 at 8:04 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > > Given the flood, here are the priority rules we are using:
> > > 1) submit net before net-next
> > > 2) All bugs must be reproducible by our (semi-automated) system
> > > (hybris). I dont even look at issues unless they are reproducible
> > > (hence my nagging "do you have a PoC?" ;->)
> > > 3) Assign a priority to each bug and submit the highest priority ones
> > > first. The priorities are assigned as follows:
> > > - base (reproduced, ACCURATE) +1
> > > - Crash (oops/panic/NULL-deref/OOM/corruption) +2
> > > - UAF +2
> > > - Lockup (soft lockup/livelock/infinite loop) +1
> > > - leak +1
> > > - simple-trigger (plain tc/tdc, no special PoC) +1
> > > - privilege required: (root) +1 / (unshare -Urn) +2
> >
> > nice system :)
> > no distinction between control path-trigger an packet trigger?
>
> At the moment we dont make a distinction - the existing point system
> would still work, I think. Do you see it differently?
Right, a bit of a murky call. In abstract packet trigger could mean
remote attacker can crash a middlebox, that's _so_ much more serious.
But in practice most of our packet level attacks are for some insanely
pre-cooked skbs from AF_PACKET and such :/
It was just a thought.
prev parent reply other threads:[~2026-09-18 0:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 13:31 [PATCH net] net/sched: Avoid quadratic handle scan in qdisc_alloc_handle Victor Nogueira
2026-09-14 8:22 ` Simon Horman
2026-09-15 2:11 ` Jakub Kicinski
2026-09-15 11:50 ` Jamal Hadi Salim
2026-09-15 12:28 ` Eric Dumazet
2026-09-15 14:01 ` Jamal Hadi Salim
2026-09-15 15:53 ` Jakub Kicinski
2026-09-16 10:34 ` Jamal Hadi Salim
2026-09-17 0:04 ` Jakub Kicinski
2026-09-17 11:24 ` Jamal Hadi Salim
2026-09-18 0:46 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917174631.66cee526@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vega@nebusec.ai \
--cc=victor@mojatatu.com \
--cc=yuantan098@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox