From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6DF43C8719 for ; Thu, 17 Sep 2026 22:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789682524; cv=none; b=FqJTaFhWYEQUeACgB4Dq7YJdWcY3P0AwYGeC8oueKEWEk1VOgV/sbtXBNFfJsx2OMzOGi5QktVpliWZmWVQMyvHiWKY44e+fiKGd64fyn9nGFv9d/ofDbcQspybJhT5xWy04Lx2r65twurw3cEc4Et5OXg89aGYO1PG9IUf5fpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789682524; c=relaxed/simple; bh=QVy/c3lL0T2G0QS0X5UQ0e+4FGDESG9uqf0mPCrckvo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=o27OM5D6WW4kE8/sO6LSSeuk8JhWgegHnSVfxMKZp4iDPOdmaMZLzEVMk+GA5+z89mE/7SoJ6/eWF9Y0dlcGdG7fwetppaSY00dhKryblz4dLHNgJI7RtGuCvQM2nQvToU8dHwfFd7mmdjKO581PmpWuFrB0FcD0XCQkYyYl6JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=isec.pl; spf=pass smtp.mailfrom=isec.pl; dkim=pass (2048-bit key) header.d=isec.pl header.i=@isec.pl header.b=Y6/eCdhz; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=isec.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isec.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=isec.pl header.i=@isec.pl header.b="Y6/eCdhz" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b965f447cso864695e9.3 for ; Thu, 17 Sep 2026 15:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isec.pl; s=google; t=1789682521; x=1790287321; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BSXvhhtGESzI8UKfdlYrqnmXXZ2KSc85lByA5Tdkzb4=; b=Y6/eCdhzByIEr8UL7XE/BqM8RugkBpEfFydGDrY1jNK3+STmAaxSJ6qtlMqa34E65q 0Cu3+7PQ/c4ci9HVsdxfvScqdZQ5svLUuKvguTpvrB4Re9xZx2ZJcg4k/gJjM1HUO9qE P+8RvGvdX4r17LbqhS4dZlZmM5eNl50xoX6gN6fKJIj+/lnpwwtypcEIMMwlcwPsChWZ 3uSuyh6MJGPS32SL8xv14VJyXucWMs928Z4C9gnqTJZjwbiL3axQ1wnZbG2BNfdzpAVy R5LYeMrtx+LC1gSd1ldruQU+t2vNABVcmYf/I09r7ihr1uSG1+sTD8sJNi2HMcSt0eP8 czUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789682521; x=1790287321; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BSXvhhtGESzI8UKfdlYrqnmXXZ2KSc85lByA5Tdkzb4=; b=FH8wVvdtGR/APBGQw9UWZLvvqxS0PT3pzRFSzJF+zWzezCP/+K4vES5ExWL2H2kIk+ dF0N6pSXxVrR/zChoVYhqMSvu+CAHL6i8gCGKY0ILaM+hQIYs16jbIWO14RpHXtXMXZ5 vgx8v58VoNn0fVP1avbZn/S1sBURLOIHYfYz3A/ItNfgd2lfRSqH0hvW9ck36yNfnsru 1uYxeKhMmDozzG5nsflxA4WzEDbhsnMEH3lWNtInm8swYLCha6V8dQw2maJagTH1I0ja cvMwvNu0RPza9oyEGr/zYV+c+bGawY5S1JqgswMzppkn9awrObgTCBJ7bheutuhKHuFq TMFw== X-Forwarded-Encrypted: i=1; AKwUvBxIEGySO9k4X+U+Wx2PTFEnjXnrB7gqvJatHs5QumiJDQBfFOYB3P9fSIR4s6PjKRIs6f3xBiw=@vger.kernel.org X-Gm-Message-State: AFuF++k0k7Y9rAagMNgcdbaRI19nhE7dibK6eoN1ZMmnd3tlcRitG3Li ACUDveLAdC3QFcsdZNUcfKDIfU9k4VoFksvdPFTVAC7F1guYy7gOO5G9vGhaypPD+yk= X-Gm-Gg: AYBFou3DidWsBHkCZmrPe87vhzixVdV52/Je/KtknJAn6X9VyuIhjgtRTuEJpEYxkSa y11hAJRg1YAJr5cujcr6EJYD1nGPflbH14tRFyrJHpFl2XtYV8kJovkkTY0SGsu3ISqL3FaEByX nfe8XRae3jePEsI9z4SvhmguVGGwNfFRRb+dl5dRTRF73lDFSmmaiOG1MxQW0ONOF7LU6Z4faS5 aab8LvJlIA4LWW/1SXw2FIF7rhbdY2UT0GmgjacsenHlly7A3OGN9Al5YJ6uRrAfVdtFvUpz+lp 4TSzsnmfCO+OdWm6+RkmPDKLqIF2VpDvvJHJLuLEh1CoRM7xbPT6/luDca8XaqZIszRF48QUDqO at2rw0ykj5VnrqKgJb/M8ROxQJRvqOSspLUfCzURVhYYdZ0sSGo/fDDYUOLhJ8qDttVBfhpGy/T Ju6cz7Paxv04y6VH1qVlYV5TOfmBZtrlnLTitOtyQ3pws38jonTrBM/yGu95elkgc7Z59E98iIM ckyzKwFYQmfv6b7UukSfmJIlfKqgcAFWkJnZa1rdFLBc9E= X-Received: by 2002:a05:600c:c48e:b0:49c:dcec:bd27 with SMTP id 5b1f17b1804b1-49fc5687122mr2528885e9.8.1789682520862; Thu, 17 Sep 2026 15:02:00 -0700 (PDT) Received: from localhost.localdomain ([2a02:a318:80b3:9080:744c:a1ba:d233:283a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4870bf344fcsm19794436f8f.26.2026.09.17.15.01.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 17 Sep 2026 15:02:00 -0700 (PDT) From: =?UTF-8?q?Bart=C5=82omiej=20Dmitruk?= To: Dexuan Cui , Wei Liu , Haiyang Zhang , "K . Y . Srinivasan" Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, Stefano Garzarella , "Michael S . Tsirkin" Subject: [PATCH] vsock/hv_sock: reject incoming connections when the listener is being released Date: Fri, 18 Sep 2026 00:01:54 +0200 Message-ID: <20260917220156.56015-1-bartlomiej.dmitruk@isec.pl> X-Mailer: git-send-email 2.46.2 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hvs_open_connection() only checks sk_state == TCP_LISTEN and sk_acceptq_is_full() before creating a child and calling vsock_enqueue_accept(). __vsock_release() sets sk->sk_shutdown = SHUTDOWN_MASK and flushes the accept queue while leaving sk_state == TCP_LISTEN, so a host channel offer that races close() of the listener passes both checks and enqueues a child onto the already-flushed queue. That child socket (and the VMBUS channel opened for it) is never accepted or cleaned up and leaks. The virtio transport guards exactly this case in virtio_transport_recv_listen(); hv_sock lacks the equivalent guard. hv_sock holds lock_sock(sk) across hvs_open_connection(), so the check is race-free. Signed-off-by: Bartłomiej Dmitruk --- diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c --- a/net/vmw_vsock/hyperv_transport.c +++ b/net/vmw_vsock/hyperv_transport.c @@ -324,6 +324,14 @@ if (conn_from_host) { if (sk_acceptq_is_full(sk)) + goto out; + + /* __vsock_release() may have already flushed the accept queue + * and set sk_shutdown = SHUTDOWN_MASK while leaving sk_state == + * TCP_LISTEN. Enqueuing a child now would leak the child socket + * and its VMBUS channel. Mirror virtio_transport_recv_listen(). + */ + if (sk->sk_shutdown == SHUTDOWN_MASK) goto out; new = vsock_create_connected(sk);