From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F33773E40E3 for ; Fri, 18 Sep 2026 03:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700529; cv=none; b=Wu1zyP1BJMxotG8hTT0WSGztKjnI1uFJaDHFgruZJ0PwjiAe599Yd0vdRk/fk3a19ZDoHPCu+2Mokmd0F55nQUQcymZdRF7nOYzcJdspmujZ1RhSw7FvYitPhommBS2B220KwGLcfPGs5CosoEIfGgb+x3iYyQe5i5EI0smuCzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789700529; c=relaxed/simple; bh=5AdYSZFlM9mpA/HI3S7NB0TkV6f4XovkiyBzqzde/oY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LMW5ckDmm5///Z8QqB01fL8tGtLdIiXAAUai27IPVh0v4FjY7ihx+ZOOo+o7FeUR1DnbNAyXphI6VpztQ1i2IxmhbAOQULjUyXUpRCn5JJWBVn4mSA+h5SDTBgYTc6yt3iAlX5D6+YiFvrUrf4AsSYRAiEirpboPovt/pXNSb1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jclark.com; spf=pass smtp.mailfrom=jclark.com; dkim=pass (2048-bit key) header.d=jclark-com.20251104.gappssmtp.com header.i=@jclark-com.20251104.gappssmtp.com header.b=E/SOupZA; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jclark.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jclark.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jclark-com.20251104.gappssmtp.com header.i=@jclark-com.20251104.gappssmtp.com header.b="E/SOupZA" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccb65437so215693a91.3 for ; Thu, 17 Sep 2026 20:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jclark-com.20251104.gappssmtp.com; s=20251104; t=1789700520; x=1790305320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=V6X1MKF9iM/+JNuGTPcTXOfmgyWPwSTXzdW5BB/5bwY=; b=E/SOupZAQPei8zbJZP2BcCPFdlKjOj8FI9vbUjsCCnHwSzcfPN3QnEiXM/5Yrhzsaw 1iR/ZmjPqzf02BVEQ59+jy25xZK0MoIAkfkgLzlifgEOV/2RVLGsAPRAda53rQ4Ag4xX ZAPzjfgP6yi7Jy3FKsgqTtQnOwd0iMPon0q40SARiIZKOZG1r3jMak/TCdkUvLisGBkN QWbsthF3mqb1MJCqjhd3NPcPa1541ftXsU/XJNQ0k0yLgtMojlWZVWL+lTHlUwWSet6t 4P5NTnaOabgK5TciYUfdj9gQsbo1UMme+v4hNeLRnJjhkNHcxzZboIrMMU+eeTPO7W2s RC3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789700520; x=1790305320; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V6X1MKF9iM/+JNuGTPcTXOfmgyWPwSTXzdW5BB/5bwY=; b=y0ewpC1i+OAe1L3HFv176+o3ZTQx0/KqgvAmioDScCc3y/nUaD/jL+xAIOiU1PsQy1 KTsViLRs7M9/akFRNiu9Y2jQ0etB6XKtYaHcxt/2Hifen9jNa1u5oDjVTvEaN0P0vgo+ aPloI4Bxz2i9XfMj5y74OzXBrGt2fK/0MDt25e7x4r//wgCAtor7lMRup95Iq17USbVp BICRXH4zI22hgsfDJIJsMq84iuiCpmmWaZ1JidEfBMr+3xPpMlt5E5XHon2arO7qn2Zg GIG40cioX6O168tpcRu3NqtVATSSAUP3OODzpiSmJ5lwrg/Y6jBtwmKsQ1Jco4E9qAkU 9qHw== X-Forwarded-Encrypted: i=1; AKwUvBwXybh2lfchBCbxa6SchHsOypwEd0w+E20KQECquBcXlKRCAjz9YdVrBCdsB+D9JWqzGhmaJ1I=@vger.kernel.org X-Gm-Message-State: AFuF++mEvZmXYQwLmJ91/6bDX3xlbjEzoyUriiIabqt6UnShXVCFwQA5 RB1u9kUh9bEioRRr4PjBUxE8FDADs8UGcvmRH4hlNMOafzIG7tYwhOcq1I7EzEKqdg== X-Gm-Gg: AYBFou2+WiJ3WXMB2qT8Aj7v3jMTE6csWq61DIa+9+jK8gOH3KAUKgrsdLhy9ySZAvg EcBZ3Jgu9jtQ6dXvYcGGwsX7XFL4BeEFCZgAt1hf+JaW6J7/Ng6aamZnyfJbtjg+mbaa0C4UgmE rsAM3kQSUOh60+fzXATPQfjC+Vw6dnzb4avsFX8QiCplDmfkOEykd9k9zKkZZqrB3N67a+n2U1F X7S/y4r1GRgaaPwYd/RAX3GMp/uWOYaR7G1m8KTLMz0f5fZFo5Wti2Z3e38f6YzoVPmMqjwf42F yiZnjuL7HBDr07L7PEHEvbTaS/aHNi+QEoj488xRpiuOWNlzwnmcG5zdAllG0ITeRbh4uEBp+me ylD9jjF0In/ViL8Ak9tTRwMTyuM3t4e8ohzrhyaDmHpqOYDv/r1Z01bsmPddnM/ZhVctPoCF6BD X6HN9BRhBIJPIjgHyNss3t0NESF3KBDwptyWhoPMi5BSMGs/xW/OyJXfpPINQpTkJVlzhnyQRpa jOc6Cax X-Received: by 2002:a17:90b:3fcc:b0:39d:efa9:cd1a with SMTP id 98e67ed59e1d1-39e54d36eabmr2302207a91.4.1789700519688; Thu, 17 Sep 2026 20:01:59 -0700 (PDT) Received: from mimolette.lan ([58.136.228.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e5a3e3dbcsm618906a91.5.2026.09.17.20.01.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 17 Sep 2026 20:01:59 -0700 (PDT) From: James Clark To: Doug Berger , Florian Fainelli , netdev@vger.kernel.org Cc: Broadcom internal kernel review list , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Vadim Fedorenko , Richard Cochran , Kory Maincent Subject: [PATCH net] net: bcmgenet: add hwtstamp callbacks to restore PHY timestamping Date: Fri, 18 Sep 2026 10:01:44 +0700 Message-ID: <20260918030149.80398-1-jjc@jclark.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hardware timestamp configuration fails with EOPNOTSUPP on BCMGENET interfaces connected to a timestamp-capable PHY. On a Raspberry Pi CM4, "hwstamp_ctl -i eth0 -t 1 -r 12" fails with "SIOCSHWTSTAMP failed: Operation not supported", preventing ptp4l from using hardware timestamping. Commit 5062245a5a7f ("net: remove legacy way to get/set HW timestamp config") removed the legacy ioctl fallback, assuming that all MAC drivers supporting hardware timestamping implement ndo_hwtstamp_get() and ndo_hwtstamp_set(), even when timestamping is provided only by an attached PHY. BCMGENET does not implement these callbacks, so the core rejects timestamp configuration requests before they reach the PHY. Add ndo_hwtstamp_get() and ndo_hwtstamp_set() callbacks so the core can dispatch timestamp configuration requests through its phylib helpers. Both callbacks return -EOPNOTSUPP because the MAC itself does not support hardware timestamping; requests for the PHY are handled by the core without invoking these callbacks. Fixes: 5062245a5a7f ("net: remove legacy way to get/set HW timestamp config") Assisted-by: LLM Signed-off-by: James Clark --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index a2305e642..8ead37ff9 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3712,6 +3712,19 @@ static int bcmgenet_change_carrier(struct net_device *dev, bool new_carrier) return 0; } +static int bcmgenet_hwtstamp_get(struct net_device *dev, + struct kernel_hwtstamp_config *cfg) +{ + return -EOPNOTSUPP; +} + +static int bcmgenet_hwtstamp_set(struct net_device *dev, + struct kernel_hwtstamp_config *cfg, + struct netlink_ext_ack *extack) +{ + return -EOPNOTSUPP; +} + static const struct net_device_ops bcmgenet_netdev_ops = { .ndo_open = bcmgenet_open, .ndo_stop = bcmgenet_close, @@ -3723,6 +3736,8 @@ static const struct net_device_ops bcmgenet_netdev_ops = { .ndo_set_features = bcmgenet_set_features, .ndo_get_stats64 = bcmgenet_get_stats64, .ndo_change_carrier = bcmgenet_change_carrier, + .ndo_hwtstamp_get = bcmgenet_hwtstamp_get, + .ndo_hwtstamp_set = bcmgenet_hwtstamp_set, }; /* GENET hardware parameters/characteristics */ -- 2.55.0