Netdev List
 help / color / mirror / Atom feed
From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
To: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
	aleksandr.loktionov@intel.com
Cc: netdev@vger.kernel.org
Subject: [PATCH iwl-net v3 0/3] ice: fixes for pause reporting, autoneg and RDMA
Date: Fri, 18 Sep 2026 15:32:31 +0200	[thread overview]
Message-ID: <20260918133234.4169074-1-aleksandr.loktionov@intel.com> (raw)

This is v3 of the ice fixes patchset for iwl-net.

v3 changes:
 - Patch "ice: support RDMA on 4+-port E830 devices": gate the
   "RDMA functionality is not available" dev_info() on the same
   condition that actually disables caps->rdma, instead of printing
   it unconditionally whenever num_funcs > 4. This addresses Simon
   Horman's review comment that E830 would otherwise log a spurious
   warning even though RDMA stays enabled on that hardware.
 - Patches "ice: fix asymmetric pause negotiation reporting in
   ethtool" and "ice: fix autoneg disable when link partner doesn't
   support AN" are unchanged since v2 (Reviewed-by: Simon Horman
   carried forward).

This series fixes three issues in the Intel ice driver:

- Asymmetric Pause capability was missing from the ethtool-reported
  supported link modes, causing ethtool to always show Pause as
  unsupported even when the hardware supports asymmetric flow control.

- Autoneg disable was only attempted when AN had already completed,
  ignoring the case where the link partner does not advertise AN ability
  at all (AN37).  Both conditions should allow the user to disable
  autoneg.

- RDMA was incorrectly disabled on E830 devices with 4 or more ports
  because the generic port-limited-capabilities path capped maxtc=4 and
  then cleared the RDMA capability bit.  E830 does not have that
  limitation and must be skipped.

Konrad Knitter (1):
  ice: fix autoneg disable when link partner doesn't support AN

Lukasz Czapnik (1):
  ice: support RDMA on 4+-port E830 devices

Tomasz Lichwala (1):
  ice: fix asymmetric pause negotiation reporting in ethtool

 drivers/net/ethernet/intel/ice/ice_common.c  | 14 +++++-----
 drivers/net/ethernet/intel/ice/ice_ethtool.c | 29 ++++++++++++++++++--
 2 files changed, 33 insertions(+), 10 deletions(-)

-- 
2.52.0


             reply	other threads:[~2026-09-18 13:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 13:32 Aleksandr Loktionov [this message]
2026-09-18 13:32 ` [PATCH iwl-net v3 1/3] ice: fix asymmetric pause negotiation reporting in ethtool Aleksandr Loktionov
2026-09-18 13:32 ` [PATCH iwl-net v3 2/3] ice: fix autoneg disable when link partner doesn't support AN Aleksandr Loktionov
2026-09-21 11:33   ` Tomasz Lichwala
2026-09-18 13:32 ` [PATCH iwl-net v3 3/3] ice: support RDMA on 4+-port E830 devices Aleksandr Loktionov
2026-09-21 11:34   ` Tomasz Lichwala
2026-09-21 14:19   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918133234.4169074-1-aleksandr.loktionov@intel.com \
    --to=aleksandr.loktionov@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox