Netdev List
 help / color / mirror / Atom feed
From: Yuya Kusakabe <yuya.kusakabe@gmail.com>
To: stephen@networkplumber.org
Cc: dsahern@kernel.org, netdev@vger.kernel.org,
	andrea.mayer@uniroma2.it, andrea@common-net.org
Subject: Re: [PATCH RFC iproute2-next v3 2/2] seg6: add support for the End.MAP behavior under seg6mobile encap
Date: Sat, 19 Sep 2026 06:44:04 +0900	[thread overview]
Message-ID: <20260918214405.2881597-1-yuya.kusakabe@gmail.com> (raw)
In-Reply-To: <20260917170154.2c8f50cf@phoenix.local>

On Wed, 17 Sep 2026 17:01:54 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> Please make the three agree. Since End.MAP is meaningless without a
> mapped SID, I would keep the usage string as-is and follow seg6local's
> convention in the man page, which spells the parameter as part of the
> action description rather than as an optional token.
Will do in v4: the synopsis drops the "[ SEG6_MOBILE_PARAM ]" token,
which leaves the action list as the only place that names it.

> 	if (action == SEG6_MOBILE_ACTION_END_MAP && !mapped_sid_ok) {
> 		fprintf(stderr, "Missing mapped_sid for End.MAP\n");
> 		exit(-1);
> 	}
Will add it as written.

> iproute2-next takes uapi header syncs from accepted kernel commits, so
> this cannot be applied until the kernel patches land in net-next.
> Please cite the upstream commit id in 1/2's changelog when you repost.
Understood.  This stays an RFC until the kernel side is in net-next,
and the non-RFC repost will carry the commit id.

Thanks for the review.

Yuya

      reply	other threads:[~2026-09-18 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 21:38 [PATCH RFC iproute2-next v3 0/2] seg6: add support for the SRv6 End.MAP behavior under seg6mobile encap Yuya Kusakabe
2026-09-16 21:39 ` [PATCH RFC iproute2-next v3 1/2] uapi: sync lwtunnel.h and add seg6_mobile.h Yuya Kusakabe
2026-09-16 21:39 ` [PATCH RFC iproute2-next v3 2/2] seg6: add support for the End.MAP behavior under seg6mobile encap Yuya Kusakabe
2026-09-18  0:01   ` Stephen Hemminger
2026-09-18 21:44     ` Yuya Kusakabe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918214405.2881597-1-yuya.kusakabe@gmail.com \
    --to=yuya.kusakabe@gmail.com \
    --cc=andrea.mayer@uniroma2.it \
    --cc=andrea@common-net.org \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox