From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f42.google.com (mail-pj2-f42.google.com [74.125.227.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4402364EB6 for ; Sat, 19 Sep 2026 06:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789797738; cv=none; b=NNMUkVp9zGGORySuHe8EGoCP0VwoygO4KBjdtL3O3S45nTkM/GMav45cyNfvo7IYeJRHy2/YDQOvnJwpaWipbhjyHx8oN5OS0kyr84O64eo2iNlUVsW6232GEw39m1Ww/3SP3ncDwLKzyd1NcJ6dhY+zGVI2gmO9Q+a/kJ8/E5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789797738; c=relaxed/simple; bh=+nPH63PYpepS1OxdMwzBuz4YyCVz/0H4x0ZyMduaJRs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UkyP67zNSZ9jjLkZjfq2u4QhwYXlxf5hiAwCcqMeK38VWthrxCM93U8E8QVlsxVczprGLC+9NtmuunIHr0g23kI9hLPM858JqFzShAQv7eXcXk1pwFJ3cJX0GLcNL2bfIad2NyuEDAyae3trk2dMh8tPfix+m38UkdkfJbVbRLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mgOPvkA8; arc=none smtp.client-ip=74.125.227.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mgOPvkA8" Received: by mail-pj2-f42.google.com with SMTP id 98e67ed59e1d1-396ccc09d65so1393357a91.3 for ; Fri, 18 Sep 2026 23:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789797736; x=1790402536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5MahHOdimanlD7mnHIbSl1eg7/7nycaIsLCZiXoOM1U=; b=mgOPvkA8wt5Mj07FvBAle86YMBmBOFLG/vHSPjxJZOAp+fxWERouUd6RLw2spGb32K /MnIjY476yKlCbmoznBq7lhdQ7ODgsWqC515o21vsaqtdAYyTBqo/Lf2yE9vwVJM+/Es a0Dg8cIh5qKxEkf7kbQJaT+Yr889LAtV5Audo+hcvYpTgzxd2CG0ads2peve6dy/kDzq j8pb/BTXRWj0rm9Gb0YHbjBRHsVmp+uRz1HRtQtdgLBC96BKXCao5lIJaTLnNyu7xr5k WjuuO4OgxJ6Fa+f0PxPvqrig6nt1m1eVbVy1ObvUnu6+94uAAbGvRRYv/utDgFh5MGBi BHzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789797736; x=1790402536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5MahHOdimanlD7mnHIbSl1eg7/7nycaIsLCZiXoOM1U=; b=MKjasjtFQGptTMDv7bXfFESg7d2TMWkPEiJ7fgLIoumgBQjL0StCenW0u3n9DW2r7z /33Emi5YB05TO8TvaAes+zVI0XPiVRB29e47R73BgUhrwINdsNayPcOlonADD6Zu7Yy6 ZVk1RK/gVrz/YWV1HYzMd2UZF2WalWQSfb+rygV0uutsyxLgUs0h5flIss0sUjwa+YRb CeIob2iLVIRDjJQ+G80pCJatChsKocNABdxCv4WosIgjTlcdXK3f8KerNxfUlyC9g9wG F2U9lpydmek6KK1PKOK+2K/LIsEPoJmtvS6Vfq7EJm7bQvDThtxtNNZjwRiPDyNmd3Uo thKQ== X-Gm-Message-State: AFuF++nGkXxU691T44r+9BqK7v7Z7HnxPnTFWDHBULl0zf2MDTuvWPgu TIvZ6093LUTOSI34+LUVOXb10IcnzsXO2i0S3r8I/C7PRDZz+Mo2NQm0YIwUKRCo8GM= X-Gm-Gg: AYBFou3zXkQaH8m4UI0oOnQ8AWaZja3R1WpOKWJJyjDTJ8dP3pEkJTbBSISrVVeas7A Fqsix28u4e0axp/svQKa+ay0WSWFOBvQYKV4+1g9CCrkzuzAhTwVPuveSbEy9VihwFmoV09AwOy nlrqLFuwiJWBTS3qgrg1yHrmOo4UG2lGI3Cee2JwwCK8pNGJAFXNRJG/k9kvFpk/Uqflf0tdDlQ 1U6VD1kU5fOxAyWI+by95g2Rb/o/2V+tDq8cxqkzqrtEDgE/YI8xxWCxlknSEqmCZwh9befqMrQ rkuohtYM7fIxWw6Nc1YFRz3kWJjUQUaxNtAilbUlyftqr5fqLBDeKYVh6u75LxWcKOv4JE4r+dc GdbdYbUrV7jyV05v80/fyUSfzOv6TtzLnQuAfd8Zqpvama5jzHpXJI23nYNhea2yfuf8xFq7HFt NSt93BzSSo+MQc0MmeYZwMBrZbv0mB+rt0HWleWbbuQ1MQwxxrU8C4PNRJwZbbGmk5ZCNMchueO POt8otT/RrveLuSU5o+eAOB+PFrMXHmWoYFJIIIvxPyOh6lvcYTleUKWSL884DGAK5I0GckZKI= X-Received: by 2002:a17:90b:2f46:b0:39e:6c68:c789 with SMTP id 98e67ed59e1d1-39e6c68caa4mr2822577a91.63.1789797735987; Fri, 18 Sep 2026 23:02:15 -0700 (PDT) Received: from Inspiron-14-5420.. ([2402:e280:21c6:671:d11b:773b:fa83:c49a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33c33140f7fsm3658321eec.13.2026.09.18.23.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 23:02:15 -0700 (PDT) From: "Hemendra M. Naik" To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, jiri@resnulli.us, jhs@mojatatu.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, vishy0777@gmail.com, tahiliani@nitk.edu.in, "Hemendra M. Naik" Subject: [PATCH net-next v7 1/3] net/sched: sch_fq_pie: add per-flow statistics via class ops Date: Sat, 19 Sep 2026 11:31:23 +0530 Message-Id: <20260919060125.38063-2-hemendranaik@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260919060125.38063-1-hemendranaik@gmail.com> References: <20260919060125.38063-1-hemendranaik@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit FQ-PIE schedules independent PIE controllers per flow but exposes no per-flow AQM state. Without class-level statistics there is no way to observe the per-flow drop probability, queue delay, deficit or dequeue rate from userspace. Extend tc_fq_pie_xstats with a type discriminator and tc_fq_pie_cl_stats for per-flow metrics. The nine existing __u32 counters keep their offsets, type is appended at offset 36 and class_stats follows it, growing the structure from 36 to 64 bytes. Wire up fq_pie_class_ops with walk, dump, and dump_stats only so that 'tc -s class show' reports per-flow state (prob, delay, deficit, avg_dq_rate, dq_rate_estimating). Filter attachment callbacks (.tcf_block, .bind_tcf, .unbind_tcf) are omitted on purpose. Derive delay with div_u64() from the full 64-bit nanosecond value rather than truncating to u32 before dividing, which wrapped for sojourn times above ~4.295 s, and widen avg_dq_rate to u64 before scaling it by PSCHED_TICKS_PER_SEC. Signed-off-by: Hemendra M. Naik Signed-off-by: Vishal Kamath Signed-off-by: Mohit P. Tahiliani --- include/uapi/linux/pkt_sched.h | 16 +++++++ net/sched/sch_fq_pie.c | 86 +++++++++++++++++++++++++++++++++- 2 files changed, 101 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 490efd2885267..9c0c9787f0c32 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/include/uapi/linux/pkt_sched.h @@ -953,6 +953,20 @@ enum { }; #define TCA_FQ_PIE_MAX (__TCA_FQ_PIE_MAX - 1) +enum { + TCA_FQ_PIE_XSTATS_QDISC, + TCA_FQ_PIE_XSTATS_CLASS, +}; + +struct tc_fq_pie_cl_stats { + __u64 prob; /* current probability */ + __u32 delay; /* current delay in microseconds */ + __s32 deficit; /* number of remaining byte credits */ + __u32 avg_dq_rate; /* current average dq_rate in + * bytes/second + */ + __u32 dq_rate_estimating; /* is avg_dq_rate being calculated? */ +}; struct tc_fq_pie_xstats { __u32 packets_in; /* total number of packets enqueued */ __u32 dropped; /* packets dropped due to fq_pie_action */ @@ -963,6 +977,8 @@ struct tc_fq_pie_xstats { __u32 new_flows_len; /* count of flows in new list */ __u32 old_flows_len; /* count of flows in old list */ __u32 memory_usage; /* total memory across all queues */ + __u32 type; + struct tc_fq_pie_cl_stats class_stats; }; /* CBS */ diff --git a/net/sched/sch_fq_pie.c b/net/sched/sch_fq_pie.c index 5982847df8f85..3a3ef83f328b2 100644 --- a/net/sched/sch_fq_pie.c +++ b/net/sched/sch_fq_pie.c @@ -511,7 +511,9 @@ static int fq_pie_dump(struct Qdisc *sch, struct sk_buff *skb) static int fq_pie_dump_stats(struct Qdisc *sch, struct gnet_dump *d) { struct fq_pie_sched_data *q = qdisc_priv(sch); - struct tc_fq_pie_xstats st = { 0 }; + struct tc_fq_pie_xstats st = { + .type = TCA_FQ_PIE_XSTATS_QDISC, + }; struct list_head *pos; sch_tree_lock(sch); @@ -563,7 +565,89 @@ static void fq_pie_destroy(struct Qdisc *sch) kvfree(q->flows); } +static struct Qdisc *fq_pie_leaf(struct Qdisc *sch, unsigned long arg) +{ + return NULL; +} + +static unsigned long fq_pie_find(struct Qdisc *sch, u32 classid) +{ + return 0; +} + +static int fq_pie_dump_class(struct Qdisc *sch, unsigned long cl, + struct sk_buff *skb, struct tcmsg *tcm) +{ + tcm->tcm_handle |= TC_H_MIN(cl); + return 0; +} + +static int fq_pie_dump_class_stats(struct Qdisc *sch, unsigned long cl, + struct gnet_dump *d) +{ + struct fq_pie_sched_data *q = qdisc_priv(sch); + struct gnet_stats_queue qs = { 0 }; + struct tc_fq_pie_xstats xstats; + u32 idx = cl - 1; + + if (idx < q->flows_cnt) { + const struct fq_pie_flow *flow = &q->flows[idx]; + + memset(&xstats, 0, sizeof(xstats)); + xstats.type = TCA_FQ_PIE_XSTATS_CLASS; + xstats.class_stats.prob = + READ_ONCE(flow->vars.prob) << BITS_PER_BYTE; + xstats.class_stats.delay = + div_u64(PSCHED_TICKS2NS(READ_ONCE(flow->vars.qdelay)), + NSEC_PER_USEC); + xstats.class_stats.deficit = READ_ONCE(flow->deficit); + xstats.class_stats.dq_rate_estimating = + READ_ONCE(q->p_params.dq_rate_estimator); + + if (xstats.class_stats.dq_rate_estimating) { + xstats.class_stats.avg_dq_rate = + ((u64)READ_ONCE(flow->vars.avg_dq_rate) + * PSCHED_TICKS_PER_SEC) >> PIE_SCALE; + } + + qs.qlen = READ_ONCE(flow->qlen); + qs.backlog = READ_ONCE(flow->backlog); + } + if (gnet_stats_copy_queue(d, NULL, &qs, qs.qlen) < 0) + return -1; + if (idx < q->flows_cnt) + return gnet_stats_copy_app(d, &xstats, sizeof(xstats)); + return 0; +} + +static void fq_pie_walk(struct Qdisc *sch, struct qdisc_walker *arg) +{ + struct fq_pie_sched_data *q = qdisc_priv(sch); + unsigned int i; + + if (arg->stop) + return; + + for (i = 0; i < q->flows_cnt; i++) { + if (list_empty(&q->flows[i].flowchain)) { + arg->count++; + continue; + } + if (!tc_qdisc_stats_dump(sch, i + 1, arg)) + break; + } +} + +static const struct Qdisc_class_ops fq_pie_class_ops = { + .leaf = fq_pie_leaf, + .find = fq_pie_find, + .dump = fq_pie_dump_class, + .dump_stats = fq_pie_dump_class_stats, + .walk = fq_pie_walk, +}; + static struct Qdisc_ops fq_pie_qdisc_ops __read_mostly = { + .cl_ops = &fq_pie_class_ops, .id = "fq_pie", .priv_size = sizeof(struct fq_pie_sched_data), .enqueue = fq_pie_qdisc_enqueue, -- 2.34.1