From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20573485504 for ; Tue, 22 Sep 2026 18:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790100523; cv=none; b=iBNLUd513EgBtoQitVuDh9qPHnPYb0nwLJPswzdg+79JpFwjyJJV3KIYriRmlg2u2gJVlY6+qkMQmlB1EyRltMRdNpSDUQ7UP7/JMN44NsNRdxe2QB9Vykbq7YsoSDLq1ohz3J11XZQOYs2fNtRamSY683c6La+zZiCMM3+YGsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790100523; c=relaxed/simple; bh=6nhRVeugXM/x6MkdahXqvJ2zeV+JEexQyuU6Fv3el8I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NrXqx0xsqrs/q1c9nf6eCy5uowI0HGgxiXA/SBsAs414g5cW5xYcSnWdP/stBIAXmi6y0meGIxxy9ug2bEmdaRF/VUOY4uX6gDZpLq9vDcZkx/tvkPVWiGNvhFyxxin2bmv8PiA/Whzj3XyBMrHlGs51Wrs5uMxU7TpfeyrPoLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PN/CMKi6; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PN/CMKi6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790100521; x=1821636521; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=6nhRVeugXM/x6MkdahXqvJ2zeV+JEexQyuU6Fv3el8I=; b=PN/CMKi699FgjXN3K6CsYpwyY2BI9E/PHF15C5z02OmWpY/GOQK35RyK lYGYfiSJEij854ntxhNi6XzcsI0WOC21/t0bqHPqml/YWxG3Q37vTevKZ My1u8wwk4hG0ZLWKUf43xnw53Cw17Fjezwntcf5FD+FRCBvspBvPJlO2n /VszzUL8PMPoVgel2h6Kg2s/n+PaewZWYE1vfYQIDta9Z89mzGrT4mAfD uq1N1azCMYVDXuaP2W6j3hrjcs3jd3mO+e9uAU50sVeKAO3pRfCpOem6T kS3LPZDIW54q3FK0XsUGdhIxygm9u96MwRe3iuKa9yz5vPX1stVl+d+rl Q==; X-CSE-ConnectionGUID: GUqkWfr7Rde3E6VNgl05Rg== X-CSE-MsgGUID: QH5aK8ZgT5y9Dl+NNr11Gg== X-IronPort-AV: E=McAfee;i="6800,10657,11913"; a="108232064" X-IronPort-AV: E=Sophos;i="6.27,116,1787036400"; d="scan'208";a="108232064" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2026 11:04:25 -0700 X-CSE-ConnectionGUID: pdhMvi0tSVyh9SHyrrH8GQ== X-CSE-MsgGUID: Kc9oprq4RD2o74V4JtZrRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,116,1787036400"; d="scan'208";a="281315351" Received: from orcnseosdtjek.jf.intel.com (HELO [10.166.28.109]) ([10.166.28.109]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2026 11:04:25 -0700 From: Jacob Keller Date: Tue, 22 Sep 2026 11:02:48 -0700 Subject: [PATCH iwl-net v2 15/15] ice: Recalibrate PHY after settime64 on E825-C Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260922-jk-e825c-timestamp-processing-logic-fixes-srcu-v2-15-e55b692d0e6b@intel.com> References: <20260922-jk-e825c-timestamp-processing-logic-fixes-srcu-v2-0-e55b692d0e6b@intel.com> In-Reply-To: <20260922-jk-e825c-timestamp-processing-logic-fixes-srcu-v2-0-e55b692d0e6b@intel.com> To: Jacob Keller , Grzegorz Nitka , Arkadiusz Kubalewski , Intel Wired LAN , Maciej Machnikowski , Przemyslaw Korba , netdev@vger.kernel.org, Anthony Nguyen Cc: Jacob Keller , Maciek Machnikowski , Paul Menzel , Aleksandr Loktionov X-Mailer: b4 0.17-dev-8b7ea X-Developer-Signature: v=1; a=openpgp-sha256; l=3924; i=jacob.e.keller@intel.com; h=from:subject:message-id; bh=5vEYcy1CyOV/oMxHrdhHXVQKWNr75ORGp4TjTOfrtLQ=; b=owGbwMvMwCWWNS3WLp9f4wXjabUkhqxNh2X9oha+Pd/Y1nj64bZzHkcfrFW5qnI1J9q60ngbv +h784V3OkpZGMS4GGTFFFkUHEJWXjeeEKb1xlkOZg4rE8gQBi5OAZhItQzDH07dex0BH4LuMida Nq6sYjjULdN1Wems6TbhMobLZY51xxj+p23Xc9OVPJo4O7KPcxfXxZ2vgnI4O9snfNzzr+6y5+x QNgA= X-Developer-Key: i=jacob.e.keller@intel.com; a=openpgp; fpr=204054A9D73390562AEC431E6A965D3E6F0F28E8 From: Maciek Machnikowski The PHY on E825-C requires recalibration after large jumps of the system time. This step is required and is done for E822 devices previously, but was accidentally skipped due to oversight when E825-C support was added. Lack of recalibration will fail to converge quickly as the effective adjustment requested is not applied properly to the PHY timestamps, so the readings from the timestamp are incorrect. Without the fix: > ptp4l[12591.505]: port 1 (eno8303np0): SLAVE to UNCALIBRATED on SYNCHRONIZATION_FAULT > ptp4l[12591.951]: port 1 (eno8303np0): UNCALIBRATED to SLAVE on MASTER_CLOCK_SELECTED > ptp4l[12592.027]: rms 752851973 max 1102277559 freq -84408798 +/- 53560133 delay 6009 +/- 92308 > ptp4l[12593.038]: rms 91302045 max 136894784 freq +100000000 +/- 0 delay 93700 +/- 24153 > ptp4l[12594.050]: rms 16036314 max 35711594 freq +47433070 +/- 46746070 delay 44899 +/- 45255 > ptp4l[12595.061]: rms 5558880 max 12292103 freq -13092285 +/- 6627317 delay -13499 +/- 6560 > ptp4l[12596.073]: rms 759533 max 1081638 freq +837063 +/- 802691 delay 711 +/- 979 > ptp4l[12597.085]: rms 60485 max 106800 freq +146706 +/- 263535 delay 145 +/- 263 > ptp4l[12598.096]: rms 16428 max 41896 freq -46707 +/- 34325 delay -40 +/- 34 > ptp4l[12599.108]: rms 3049 max 5356 freq +5337 +/- 1730 delay 7 +/- 2 > ptp4l[12600.120]: rms 284 max 381 freq +104 +/- 759 delay 2 +/- 1 > ptp4l[12601.131]: rms 42 max 119 freq -124 +/- 143 delay 2 +/- 0 > ptp4l[12602.144]: rms 11 max 25 freq +39 +/- 12 delay 3 +/- 0 > ptp4l[12603.156]: rms 2 max 4 freq +14 +/- 5 delay 3 +/- 0 > ptp4l[12604.167]: rms 1 max 3 freq +15 +/- 5 delay 2 +/- 0 > ptp4l[12605.179]: rms 1 max 4 freq +16 +/- 5 delay 2 +/- 1 > ptp4l[12606.191]: rms 1 max 3 freq +15 +/- 5 delay 3 +/- 0 With the fix: > ptp4l[12834.266]: rms 27178238388098 max 30079328952737 freq +479164 +/- 1040869 delay 5 +/- 1 > ptp4l[12834.522]: port 1 (eno8703np0): minimum delay request interval 2^-8 > ptp4l[12835.315]: rms 86919 max 139746 freq +111289 +/- 539214 delay -35 +/- 28 > ptp4l[12836.376]: rms 5415 max 8884 freq +579 +/- 22798 delay 4 +/- 5 > ptp4l[12837.429]: rms 335 max 559 freq -305 +/- 842 delay 4 +/- 1 > ptp4l[12838.471]: rms 20 max 45 freq +79 +/- 33 delay 4 +/- 0 > ptp4l[12839.512]: rms 2 max 5 freq +44 +/- 8 delay 4 +/- 0 > ptp4l[12840.545]: rms 1 max 4 freq +46 +/- 8 delay 4 +/- 0 > ptp4l[12841.586]: rms 1 max 3 freq +46 +/- 7 delay 4 +/- 0 > ptp4l[12842.637]: rms 1 max 3 freq +46 +/- 7 delay 4 +/- 0 Fixes: 7cab44f1c35f ("ice: Introduce ETH56G PHY model for E825C products") Signed-off-by: Maciek Machnikowski Reviewed-by: Paul Menzel Reviewed-by: Aleksandr Loktionov Signed-off-by: Jacob Keller --- drivers/net/ethernet/intel/ice/ice_ptp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c index e654f8962d13..b9018d8940d4 100644 --- a/drivers/net/ethernet/intel/ice/ice_ptp.c +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c @@ -2072,8 +2072,9 @@ ice_ptp_settime64(struct ptp_clock_info *info, const struct timespec64 *ts) /* Reenable periodic outputs */ ice_ptp_enable_all_perout(pf); - /* Recalibrate and re-enable timestamp blocks for E822/E823 */ - if (hw->mac_type == ICE_MAC_GENERIC) + /* Recalibrate and re-enable timestamp blocks for E822/E823/E825-C */ + if (hw->mac_type == ICE_MAC_GENERIC || + hw->mac_type == ICE_MAC_GENERIC_3K_E825) ice_ptp_restart_all_phy(pf); exit: if (err) { -- 2.56.0.rc0.395.gd1f3524e15dc