From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 030B8292B2E for ; Tue, 22 Sep 2026 03:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790046956; cv=none; b=ZqvVbLihIJHlUFTrmDaHs95er0DdZ1cc+W+JySeC3qdIJb2OhAurvTX7DL1UYVgUhzFkVehNEVcwvEsqQ4x7cHl2toRP7fE6x6Uo1iwy9zcFGISe5JUiMWDOP2IiQaaysqbxJyUlkj9yl5G6eJO3GVCBACJC+HIDA1Vbmo3RxYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790046956; c=relaxed/simple; bh=iSmmkgyOikY+CwgD/N7u04Ao1UfAh/QWnDwyIjtT3rQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EJnn+RDymqTqPgUQPXAjUfbprPDHjmUyYnh0uDo0YQGHEd59J2rJCxaeegjNb47EZ9WnDiIEa2gPMMlseMxqsZuRMSMUUTkxh24T5L/eKdO+Z+XByuakEFy6CsLKc6XlIIJd9YUVFDZwX1Ub8rGXEiNfLxoApyOjelrUkhWBj98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BoytIRsp; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BoytIRsp" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747f01363so29800205ad.2 for ; Mon, 21 Sep 2026 20:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790046953; x=1790651753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Uvk79jd+WkOqoSsKYqTDa1SfAv/OPPokbPe5GWlulBo=; b=BoytIRspLzHOGgFvPKbFZ8AuNmWz6hbkuY/d//8pfnmUlFz787w1Lr8tHMMRDE7PVh kO+k06SdRarVJ94t/06HYAc0kTNCtZIbXupY5aPxE2OrLjgYKuyxurZ2n8VC4jxG6TXS TAZiL9509jCUbNsdHunNSR7KXh5mE7q29p8IT4i91djM62Owt2grIbNzxlzU/1zn0eIE Laoz+ndT2e780Qm19WlzIIK28GzclL0ZyJ2o3ZywUjNC9oTAtx7Ca7AR1p5SJlfNfVTm +zfn+WFxlfuXTZuS52UbyIokIElZiU2igCCZrMR6UnnHOqyFXDRc/wZr2a8YPgM7syhn CwfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790046953; x=1790651753; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Uvk79jd+WkOqoSsKYqTDa1SfAv/OPPokbPe5GWlulBo=; b=RZC2l9bha4MzdwdGV9Bhoy0Vdoh0+hnDVJG3F0vxuicRl7XPf+8G53ytXumV734qKL KWzgGFJIplVpqpKuCvYUZJ8hSIiqfALeGsSRfS/9AbQxwpDiZTqeSy15LTjPxQD3z2Q/ XZ+j4vxHUGw08FzufvTJzBIIJGcdb+Dhjnwau8IgDvIa2lLUTKxcdrq49Uoz1TyhvkxR Us5U9xqmYWwrTWOF6JC035iB2fj3E22jDEvAoDzv/tIOGKXiqJq187Lz2yVKezKdkXZV YJNLQcDZPa0i2FeIXFZ3ejg8GEbNtMp314LrHwR7NxjO/Kv4vHtDNqrbZ0XpUOvdZfWG KS2Q== X-Gm-Message-State: AFuF++lWJu6EQd8w2lfRuf829lmOulmFF1qpicZG5H9qur3ibQSkd+RG m2BBQfDXhnUCFOZCHOKC1rvR9GQ32FogbSTw4skVDVkjzpPq2RMrzM476pUFxKn6sXSgSQ== X-Gm-Gg: AYBFou0FrU8QZnpV+9fHv7m6kb7eKDmJaaZLAczXkPa4uA1aCmbodAWT8U1qxSD8pso +c9zzP5pVv12K4r3K6cdQuk7/lmzQM1v9cOsy8vWITv5NmjwO4auFeQN+5prTBC3pSKQlZf/FTJ Q5V8lW+bKeVvVUOnLvKf6rVWApZ2AmMvk7hbdyR0e7IunRLvuU3JjYvPw6SN+/ACwyjWiRoUb+L dEAqKL3CXsr6k3Wt2z4HykUD/293ZXfg8MltGkh8xYuPtj/I6qOS2flxVMuSxdQ7xEnLgBGgsG/ pi1D/AcEKHR+uzDUXPo01KGRbi9gVacq4EdyRCjImBqX4/6bbvj9bNEKAZrTACstoTf6+PRWCAc 0YZOqUuvs9d9/FXzlujB8D2CZ/tzfwXrmsKwkjFijJzqYFjwZUtc8vkCuMxtVwhcXJTOb8RKYFw lE+Szk0vi3INkofmCuc2lgLgykkuNLYjK54kp99M4jmXsYFe/NjxaXAx6n1fglT4DFiYPuzRnxy WyE0gaCOAKZ5rwUczCGBz7D X-Received: by 2002:a17:903:8c6:b0:2df:42de:f71 with SMTP id d9443c01a7336-2df42de1624mr79060165ad.19.1790046953165; Mon, 21 Sep 2026 20:15:53 -0700 (PDT) Received: from localhost.localdomain ([43.224.245.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df5cf84221sm1893045ad.10.2026.09.21.20.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 20:15:52 -0700 (PDT) From: Dongliang Qin To: netdev@vger.kernel.org Cc: achender@kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dongliang Qin Subject: [PATCH net v2] rds: ib: Clear the sg list when mapping an MR fails Date: Tue, 22 Sep 2026 11:15:45 +0800 Message-ID: <20260922031546.3874605-1-cccccccccccc777777@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rds_ib_map_frmr() stores the caller's scatterlist in the MR before DMA mapping and registration can fail. On failure, __rds_rdma_map() unpins the pages and frees the scatterlist, but rds_ib_free_frmr() can still return the MR to the pool with the stale pointer set. This leaves the pool with a dangling scatterlist and can lead to local privilege escalation. KASAN detects the resulting use-after-free when the MR is later torn down: BUG: KASAN: slab-use-after-free in __rds_ib_teardown_mr Read of size 8 Call Trace: __rds_ib_teardown_mr rds_ib_unreg_frmr rds_ib_flush_mr_pool rds_ib_flush_mrs rds_free_mr rds_setsockopt Store the scatterlist in the MR only after DMA mapping succeeds. If DMA mapping fails, return directly while the MR fields remain clear; the caller keeps ownership of the scatterlist and its pinned pages. If a later registration step fails, unmap the scatterlist and clear the MR fields before returning. Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode") Cc: stable@vger.kernel.org Signed-off-by: Dongliang Qin --- Changes in v2: - Store the scatterlist in the MR only after DMA mapping succeeds. - Return directly if DMA mapping fails, leaving the MR fields clear. - Link to v1: https://lore.kernel.org/netdev/20260920063449.1594203-1-cccccccccccc777777@gmail.com/ net/rds/ib_frmr.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/rds/ib_frmr.c b/net/rds/ib_frmr.c index bd8611911..8397aa4a1 100644 --- a/net/rds/ib_frmr.c +++ b/net/rds/ib_frmr.c @@ -204,19 +204,16 @@ static int rds_ib_map_frmr(struct rds_ib_device *rds_ibdev, */ rds_ib_teardown_mr(ibmr); - ibmr->sg = sg; - ibmr->sg_len = sg_len; - ibmr->sg_dma_len = 0; frmr->sg_byte_len = 0; - WARN_ON(ibmr->sg_dma_len); - ibmr->sg_dma_len = ib_dma_map_sg(dev, ibmr->sg, ibmr->sg_len, + ibmr->sg_dma_len = ib_dma_map_sg(dev, sg, sg_len, DMA_BIDIRECTIONAL); if (unlikely(!ibmr->sg_dma_len)) { pr_warn("RDS/IB: %s failed!\n", __func__); return -EBUSY; } - frmr->sg_byte_len = 0; + ibmr->sg = sg; + ibmr->sg_len = sg_len; frmr->dma_npages = 0; len = 0; @@ -264,6 +261,8 @@ static int rds_ib_map_frmr(struct rds_ib_device *rds_ibdev, ib_dma_unmap_sg(rds_ibdev->dev, ibmr->sg, ibmr->sg_len, DMA_BIDIRECTIONAL); ibmr->sg_dma_len = 0; + ibmr->sg = NULL; + ibmr->sg_len = 0; return ret; } -- 2.43.0