Netdev List
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@openvpn.net>
To: netdev@vger.kernel.org
Cc: Antonio Quartulli <antonio@openvpn.net>,
	Sabrina Dubroca <sd@queasysnail.net>,
	Ralf Lici <ralf@mandelbit.com>, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>
Subject: [PATCH net-next 0/5] pull request: ovpn 2026-09-22
Date: Tue, 22 Sep 2026 08:08:46 +0200	[thread overview]
Message-ID: <20260922060852.2266148-1-antonio@openvpn.net> (raw)

Hi all!

Here is a small batch of ovpn changes for net-next, collected over the
past weeks. Most of it went through sashiko pre-review on openvpn-devel.

The bulk is cleanup: an unused work field goes away from struct
ovpn_socket, the redundant peer NULL checks in the crypto completion
helpers are dropped, and the documented return value of
ovpn_bind_from_sockaddr() is corrected.

On top of that, PEER_DEL_NTF now carries a peer snapshot in the same
format returned by PEER_GET. Userspace needs the final counters of a
disconnecting peer and so far had to issue a PEER_GET for every
notification; when many peers drop at once those extra transactions
overlap with notification processing on the same socket and can surface
transient netlink errors (peers disappear in the meantime). Carrying
the counters in the notification removes that round trip and errors.

Finally, the selftests enable TCP_NODELAY on ovpn-cli's TCP sockets, to
match what userspace does by default. Since TCP does not preserve record
boundaries, the capture-based peer ID check is restricted to UDP.

Note that the fixes I sent for net on Sep 21st ("pull request: fixes for
ovpn 2026-09-21") touch four of the same files, but the two series do
not conflict: I verified that they merge cleanly in either order and
that the resulting tree is identical both ways. The two pull requests
can therefore be merged in any order.

Please pull or let me know of any issue!

Thanks a lot,
	Antonio

The following changes since commit 114bd09838ac6954baaf110aebc4d5503057f88a:

  net: hip04: use 16-bit byte order for HI13X1 TX fields (2026-09-21 17:30:19 -0700)

are available in the Git repository at:

  https://github.com/OpenVPN/ovpn-net-next.git ovpn-net-next-20260922

for you to fetch changes up to bdeec4b3a279a6ace7a0ad506b04df266d9bd43d:

  ovpn: send peer object along with PEER_DEL_NTF (2026-09-22 02:37:40 +0200)

----------------------------------------------------------------
Included changes:
* include the peer object in the PEER_DEL notification
* enable TCP_NODELAY on TCP sockets in selftests
* drop redundant peer NULL checks in the crypto post functions
* remove the unused work field from struct ovpn_socket
* fix the documented return value of ovpn_bind_from_sockaddr()

----------------------------------------------------------------
Karl Mehltretter (1):
      ovpn: Fix the return value in ovpn_bind_from_sockaddr() kernel-doc

Marco Baffo (2):
      ovpn: remove redundant peer NULL checks in crypto post functions
      selftests: ovpn: enable TCP_NODELAY on TCP sockets

Ralf Lici (2):
      ovpn: remove unused work field from struct ovpn_socket
      ovpn: send peer object along with PEER_DEL_NTF

 drivers/net/ovpn/bind.c                            |  2 +-
 drivers/net/ovpn/io.c                              |  6 +--
 drivers/net/ovpn/netlink.c                         | 60 +++++++++++++---------
 drivers/net/ovpn/socket.h                          |  2 -
 tools/testing/selftests/net/ovpn/common.sh         | 59 +++++++++++++++------
 .../selftests/net/ovpn/json/peer0-float.json       | 12 ++---
 .../selftests/net/ovpn/json/peer0-symm-float.json  | 10 +++-
 .../selftests/net/ovpn/json/peer0-symm.json        |  7 ++-
 tools/testing/selftests/net/ovpn/json/peer0.json   | 12 ++---
 .../selftests/net/ovpn/json/peer1-symm.json        |  2 +-
 tools/testing/selftests/net/ovpn/json/peer1.json   |  2 +-
 .../selftests/net/ovpn/json/peer2-symm.json        |  2 +-
 tools/testing/selftests/net/ovpn/json/peer2.json   |  2 +-
 .../selftests/net/ovpn/json/peer3-symm.json        |  2 +-
 tools/testing/selftests/net/ovpn/json/peer3.json   |  2 +-
 .../selftests/net/ovpn/json/peer4-symm.json        |  2 +-
 tools/testing/selftests/net/ovpn/json/peer4.json   |  2 +-
 .../selftests/net/ovpn/json/peer5-symm.json        |  2 +-
 tools/testing/selftests/net/ovpn/json/peer5.json   |  2 +-
 .../selftests/net/ovpn/json/peer6-symm.json        |  2 +-
 tools/testing/selftests/net/ovpn/json/peer6.json   |  2 +-
 tools/testing/selftests/net/ovpn/ovpn-cli.c        | 22 ++++++++
 tools/testing/selftests/net/ovpn/test.sh           | 54 +++++++++----------
 23 files changed, 171 insertions(+), 99 deletions(-)
 mode change 120000 => 100644 tools/testing/selftests/net/ovpn/json/peer0-symm-float.json
 mode change 120000 => 100644 tools/testing/selftests/net/ovpn/json/peer0-symm.json

             reply	other threads:[~2026-09-22  6:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  6:08 Antonio Quartulli [this message]
2026-09-22  6:08 ` [PATCH net-next 1/5] ovpn: Fix the return value in ovpn_bind_from_sockaddr() kernel-doc Antonio Quartulli
2026-09-22  6:08 ` [PATCH net-next 2/5] ovpn: remove unused work field from struct ovpn_socket Antonio Quartulli
2026-09-22  6:08 ` [PATCH net-next 3/5] ovpn: remove redundant peer NULL checks in crypto post functions Antonio Quartulli
2026-09-22  6:08 ` [PATCH net-next 4/5] selftests: ovpn: enable TCP_NODELAY on TCP sockets Antonio Quartulli
2026-09-23  6:49   ` netdev-bot+sashiko
2026-09-25 13:26     ` Antonio Quartulli
2026-09-22  6:08 ` [PATCH net-next 5/5] ovpn: send peer object along with PEER_DEL_NTF Antonio Quartulli
2026-09-23  6:49   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922060852.2266148-1-antonio@openvpn.net \
    --to=antonio@openvpn.net \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ralf@mandelbit.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox