Re: [PATCH net] hinic3: handle auxiliary device ID allocation failure

[Fan Gong <gongfan1@huawei.com>]

> hinic3_init_hwdev() stores the result of hinic3_adev_idx_alloc() in
> hwdev->dev_id without checking for an error. If ID allocation fails but
> the remaining initialization succeeds, hinic3_add_one_adev() uses the
> negative error code as the auxiliary device ID instead of a reserved ID.
> 
> Return the allocation error before initializing the hardware. Add an
> unwind label that clears pci_adapter->hwdev and frees the allocation
> without attempting to release an ID that was never allocated.
> 
> Fixes: 8133788d023f ("hinic3: Nic_io initialization")
> Reported-by: Changyul Lee <lcy8047@gmail.com>
> Assisted-by: LLM
> Signed-off-by: Sang-Hoon Choi <csh0052@gmail.com>
> ---
> Found during source review at mainline
> 5dd1818b15d98d4a20806cd00b1b40320b06004f. The affected source is unchanged
> at f0100363d8c374bd8e9ea7c9ba02744f0b802ca4.
> 
> The modified hinic3_hwdev.o compiled with x86 allmodconfig and W=1.
> I have not tested this on hinic3 hardware or injected ID allocation
> failures.

Thank you for your contribution! We will test this patch later.