From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alessandro Zini <alessandro.zini@siemens.com>
Cc: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Ciprian Regus <ciprian.regus@analog.com>,
Qingfang Deng <qingfang.deng@linux.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/4] dt-bindings: net: adi,ad3306: add reset-gpios property
Date: Thu, 24 Sep 2026 13:50:53 +0200 [thread overview]
Message-ID: <20260924-grinning-rampant-orca-8a8f26@quoll> (raw)
In-Reply-To: <20260918224934.51998-3-alessandro.zini@siemens.com>
On Sat, Sep 19, 2026 at 12:49:32AM +0200, Alessandro Zini wrote:
> The ADIN1140/AD3306 MAC-PHY has an active-low hardware reset pin, and the
> driver binds to the common OA TC6 library which is gaining support for an
> optional reset GPIO. As the schema uses "unevaluatedProperties: false", a
> board description using the property would otherwise be rejected.
Whatever library takes or does, will not generate any warnings. I do not
see at all how unevaluatedFalse is relevant here. There is no way
changing library C code causes any warnings. At least as of now.
Also, no properties should be added because some library gets its
support. You add the property because hardware has it.
If the first sentence is correct, then it is enough and keep only this.
> Add the optional reset-gpios property to describe the connection to that
> pin.
This is also redundant, directly implied by the first one.
With drpoping of both:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-24 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 22:49 Alessandro Zini
2026-09-18 22:49 ` [PATCH net-next v3 1/4] dt-bindings: net: microchip,lan8650: add reset-gpios property Alessandro Zini
2026-09-18 22:49 ` [PATCH net-next v3 2/4] dt-bindings: net: adi,ad3306: " Alessandro Zini
2026-09-24 11:50 ` Krzysztof Kozlowski [this message]
2026-09-18 22:49 ` [PATCH net-next v3 3/4] net: ethernet: oa_tc6: return ERR_PTR from oa_tc6_init() Alessandro Zini
2026-09-18 22:49 ` [PATCH net-next v3 4/4] net: ethernet: oa_tc6: add reset-gpios support Alessandro Zini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924-grinning-rampant-orca-8a8f26@quoll \
--to=krzk@kernel.org \
--cc=alessandro.zini@siemens.com \
--cc=andrew+netdev@lunn.ch \
--cc=ciprian.regus@analog.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=qingfang.deng@linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox