From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD7C4CC62E for ; Thu, 24 Sep 2026 23:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790290972; cv=none; b=C4/fG0ZpSG5uRpp7VhZn2TLN5V6hdEb7l9TSdINQtiyUIk4Cf+bW0c0jJ39OSIw2AyHW3cMG4QC6zyIOS4CuxJ5JMkSutetvk3c2/zwg/T++CCjLOsvtLb8mZ48lEy6AzKSYxtHh7kz+XCo3hmBjSNN3ttxfZeYbqnaVGjvXsjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790290972; c=relaxed/simple; bh=1iRj8n7qRYALgg7IVGBWtWv8CIf75ownoHVgp7tITjk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FAOitKcZr0wy3RE6OCZ8hIP4C4JDR/+FfQ+QbWiow9Bmb1kPkJ4VqqikqR/SgvGbGKJcdOqvxUduereYys2RDyiZfBS4ARJ1Vh9E+vYD+B5IDAe+jlylwer3Dr3VbHWqEoPcAYi8FiGtzrIXbzVolQF+twjjgTfkNYxj2sbLEKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rz67xUQt; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rz67xUQt" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e71cdb22bso2189395e9.2 for ; Thu, 24 Sep 2026 16:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790290969; x=1790895769; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=TRQDcfp704v7y9W9giZQnIbIP3wKdXktBztj3wl4XLo=; b=rz67xUQt9CLzXiBXE5pLdu6AFIguT2Strk/FCqziaOrKFBJZoC2+XliCDoNZoMPB4M 7Mo5si7PRsuWMiPLgu3d7HXQIDArMtlLt2xUbUPJY9Asv2UzkXZGtbrzsHz0fYeWtNGM xuCfMBYONrfgH7SrEjHM3fMzdx82Rr8Wnjk72ZebI0QkQze8PK1HWIG4ngBTCRa6qr42 vQYmpT+SCfdJIU3/G2uGg/ZpTu93iMqflxXaRvJp1wAw9j+ywQKSl5W11NuvfWB9MH54 V6ksQAA5tbcErVa9wdqyp5EOnFc84sQxXctkck2TEyov//+AIpg5V9Y3wh42XDRIJ40O VE5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790290969; x=1790895769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=TRQDcfp704v7y9W9giZQnIbIP3wKdXktBztj3wl4XLo=; b=f8jGZEh96nvd+Ivf5PtAkfqJ1XutP3oK2+vimF1tRC5G3juvt3vMdkjHnW3M+AcXOX ZlM4Xkr4rpeqvpv0pbMBjE7vrqjQu9t7c/5404zjEN28o88RPAY8q2nzrmym5Hq/ArLK WXEFEd72iN5eZoO8nworOB1L9kw3r8CxJC+NcJu6OeEiWfeOw68QxbRPhK9yyA5zBkfh w98TiD2KbFDVDi0Xh8knHuhojzwoLY49HPfIMWMwho8AOMF3rxRlxYLkurwu2QOWD0Ni s9w6UoPOfdVbd8ppNmKEaDE1EHXGaIGgD9MiHRkn3BmkVyoq7hoA6685ISpmTza0+wrs AdFw== X-Forwarded-Encrypted: i=1; AKwUvBwRXThkTqw6WKcfzLJrMAGjCCfGy4TQ484JUMhajtvVRSst+tIEbfsMO8AuZuYYHp7Q1rGTGnw=@vger.kernel.org X-Gm-Message-State: AFuF++kS4h+Ar4o/4SyMGLgITDvMOQZd3bpDn90rL/Oqo9fwFetnmSZr H57oiXgWtobvHzFIunzdNncfMofLNTkhU30lnE4Dz1gFiKPGROlJO640 X-Gm-Gg: AYBFou3WxhHzbDFs+xvDkQ0JT70FA6jCsiiXVFeFmvGrk6JjR/o9X8d4xfDSimzwHsy yDWPzcqx3da9+xo+7uf3AV+4kmsq/Un0Z8E9M9S5+90AmmvzoQs0FvvBOkqP3ErRmOSZkqH4RUi SksQ2AU9DUC9bTIP8IeYPZY/0ONqFuRrT8SmvCOnGSgznTDXSZ0pzWvTaMgkXCAb37waqyUSpmi meISxyHDV2McAyJgVXUWs3oUkj3ksafNcUK1otFV7LcjjWfFrtFkyCNbt625Y+UoV1KE3n5uQGu lYCm/946blagEPhHf3X2+duzsjQxA0SfeaNwImgRY55xwOLrpiGlxdaE2fe3bZrthodjHxx7yJi 5Gtf0i5EvueL4bsB8huGxr5VSapdA5gfwkzUB2LlX+s83XmjSRtlFX1XN4NG1Ch4UMpvE/d/5vv pWRpxRC2nlWR5oXmqsjXMG2RiyXhydptRCNTBez9oZ3XxucBV26T/ORBqTQTI8MF/MRaNqGvm/s Shglmb/Tc4V5bR08nRDmo/huILA3S7lhWmnoiOZYR0GY5DlN2nsNQQ40P9qdzVG X-Received: by 2002:a05:600c:4f4f:b0:49e:69f8:e846 with SMTP id 5b1f17b1804b1-49fe66cbb70mr75087625e9.9.1790290968884; Thu, 24 Sep 2026 16:02:48 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-79-29-83-136.business.telecomitalia.it. [79.29.83.136]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49ff06cbe57sm12288175e9.13.2026.09.24.16.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 16:02:48 -0700 (PDT) From: Christian Marangi To: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v17 09/12] net: phylink: add .pcs_link_down PCS OP Date: Fri, 25 Sep 2026 01:01:50 +0200 Message-ID: <20260924230211.11519-10-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260924230211.11519-1-ansuelsmth@gmail.com> References: <20260924230211.11519-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Permit for PCS driver to define specific operation to tear down the link between the MAC and the PCS. This might be needed for some PCS that reset counter or require special reset to correctly work if the link needs to be restored later. On phylink_link_down() call, the additional phylink_pcs_link_down() will be called after .mac_link_down to tear down the link. PCS driver will need to define .pcs_link_down to make use of this. Signed-off-by: Christian Marangi Reviewed-by: Maxime Chevallier --- drivers/net/phy/phylink.c | 9 +++++++++ include/linux/phylink.h | 12 ++++++++++++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index b87655a09df8..fab55e6ed507 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -989,6 +989,12 @@ static void phylink_pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode, pcs->ops->pcs_link_up(pcs, neg_mode, interface, speed, duplex); } +static void phylink_pcs_link_down(struct phylink_pcs *pcs) +{ + if (pcs && pcs->ops->pcs_link_down) + pcs->ops->pcs_link_down(pcs); +} + static void phylink_pcs_disable_eee(struct phylink_pcs *pcs) { if (pcs && pcs->ops->pcs_disable_eee) @@ -1701,6 +1707,9 @@ static void phylink_link_down(struct phylink *pl) pl->mac_ops->mac_link_down(pl->config, pl->act_link_an_mode, pl->cur_interface); + + phylink_pcs_link_down(pl->pcs); + phylink_info(pl, "Link is Down\n"); } diff --git a/include/linux/phylink.h b/include/linux/phylink.h index f06eb8b6f94a..f03c1dc0a4a1 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -528,6 +528,7 @@ struct phylink_pcs { * @pcs_an_restart: restart 802.3z BaseX autonegotiation. * @pcs_link_up: program the PCS for the resolved link configuration * (where necessary). + * @pcs_link_down: tear down link between MAC and PCS. * @pcs_disable_eee: optional notification to PCS that EEE has been disabled * at the MAC. * @pcs_enable_eee: optional notification to PCS that EEE will be enabled at @@ -555,6 +556,7 @@ struct phylink_pcs_ops { void (*pcs_an_restart)(struct phylink_pcs *pcs); void (*pcs_link_up)(struct phylink_pcs *pcs, unsigned int neg_mode, phy_interface_t interface, int speed, int duplex); + void (*pcs_link_down)(struct phylink_pcs *pcs); void (*pcs_disable_eee)(struct phylink_pcs *pcs); void (*pcs_enable_eee)(struct phylink_pcs *pcs); int (*pcs_pre_init)(struct phylink_pcs *pcs); @@ -690,6 +692,16 @@ void pcs_an_restart(struct phylink_pcs *pcs); void pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode, phy_interface_t interface, int speed, int duplex); +/** + * pcs_link_down() - tear down link between MAC and PCS + * @pcs: a pointer to a &struct phylink_pcs. + * + * This call will be made just after mac_link_down() to inform the PCS the + * link has gone down. PCS should be configured to stop processing packets + * for transmission and reception. + */ +void pcs_link_down(struct phylink_pcs *pcs); + /** * pcs_disable_eee() - Disable EEE at the PCS * @pcs: a pointer to a &struct phylink_pcs -- 2.55.0