From: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
To: Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Eva Kurchatova <eva.kurchatova@virtuozzo.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH] selftests: netdevsim: skip the rate tc-bw check without tool support
Date: Fri, 25 Sep 2026 16:55:01 +0300 [thread overview]
Message-ID: <20260925135512.3644101-1-eva.kurchatova@virtuozzo.com> (raw)
The tc-bw attribute was added to devlink in iproute2 6.17, together
with the kernel side in v6.17. An older devlink has no such option and
the rate test fails on "Unknown option" instead of skipping.
Probe once in rate_test() and skip the tc-bw checks as a whole, so that
a missing option costs a single skip line rather than one per rate
object.
Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
---
.../drivers/net/netdevsim/devlink.sh | 29 +++++++++++++------
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
index 22a626c6cde3..1ba925459aff 100755
--- a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
+++ b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
@@ -849,6 +849,13 @@ rate_test()
{
RET=0
+ local tc_bw_supported=false
+ if devlink port function rate help 2>&1 | grep -q tc-bw; then
+ tc_bw_supported=true
+ else
+ log_test_skip "rate tc-bw" "Current iproute doesn't support rate option 'tc-bw'."
+ fi
+
echo $VF_COUNT > /sys/bus/netdevsim/devices/$DEV_NAME/sriov_numvfs
devlink dev eswitch set $DL_HANDLE mode switchdev
local leafs=`rate_leafs_get $DL_HANDLE`
@@ -872,12 +879,14 @@ rate_test()
rate=$(($rate+100))
done
- local tc_bw="0:0 1:40 2:0 3:0 4:0 5:0 6:60 7:0"
- for r_obj in $leafs
- do
- rate_attr_tc_bw_check "$r_obj" "$tc_bw" \
- "$DEBUGFS_DIR"/ports/"${r_obj##*/}"
- done
+ if $tc_bw_supported; then
+ local tc_bw="0:0 1:40 2:0 3:0 4:0 5:0 6:60 7:0"
+ for r_obj in $leafs
+ do
+ rate_attr_tc_bw_check "$r_obj" "$tc_bw" \
+ "$DEBUGFS_DIR"/ports/"${r_obj##*/}"
+ done
+ fi
local node1_name='group1'
local node1="$DL_HANDLE/$node1_name"
@@ -897,9 +906,11 @@ rate_test()
$DEBUGFS_DIR/rate_nodes/${node1##*/}/tx_max
- local tc_bw="0:20 1:0 2:0 3:0 4:0 5:20 6:60 7:0"
- rate_attr_tc_bw_check $node1 "$tc_bw" \
- "$DEBUGFS_DIR"/rate_nodes/"${node1##*/}"
+ if $tc_bw_supported; then
+ local tc_bw="0:20 1:0 2:0 3:0 4:0 5:20 6:60 7:0"
+ rate_attr_tc_bw_check $node1 "$tc_bw" \
+ "$DEBUGFS_DIR"/rate_nodes/"${node1##*/}"
+ fi
rate_node_del "$node1"
--
2.55.0
next reply other threads:[~2026-09-25 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 13:55 Eva Kurchatova [this message]
2026-09-26 0:11 ` [PATCH] selftests: netdevsim: skip the rate tc-bw check without tool support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925135512.3644101-1-eva.kurchatova@virtuozzo.com \
--to=eva.kurchatova@virtuozzo.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox