From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D028737F732; Sat, 26 Sep 2026 16:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790440013; cv=none; b=bx8VIkxyA8jLOAGu1TeMgrI+L9eqil1jyXfGHcfr9GMzzMAFLmdwObIab+INdZkImxqQ31rMa/f42VGwC7nmd8ovrpm0ro/ckrrAcEhgVBD7j6RJCulEI9gregJpCOsVYV/5tnDPYE8tXrvDhLi59XH9lTNiDqSVE/JYAsdPc/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790440013; c=relaxed/simple; bh=lfJOnW8dwrulCJ3fLtiALRb+yMxarM6N3w1MRgPkU30=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cLOdgOFvrDhaBVWTMfLjIneBszzZD0SBIj8GByQ8h2aKuvmAMl+fXUnSWvg9vKPAcG8FiYXO7fecDNXFomizxfhL405B0uVVNtrKVfrjSnARjCJhQfmfDkBQtB3PCnKJJc3jnUd3g3z93nZ1iWAU+ZPjh7HOL0o3EK/XzgefCEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=JYIsb/VW; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="JYIsb/VW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Ut yYF+w0ZNzhSxef8YqnOEHcpNsRkHSyxTHCosQDB60=; b=JYIsb/VWjb/ulZJ3Yw mkxCzCnM86wNNE+ugoaHxLs0BD1T2h5KuEZsV3r/Bkx58JA9aAgFa1XaJB7T2mwP zkv5ZG4QN58mjf1MYdcFTUP3DDfk3zhGPTTfduNDAHfQyfyeBtPywqURI2PvdEwS 542a2tXdPkaZHGpDJj3Uq2o94= Received: from pc.localdomain (unknown []) by gzga-smtp-mtada-g1-0 (Coremail) with SMTP id _____wD3v6EU8rdq1Ce5Aw--.54526S4; Sun, 27 Sep 2026 00:26:15 +0800 (CST) From: Jiale Yao To: Willem de Bruijn , Jason Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiale Yao Subject: [PATCH 2/3] tun: Drain eBPF RCU callbacks on module exit Date: Sun, 27 Sep 2026 00:25:51 +0800 Message-Id: <20260926162554.163197-3-yaojiale02@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260926162554.163197-1-yaojiale02@163.com> References: <20260926162554.163197-1-yaojiale02@163.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3v6EU8rdq1Ce5Aw--.54526S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7JFWUKFy5trW5XFy8uFyUJrb_yoWkZFX_Kr yIvr9rGr4DGan7KF1Ykr43Zr98ua4Y9FyFqrsaq3y3J3y8Zrn8uwn5Zrn3AryUGrWxAF9I krnrGFyxu3929jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRHHqo5UUUUU== X-CM-SenderInfo: x1dryxhdohiji6rwjhhfrp/xtbCzQdOiGq38ieK5gAA3o Replacing or clearing a TUN eBPF program defers its destruction to tun_prog_free(). In the device teardown path, tun_free_netdev() can queue this callback as a private destructor. The rcu_barrier() in netdev_run_todo() runs before private destructors, so it cannot drain the new callback. After the last file or persistent-device reference is released, tun can therefore unload before the callback runs. Drain outstanding callbacks at the end of module cleanup so they cannot execute from freed module text. Fixes: 96f84061620c ("tun: add eBPF based queue selection method") Signed-off-by: Jiale Yao --- drivers/net/tun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 5a302709a68a..bde5032bf4f4 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -3855,6 +3855,7 @@ static void __exit tun_cleanup(void) misc_deregister(&tun_miscdev); rtnl_link_unregister(&tun_link_ops); unregister_netdevice_notifier(&tun_notifier_block); + rcu_barrier(); } /* Get an underlying socket object from tun file. Returns error unless file is -- 2.34.1