From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo2-f36.google.com (mail-oo2-f36.google.com [74.125.231.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D55213CB57F for ; Sun, 27 Sep 2026 22:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.164 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790546404; cv=none; b=FJJ7RZCZa7kBlCTLhH2ChPkZNxUsXlxIrHn6c7zzb0jkvtSkdKQXyPUmrNFyflcRJSuPYY7aulD+XLhgeeaulk7LdS9GJJfmchWGUPNOGj1IbIs2QHpXJK6Z7HgAu+GNKRb7+7dHvGQVisKmYsBawXFzZUWIHFalW8TlKb6Orw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790546404; c=relaxed/simple; bh=2ChPtfS7fuQ6xmL5pBM0ED+Tz6MNWUwwNmCfWCfm6zM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qKx2OuZvz1M7S67gDpj6jyoouVYOR2ghCdJXwn7wDRl5q3I1UHZ6+J4j4c0HPJdNO1dz6a1Neq5AAGJrnWr3IqpCXdi3OBdBamMvsuTUi30mANnMuyqwaDAmgn0r+ozmrGsSWviKTLmE8k1+lqrV44JMpsCbVXc1ItTI3/O9YVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CEi6GvdR; arc=none smtp.client-ip=74.125.231.164 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CEi6GvdR" Received: by mail-oo2-f36.google.com with SMTP id 46e09a7af769-81a86afd781so635564a34.1 for ; Sun, 27 Sep 2026 14:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790546396; x=1791151196; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pt1JZ0Xx4dSQpjlcwcv4OrOAetyhY0kdTpc42Knguac=; b=CEi6GvdRr9Qc9e5aohxNgsgG1WWEfL9SmvQl2UZhtPWzlz9PZ0Ph10zKMiShuWufKd +y5LKJ5MwfK3HsHgB9to5D+nLxvfX7fsC+dW1ePeAv9eqxxBpIGPMXqIE12Hx9W6zv49 T9OmTgGIb0B2BuuBI/W/xeiSU7GmlYljzX4Scct/iMvlEyjRm8ywQ+zjzG4Ei6IsayfJ PvGcqpzIBh1TVyZGJHMQihOYCQeyCDXNNTfsTLVv0TVk4LhdoKf/ll1kvwBA+kbYszdi /lBT3zMlNocApC9m3dK7LIHeJ6U5MeCE8y12BqSYFZPWHIKH0tHp7+ACFRYdwvhTkFRB lYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790546396; x=1791151196; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pt1JZ0Xx4dSQpjlcwcv4OrOAetyhY0kdTpc42Knguac=; b=XxwTFRKB0by1iroX9ikD+z/YljAkpcxA5ZThLOWoFkcYhw2G0/a1rAIjHivA04qj97 1UP9mfouIxh6oJzBFDmWQ91tYhNge6nuNgZDH/Dcd6LEwQHrWED6wny3thiV527fAcql kR6GzAseoXpmV8uhx8Ey7FZ3JhqKAkQrH/tdMXn/eaEvv9j3zOED/dkLtRSR8q+1YVTM RmI7Mr1ekhqAdFSMk/bidqkSvJ6WQyLLGjWfcjjnbKin1YO8k/wHtzRpxiLJAAcHR6gz vMCcORMEl+KQ2N89wdoiN6WuT7j9ByOgrjMXCMmD6e2rtTrH3tvlBTAsHUsRxUI/kvUA 43HQ== X-Forwarded-Encrypted: i=1; AKwUvBwlGgT/dCt4Wty0y5cktKY1f2zZFt0MuArWrBZnTZNAGcwynU0RJ+YZyuV/uUXcnWXOzFn6mgk=@vger.kernel.org X-Gm-Message-State: AFuF++k6W3TepoMQr4yf0H5wfEwEXSwROwW5b2K7tOfBfeCyZDNyrbWl ZlZbwheUdTu8Dl6+qZpGpMl03j02azfKmvWIZiNHkETEHPLYEL/Tdg3X X-Gm-Gg: AYBFou3kNLz6Rd7ClIns0Ph96tdocC4dAY8S2aAeZb6OezIaq+TA6IUG5wJo/f/1wFm X/X5i7heIuP/V0QQkm1u0QkRNsUUNqUvr7ZeKev2NknZVzwjhjnTH1YfF9Y2og5OOPu0P4JuYDL +iviFAgwEy2o1qZ+MOi8fM8wn44iSrLuszQ1rclVve87x9DsvDxoR1F2XVI1bbNrxv6Tea/3uSD sBFORXnBR9rwtrylBzAokxSo0RmKBTO4qNWv83lXGP2a61k6sSHob7F+7hj1bwACnA1cuF3t59/ QeJpCpY8hewjWPIqVcahuri4YXdJtOIQ6PbHJGRRbqwYjJCSTGdkZl8/sOudyHYXYHZxlkQ3hym H2vFbx/QOKLfUsYrCk08SwmKV2aAYhDVRUdC5AxWthfqh6ieDVNjQdgTV1c+KpAEkfC6yThCUBG KOYfHpkR9JkOexyKboEBEjNA7BBDV+mKIsnxif3QAIrdvwGvJrGYRGy82XSmzc6VV1CmFjH0/qJ hOLcSPZy5yqjvQqgVRMtyqgyA8j6JRtrstKr72U8rRHeXDpyXmyj71kOxiBuEEVvhPJWIN1M/iu yESUWBNov5hOAtHfn13evBVNTEMlWKQ8yO5tlBajYo8YAxu2oIHhHwWHL0l05vQ3qEaG2CXfMGv w568zUbCkRFLeT8doK7LBoT/yYBUY/rg= X-Received: by 2002:a05:6830:6d50:b0:7fa:ac4f:794 with SMTP id 46e09a7af769-81781d93ab0mr13732683a34.16.1790546395901; Sun, 27 Sep 2026 14:59:55 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-81b3de6f7e1sm4874147a34.22.2026.09.27.14.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2026 14:59:55 -0700 (PDT) From: James Hilliard Date: Sun, 27 Sep 2026 15:59:39 -0600 Subject: [PATCH net-next v5 04/19] xsk: freeze deferred pool teardown during system sleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260927-submit-stmmac-reset-fixes-v1-v5-4-feec6c14dd06@gmail.com> References: <20260927-submit-stmmac-reset-fixes-v1-v5-0-feec6c14dd06@gmail.com> In-Reply-To: <20260927-submit-stmmac-reset-fixes-v1-v5-0-feec6c14dd06@gmail.com> To: Russell King , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Russell King (Oracle)" , Maxime Chevallier , Andrew Lunn , Maxime Coquelin , Alexandre Torgue , Christian Marangi , Tiezhu Yang , Huacai Chen , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Serge Semin , Suraj Jaiswal , Richard Cochran , Joao Pinto , Vladimir Oltean , Ong Boon Leong , Voon Weifeng , "Song, Yoong Siang" , Linus Walleij , Martin Blumenstingl , Magnus Karlsson , Maciej Fijalkowski , Simon Horman , =?utf-8?q?Bj=C3=B6rn_T=C3=B6pel?= , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jose Abreu , Yao Zi , Philipp Zabel Cc: Richard Genoud , Alastair D'Silva , Maxime Ripard , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org, ZhaoJinming , Lorenzo Bianconi , Ding Hui , Linkui Xiao , Linkui Xiao , linux-tegra@vger.kernel.org, linux-sunxi@lists.linux.dev, James Hilliard X-Mailer: b4 0.15.2 Pool destruction calls the driver under RTNL from system_wq. That queue is not frozen during system sleep, so ndo_bpf() can run after the device suspend callback has gated its clocks or after the noirq phase. Use the freezable workqueue for deferred pool release. Work already running completes before device suspend, and newly queued destruction waits until device resume. The pool, UMEM and netdev references remain owned by the work until then. This does not replace driver error handling after a failed resume. Fixes: 1c1efc2af158 ("xsk: Create and free buffer pool independently from umem") Signed-off-by: James Hilliard --- net/xdp/xsk_buff_pool.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c index 9d2d94f1fb75..c58f56f24a9c 100644 --- a/net/xdp/xsk_buff_pool.c +++ b/net/xdp/xsk_buff_pool.c @@ -337,7 +337,10 @@ bool xp_put_pool(struct xsk_buff_pool *pool) if (refcount_dec_and_test(&pool->users)) { INIT_WORK(&pool->work, xp_release_deferred); - schedule_work(&pool->work); + /* Teardown calls ndo_bpf(), which may need powered hardware. + * RTNL alone does not exclude the device's system PM callbacks. + */ + queue_work(system_freezable_wq, &pool->work); return true; } -- 2.53.0