From: Kuniyuki Iwashima <kuniyu@google.com>
To: David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Chris J Arges <carges@cloudflare.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: [PATCH v1 net-next 2/5] net: Add ->pre_exit_batch() to struct pernet_operations.
Date: Sun, 27 Sep 2026 20:23:39 +0000 [thread overview]
Message-ID: <20260927202429.2452589-3-kuniyu@google.com> (raw)
In-Reply-To: <20260927202429.2452589-1-kuniyu@google.com>
While unregistering a netdev, we must find and clean up all
resources holding refcounts of the device.
This operation is usually triggered for each component via
NETDEV_UNREGISTER and typically requires a full scan of hash
tables, etc.
For example, rt_flush_dev() and rt6_uncached_list_flush_dev()
are called for each netdev and iterate over the global per-cpu
lists to find uncached routes tied to the device, resulting
in O(N_dev x (N_cpu + N_route)) loops during netns dismantle.
Moreover, rt_flush_dev() and rt6_uncached_list_flush_dev()
do not even require RTNL.
To batch such cleanup across dying netns without holding RTNL
before ops_exit_rtnl_list(), let's add a new ->pre_exit_batch()
hook to pernet_operations.
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
---
include/net/net_namespace.h | 1 +
net/core/net_namespace.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
index b4247e767d13..58b2601bb869 100644
--- a/include/net/net_namespace.h
+++ b/include/net/net_namespace.h
@@ -488,6 +488,7 @@ struct pernet_operations {
*/
int (*init)(struct net *net);
void (*pre_exit)(struct net *net);
+ void (*pre_exit_batch)(struct list_head *net_exit_list);
void (*exit)(struct net *net);
void (*exit_batch)(struct list_head *net_exit_list);
/* Following method is called with RTNL held. */
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 0e13de0cd36b..476fbf913bad 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -160,6 +160,9 @@ static void ops_pre_exit_list(const struct pernet_operations *ops,
list_for_each_entry(net, net_exit_list, exit_list)
ops->pre_exit(net);
}
+
+ if (ops->pre_exit_batch)
+ ops->pre_exit_batch(net_exit_list);
}
static void ops_exit_rtnl_list(const struct list_head *ops_list,
--
2.56.0.rc1.315.gc6ed9934b7-goog
next prev parent reply other threads:[~2026-09-27 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 20:23 [PATCH v1 net-next 0/5] ip: Batch flushing uncached routes for dying netns Kuniyuki Iwashima
2026-09-27 20:23 ` [PATCH v1 net-next 1/5] net: Remove net->is_dying Kuniyuki Iwashima
2026-09-29 6:26 ` netdev-bot+sashiko
2026-09-27 20:23 ` Kuniyuki Iwashima [this message]
2026-09-29 6:26 ` [PATCH v1 net-next 2/5] net: Add ->pre_exit_batch() to struct pernet_operations netdev-bot+sashiko
2026-09-27 20:23 ` [PATCH v1 net-next 3/5] net: Track state in ops_undo_list() Kuniyuki Iwashima
2026-09-27 20:23 ` [PATCH v1 net-next 4/5] ipv4: Batch rt_flush_dev() for dying netns Kuniyuki Iwashima
2026-09-27 22:51 ` Eric Dumazet
2026-09-28 16:33 ` Kuniyuki Iwashima
2026-09-29 6:26 ` netdev-bot+sashiko
2026-09-27 20:23 ` [PATCH v1 net-next 5/5] ipv6: Batch rt6_uncached_list_flush_dev() " Kuniyuki Iwashima
2026-09-29 6:26 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927202429.2452589-3-kuniyu@google.com \
--to=kuniyu@google.com \
--cc=carges@cloudflare.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox