From: Rahul Chandelkar <rc@rexion.ai>
To: netdev-bot+sashiko@kernel.org
Cc: Rahul Chandelkar <rc@rexion.ai>,
pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
phil@nwl.cc, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH nf-next v4 4/4] netfilter: nf_conntrack_sip: use shared helper parsers
Date: Mon, 28 Sep 2026 13:13:48 +0000 [thread overview]
Message-ID: <20260928131348.4160994-1-rc@rexion.ai> (raw)
In-Reply-To: <179053062534.2160803.18214039590923264255@kernel.org>
On Sun, 27 Sep 2026 17:37:05 +0000, netdev-bot+sashiko@kernel.org wrote:
> Should the old limit be kept, for example by rejecting end - dptr > 5?
Yes, v4 did change behaviour here: the old loop rejected zero-padded
ports such as :0005060 and v4 accepts them. In v5
nf_ct_helper_parse_port() will reject digit runs longer than five
characters, which restores the old behaviour. The old and new
sip_parse_port() give identical results on three million random inputs
in a userspace harness built from the kernel source.
Thanks,
Rahul
prev parent reply other threads:[~2026-09-28 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 9:16 [PATCH nf-next v4 0/4] netfilter: conntrack: shared port parser for helpers Rahul Chandelkar
2026-09-23 12:07 ` [PATCH nf-next v4 1/4] netfilter: conntrack: add shared uint and port parsers " Rahul Chandelkar
2026-09-27 17:37 ` netdev-bot+sashiko
2026-09-28 14:18 ` Rahul Chandelkar
2026-09-23 13:15 ` [PATCH nf-next v4 2/4] netfilter: nf_conntrack_irc: use nf_ct_helper_parse_port() Rahul Chandelkar
2026-09-27 17:37 ` netdev-bot+sashiko
2026-09-28 15:23 ` Rahul Chandelkar
2026-09-23 15:15 ` [PATCH nf-next v4 3/4] netfilter: nf_conntrack_amanda: " Rahul Chandelkar
2026-09-27 17:37 ` netdev-bot+sashiko
2026-09-28 11:58 ` Rahul Chandelkar
2026-09-23 17:15 ` [PATCH nf-next v4 4/4] netfilter: nf_conntrack_sip: use shared helper parsers Rahul Chandelkar
2026-09-27 17:37 ` netdev-bot+sashiko
2026-09-28 13:13 ` Rahul Chandelkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928131348.4160994-1-rc@rexion.ai \
--to=rc@rexion.ai \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox