From: Ido Schimmel <idosch@nvidia.com>
To: Eric Dumazet <edumazet@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, edumazet@google.com,
syzbot+9408fbe0e6452a12e9ab@syzkaller.appspotmail.com
Subject: Re: [PATCH net] ipv6: sr: use skb_get_hash_net() in seg6_make_flowlabel()
Date: Tue, 29 Sep 2026 16:59:46 +0300 [thread overview]
Message-ID: <20260929135946.GA844364@shredder> (raw)
In-Reply-To: <20260928194524.3617299-1-edumazet@kernel.org>
On Mon, Sep 28, 2026 at 07:45:24PM +0000, Eric Dumazet wrote:
> Since commit d58e468b1112 ("flow_dissector: implements flow dissector
> BPF hook") __skb_flow_dissect() needs a net pointer, either from
> skb->dev, skb->sk, or since commit 3cbf4ffba5ee ("net: plumb network
> namespace into __skb_flow_dissect") a caller provided pointer.
>
> syzbot was able to reach seg6_make_flowlabel() with an skb having
> neither skb->dev nor skb->sk set: a TIPC UDP bearer sends a discovery
> message through an IPv4 route using seg6 encap, while
> net.ipv6.seg6_flowlabel is set to 1.
>
> seg6_make_flowlabel() already has a net pointer, use skb_get_hash_net().
[...]
> Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
> Reported-by: syzbot+9408fbe0e6452a12e9ab@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/netdev/6abac2eb.3654fce1.1bec97.0000.GAE@google.com/
> Signed-off-by: Eric Dumazet <edumazet@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Congrats on the domain change :)
next prev parent reply other threads:[~2026-09-29 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 19:45 [PATCH net] ipv6: sr: use skb_get_hash_net() in seg6_make_flowlabel() Eric Dumazet
2026-09-29 5:38 ` Xuanqiang Luo
2026-09-29 13:59 ` Ido Schimmel [this message]
2026-10-01 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929135946.GA844364@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+9408fbe0e6452a12e9ab@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox